From nobody Thu Dec 18 23:40:14 2025 Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6669830E0C5 for ; Tue, 16 Dec 2025 23:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.71 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765928554; cv=none; b=WTxI9xNxF/kP5e0pJQhHRHqYKJSll9/H4yym3qomlKtxeyWzuPzmhtACCmbH/f8Gjiz/nOgLiEZ2mCib3bVbWpW8e2Z33YYQie2W0ZzMXfaEuTYQZpW0p5L/lvmIutwskxQHsDRT4tx/0/0OcdJEyivbokGYiSwHJUAfPIMrexg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765928554; c=relaxed/simple; bh=xWLiy3hlJJIQIVBJPVzUvcVDt9kq7krZ0jUfanPwHYI=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=Z1B9rjciVD++V8MLjGkkjAdHJJNc2HxYyout/Md8TSmGlTBZTnHyo8FIXlxEw4bPfMtIKZW/rDI1+7IPOkzMIKCpAx5Ep907ZRUm26DPGfGm/1B+cjHjkcSnYjoO3TbMSVb06TQWWYYcvAk4LusRWv9APDok56Bgv0QS/UbQMGg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.161.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-65b31ec93e7so9362961eaf.3 for ; Tue, 16 Dec 2025 15:42:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765928552; x=1766533352; h=content-transfer-encoding:to:from:subject:message-id:in-reply-to :date:mime-version:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X5rrLt95CgVcRbPNdFoh+baE/ALjk6ZLgZmoEikz0dA=; b=uDjy+TTzlbNpsFIryZM+/HE55Y1xMN07uK3P/EOcwVucFNTgQBLw4hZ9zaYtpIbfZG vd0Vh/n6gz6i+T70TBEuZvOxhvZqmpPxMFARSykc4+3xqV/KrzhJiWyKQ31LtHrabRQ+ yLBlO4zHEddgjquhV+nFSVey56D7kRJHMVVLUUSomVC6iR0+hXWhzpQ1ErH7T9Kt+2lR BS4F5qKCkZnDHJBsMqm046GmpJ3H79sH576lFynl59GQOJJwumtZxIK54I0tN3JpCTS8 E8dVlH3WZvDlfje/53AqibogE2Oyl1bnNW80q1PItvIu+6FvTXBL+iKUoPI55GYspHgY C7lA== X-Gm-Message-State: AOJu0YxRxzpzPB65R2GiyHR1YQ938JzCGQnQfGJFJknJwweJWIqv7nQ/ hrCG18k9qXQ09EOX7tC+NmC9QggKwpY/xx9vtv9ylP4LOIaYoFfYKDoKggWWo7dHrFKTkh34vG2 fyB64XP55pVH5JZVwiqpSMX0ut5DV4L0nC7pdw0e6J22djpUoAEYQOBJ1BYE= X-Google-Smtp-Source: AGHT+IGZuyUnF3rqszBteJ1somQo04T3kxs6zj0I1T4gjlLSU03S+VyJB7nloNnTH650+nXoJ0vhyQ7qsaJ4BrFD3Vapx9iy/tTL Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:2224:b0:659:9a49:8f2b with SMTP id 006d021491bc7-65b452250e4mr6683897eaf.60.1765928552486; Tue, 16 Dec 2025 15:42:32 -0800 (PST) Date: Tue, 16 Dec 2025 15:42:32 -0800 In-Reply-To: <69412f2b.a70a0220.104cf0.034b.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <6941ee68.a70a0220.207337.0020.GAE@google.com> Subject: Forwarded: Re: [syzbot] [net?] [usb?] memory leak in rtl8150_set_multicast From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: Re: [syzbot] [net?] [usb?] memory leak in rtl8150_set_multicast Author: rakagunarto@gmail.com #syz test async_set_registers() does not free the urb and req on the usb_submit_urb() call fail path. Fix by freeing both objects. Reported-by: syzbot+8dd915c7cb0490fc8c52@syzkaller.appspotmail.com Signed-off-by: Raka Gunarto --- drivers/net/usb/rtl8150.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index 278e6cb6f4..0f6c700a85 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c @@ -211,6 +211,8 @@ static int async_set_registers(rtl8150_t *dev, u16 indx, u16 size, u16 reg) if (res =3D=3D -ENODEV) netif_device_detach(dev->netdev); dev_err(&dev->udev->dev, "%s failed with %d\n", __func__, r= es); + usb_free_urb(async_urb); + kfree(req); } return res; } -- 2.25.1 On Tue, Dec 16, 2025 at 11:23=E2=80=AFPM Raka Gunarto wrote: > > async_set_registers() does not free the urb and req on the > usb_submit_urb() call fail path. Fix by freeing both objects. > > Reported-by: syzbot+8dd915c7cb0490fc8c52@syzkaller.appspotmail.com > Signed-off-by: Raka Gunarto > --- > drivers/net/usb/rtl8150.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c > index 278e6cb6f4..0f6c700a85 100644 > --- a/drivers/net/usb/rtl8150.c > +++ b/drivers/net/usb/rtl8150.c > @@ -211,6 +211,8 @@ static int async_set_registers(rtl8150_t *dev, u16 > indx, u16 size, u16 reg) > if (res =3D=3D -ENODEV) > netif_device_detach(dev->netdev); > dev_err(&dev->udev->dev, "%s failed with %d\n", __func__,= res); > + usb_free_urb(async_urb); > + kfree(req); > } > return res; > } > -- > 2.25.1