From nobody Sat Feb 7 20:43:55 2026 Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41715339B4F for ; Tue, 28 Oct 2025 18:19:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.198 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761675575; cv=none; b=hBjs4Akmgf3F81wm42fmc89/PkC7ZMMIE1ANdqNiY3ogLwSGMqMCqhhP92Q2i6DUJoL21fFLa+pV+krUOC72yvF6PRam9hearvDBez1g6wydnoMvk839YAZSu2Q1MB/OuCyzGAZUqSNAMDzFX7zuf2knxUfoxucpkw3In7WMwb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761675575; c=relaxed/simple; bh=g0HTuNgWUHj6cam7BZORXKIhUY3deC5vioyYljXWgqg=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=gEdU2z2m8ZZKQxLSNiaqSDZINGyTN/ktf+cU4K/YJG+zdW4mAf5LnTEylWBUVFn2CvfBkaQPDgz9m4KlQqr0xZLb+rb16UEzyxp/63w66V5aN6AC502fFShHEdQ9cLvvJiT+gXTZOy9FyKfUst/ELhVJIjzwLn7eYtVRP5365y8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.166.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-il1-f198.google.com with SMTP id e9e14a558f8ab-430d789ee5aso81872615ab.2 for ; Tue, 28 Oct 2025 11:19:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761675572; x=1762280372; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TfXTmmK3puFuK381TWyTUm9O8YcJG4OMvs9xdi/t8Zs=; b=MHhPmvrxrLXMp5KRlI5Zj2YrxD+bXe0wqlg3ijxfb62yVJv3mU85znRriAgSkpCKW3 hSTZ1fyewy/G+80AoNV9BIcimi6BmOzDHr7RomB6M4cr9YHXVpj9qfFKR0x+Bu+lZl7W FcEZJrOopBk6TCkdM7Ssft0U9QQwr8619s8VHP5PIlUzYYUX1IKw4BV7BogYxODkU151 YwPCZV6C4vk04u/VX32m0XwLT3BIfqtjsuSKmOzG7OhxBdwHl3ig7zGBBqap+izbh+Bm k9nDVfl1+yDQqIm47Xi8rryxv7NdNKHXwwwRMDv474EaAuT/vbCFhbDQBUWfPjSnHXlw nvVw== X-Gm-Message-State: AOJu0YzO6Q+wlMEfGHe+UOxn5f3mfkBSdc/3Tw4ko4w1tLBh4XnebZZS RxJCF/54GwR3zYu1O/wU4+VlzDtzF5llkV7pYsIdS3jySmo0UC3EuH/Vm3FiMMfES0I0I3BPj8r VCafz/h+01yjfSUYZO8LE95q5/ST9JT6tjx6q2sWOziiD9/wOgvAIfRoSAAg= X-Google-Smtp-Source: AGHT+IHGuAZ1tfSkYnEKoUZB3LpFRf8vpzfHTGMaPI8ocatXsjGMENEwDPGXRf277lQWWLXxbHA6nLGYXPlr8t6yLhs9Y5BXOK0a Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6e02:144a:b0:430:ae26:7c19 with SMTP id e9e14a558f8ab-432f8e6de6fmr2816975ab.0.1761675572386; Tue, 28 Oct 2025 11:19:32 -0700 (PDT) Date: Tue, 28 Oct 2025 11:19:32 -0700 In-Reply-To: <68d913e1.050a0220.1696c6.0003.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <69010934.050a0220.3344a1.03bf.GAE@google.com> Subject: Forwarded: #syz test https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git linux-5.10.y From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: #syz test https://git.kernel.org/pub/scm/linux/kernel/git/stable/l= inux.git linux-5.10.y Author: dmantipov@yandex.ru diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 94c7acfebe18..0e0a4742b8a6 100644 --- a/fs/ocfs2/alloc.c +++ b/fs/ocfs2/alloc.c @@ -6155,6 +6155,9 @@ static int ocfs2_get_truncate_log_info(struct ocfs2_s= uper *osb, int status; struct inode *inode =3D NULL; struct buffer_head *bh =3D NULL; + struct ocfs2_dinode *di; + struct ocfs2_truncate_log *tl; + unsigned int tl_count, tl_used; =20 inode =3D ocfs2_get_system_file_inode(osb, TRUNCATE_LOG_SYSTEM_INODE, @@ -6172,6 +6175,19 @@ static int ocfs2_get_truncate_log_info(struct ocfs2_= super *osb, goto bail; } =20 + di =3D (struct ocfs2_dinode *)bh->b_data; + tl =3D &di->id2.i_dealloc; + tl_used =3D le16_to_cpu(tl->tl_used); + tl_count =3D le16_to_cpu(tl->tl_count); + if (unlikely(tl_count > ocfs2_truncate_recs_per_inode(osb->sb) || + tl_count =3D=3D 0 || tl_used > tl_count)) { + status =3D -EFSCORRUPTED; + iput(inode); + brelse(bh); + mlog_errno(status); + goto bail; + } + *tl_inode =3D inode; *tl_bh =3D bh; bail: diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 195515eefd33..869cc09e86a8 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -304,8 +304,21 @@ static int ocfs2_check_dir_entry(struct inode *dir, unsigned long offset) { const char *error_msg =3D NULL; - const int rlen =3D le16_to_cpu(de->rec_len); - const unsigned long next_offset =3D ((char *) de - buf) + rlen; + unsigned long next_offset; + int rlen; + + if (offset > size - OCFS2_DIR_REC_LEN(1)) { + /* Dirent is (maybe partially) beyond the buffer + * boundaries so touching 'de' members is unsafe. + */ + mlog(ML_ERROR, "directory entry (#%llu: offset=3D%lu) " + "too close to end or out-of-bounds", + (unsigned long long)OCFS2_I(dir)->ip_blkno, offset); + return 0; + } + + rlen =3D le16_to_cpu(de->rec_len); + next_offset =3D ((char *) de - buf) + rlen; =20 if (unlikely(rlen < OCFS2_DIR_REC_LEN(1))) error_msg =3D "rec_len is smaller than minimal"; @@ -780,6 +793,14 @@ static int ocfs2_dx_dir_lookup_rec(struct inode *inode, struct ocfs2_extent_block *eb; struct ocfs2_extent_rec *rec =3D NULL; =20 + if (le16_to_cpu(el->l_count) !=3D + ocfs2_extent_recs_per_dx_root(inode->i_sb)) { + ret =3D ocfs2_error(inode->i_sb, + "Inode %lu has invalid extent list length %u\n", + inode->i_ino, le16_to_cpu(el->l_count)); + goto out; + } + if (el->l_tree_depth) { ret =3D ocfs2_find_leaf(INODE_CACHE(inode), el, major_hash, &eb_bh); @@ -3418,6 +3439,14 @@ static int ocfs2_find_dir_space_id(struct inode *dir= , struct buffer_head *di_bh, offset +=3D le16_to_cpu(de->rec_len); } =20 + if (!last_de) { + ret =3D ocfs2_error(sb, "Directory entry (#%llu: size=3D%lld) " + "is unexpectedly short", + (unsigned long long)OCFS2_I(dir)->ip_blkno, + i_size_read(dir)); + goto out; + } + /* * We're going to require expansion of the directory - figure * out how many blocks we'll need so that a place for the @@ -4109,10 +4138,15 @@ static int ocfs2_expand_inline_dx_root(struct inode= *dir, } =20 dx_root->dr_flags &=3D ~OCFS2_DX_FLAG_INLINE; - memset(&dx_root->dr_list, 0, osb->sb->s_blocksize - - offsetof(struct ocfs2_dx_root_block, dr_list)); + + dx_root->dr_list.l_tree_depth =3D 0; dx_root->dr_list.l_count =3D cpu_to_le16(ocfs2_extent_recs_per_dx_root(osb->sb)); + dx_root->dr_list.l_next_free_rec =3D 0; + memset(&dx_root->dr_list.l_recs, 0, + osb->sb->s_blocksize - + (offsetof(struct ocfs2_dx_root_block, dr_list) + + offsetof(struct ocfs2_extent_list, l_recs))); =20 /* This should never fail considering we start with an empty * dx_root. */ diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 7c9dfd50c1c1..17f4106a15df 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c @@ -1418,6 +1418,31 @@ int ocfs2_validate_inode_block(struct super_block *s= b, goto bail; } =20 + if (le32_to_cpu(di->i_flags) & OCFS2_CHAIN_FL) { + struct ocfs2_chain_list *cl =3D &di->id2.i_chain; + + if (le16_to_cpu(cl->cl_count) !=3D ocfs2_chain_recs_per_inode(sb)) { + rc =3D ocfs2_error(sb, "Invalid dinode %llu: chain list count %u\n", + (unsigned long long)bh->b_blocknr, + le16_to_cpu(cl->cl_count)); + goto bail; + } + if (le16_to_cpu(cl->cl_next_free_rec) > le16_to_cpu(cl->cl_count)) { + rc =3D ocfs2_error(sb, "Invalid dinode %llu: chain list index %u\n", + (unsigned long long)bh->b_blocknr, + le16_to_cpu(cl->cl_next_free_rec)); + goto bail; + } + } + + if ((le16_to_cpu(di->i_dyn_features) & OCFS2_INLINE_DATA_FL) && + le32_to_cpu(di->i_clusters)) { + rc =3D ocfs2_error(sb, "Invalid dinode %llu: %u clusters\n", + (unsigned long long)bh->b_blocknr, + le32_to_cpu(di->i_clusters)); + goto bail; + } + rc =3D 0; =20 bail: diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c index fc8252a28cb1..f60a2f286392 100644 --- a/fs/ocfs2/localalloc.c +++ b/fs/ocfs2/localalloc.c @@ -912,13 +912,11 @@ static int ocfs2_local_alloc_find_clear_bits(struct o= cfs2_super *osb, static void ocfs2_clear_local_alloc(struct ocfs2_dinode *alloc) { struct ocfs2_local_alloc *la =3D OCFS2_LOCAL_ALLOC(alloc); - int i; =20 alloc->id1.bitmap1.i_total =3D 0; alloc->id1.bitmap1.i_used =3D 0; la->la_bm_off =3D 0; - for(i =3D 0; i < le16_to_cpu(la->la_size); i++) - la->la_bitmap[i] =3D 0; + memset(la->la_bitmap, 0, le16_to_cpu(la->la_size)); } =20 #if 0 diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c index 98e77ea957ff..8732965760d2 100644 --- a/fs/ocfs2/move_extents.c +++ b/fs/ocfs2/move_extents.c @@ -100,7 +100,13 @@ static int __ocfs2_move_extent(handle_t *handle, =20 rec =3D &el->l_recs[index]; =20 - BUG_ON(ext_flags !=3D rec->e_flags); + if (ext_flags !=3D rec->e_flags) { + ret =3D ocfs2_error(inode->i_sb, + "Inode %llu has corrupted extent %d with flags 0x%x at cpos %u\n", + (unsigned long long)ino, index, rec->e_flags, cpos); + goto out; + } + /* * after moving/defraging to new location, the extent is not going * to be refcounted anymore. @@ -1034,6 +1040,12 @@ int ocfs2_ioctl_move_extents(struct file *filp, void= __user *argp) if (range.me_threshold > i_size_read(inode)) range.me_threshold =3D i_size_read(inode); =20 + if (range.me_flags & ~(OCFS2_MOVE_EXT_FL_AUTO_DEFRAG | + OCFS2_MOVE_EXT_FL_PART_DEFRAG)) { + status =3D -EINVAL; + goto out_free; + } + if (range.me_flags & OCFS2_MOVE_EXT_FL_AUTO_DEFRAG) { context->auto_defrag =3D 1; =20 diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h index 19137c6d087b..91f660ce3098 100644 --- a/fs/ocfs2/ocfs2_fs.h +++ b/fs/ocfs2/ocfs2_fs.h @@ -470,7 +470,8 @@ struct ocfs2_extent_list { __le16 l_reserved1; __le64 l_reserved2; /* Pad to sizeof(ocfs2_extent_rec) */ -/*10*/ struct ocfs2_extent_rec l_recs[]; /* Extent records */ + /* Extent records */ +/*10*/ struct ocfs2_extent_rec l_recs[] __counted_by_le(l_count); }; =20 /* @@ -484,7 +485,8 @@ struct ocfs2_chain_list { __le16 cl_count; /* Total chains in this list */ __le16 cl_next_free_rec; /* Next unused chain slot */ __le64 cl_reserved1; -/*10*/ struct ocfs2_chain_rec cl_recs[]; /* Chain records */ + /* Chain records */ +/*10*/ struct ocfs2_chain_rec cl_recs[] __counted_by_le(cl_count); }; =20 /* @@ -496,7 +498,8 @@ struct ocfs2_truncate_log { /*00*/ __le16 tl_count; /* Total records in this log */ __le16 tl_used; /* Number of records in use */ __le32 tl_reserved1; -/*08*/ struct ocfs2_truncate_rec tl_recs[]; /* Truncate records */ + /* Truncate records */ +/*08*/ struct ocfs2_truncate_rec tl_recs[] __counted_by_le(tl_count); }; =20 /* @@ -640,7 +643,7 @@ struct ocfs2_local_alloc __le16 la_size; /* Size of included bitmap, in bytes */ __le16 la_reserved1; __le64 la_reserved2; -/*10*/ __u8 la_bitmap[]; +/*10*/ __u8 la_bitmap[] __counted_by_le(la_size); }; =20 /* @@ -653,7 +656,7 @@ struct ocfs2_inline_data * for data, starting at id_data */ __le16 id_reserved0; __le32 id_reserved1; - __u8 id_data[]; /* Start of user data */ + __u8 id_data[] __counted_by_le(id_count); /* Start of user data */ }; =20 /* @@ -798,9 +801,10 @@ struct ocfs2_dx_entry_list { * possible in de_entries */ __le16 de_num_used; /* Current number of * de_entries entries */ - struct ocfs2_dx_entry de_entries[]; /* Indexed dir entries - * in a packed array of - * length de_num_used */ + /* Indexed dir entries in a packed + * array of length de_num_used. + */ + struct ocfs2_dx_entry de_entries[] __counted_by_le(de_count); }; =20 #define OCFS2_DX_FLAG_INLINE 0x01 @@ -935,7 +939,8 @@ struct ocfs2_refcount_list { __le16 rl_used; /* Current number of used records */ __le32 rl_reserved2; __le64 rl_reserved1; /* Pad to sizeof(ocfs2_refcount_record) */ -/*10*/ struct ocfs2_refcount_rec rl_recs[]; /* Refcount records */ + /* Refcount records */ +/*10*/ struct ocfs2_refcount_rec rl_recs[] __counted_by_le(rl_count); }; =20 =20 @@ -1021,7 +1026,8 @@ struct ocfs2_xattr_header { buckets. A block uses xb_check and sets this field to zero.) */ - struct ocfs2_xattr_entry xh_entries[]; /* xattr entry list. */ + /* xattr entry list. */ + struct ocfs2_xattr_entry xh_entries[] __counted_by_le(xh_count); }; =20 /*