From nobody Tue Feb 10 07:40:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44FA148C3FF; Wed, 21 Jan 2026 14:11:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769004696; cv=none; b=GpQil0POn58Mj6dY362GhVoekfTDf2gaKgoMC/aU2MIE0dztzx8wN4kJQoqoBJTB5/hQuq4sZjMpva5i128vgH8yg/mTfl/Hsbjn6583iKItRSI6tdX7LSeyihlIbCBVg4T0a0PjdInXE60O12JT7NewvUo/yW/Zylt7s3C8ZOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769004696; c=relaxed/simple; bh=vaLFZ4d9a2vOXPbplXYpViMr1qmGtkCweSDpn09S8Rs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bZu0yjwiOMuAR4+YH/x6Hk+qcXhGXRcHGbG1ISvDhc+pQdVP3yejdbDAex2i+ciP2ofzPiG8YYncqJZ1Dt7qXVHnvnTJ3BAyfmv5Zg/DYlSA8fIZPWWgGWMA3eeVMBSOC3KO356+0nCrH+gXuZjV+84CiGmfagzYJLkbCZF9zUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B35E6C116D0; Wed, 21 Jan 2026 14:11:34 +0000 (UTC) From: Geert Uytterhoeven To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 3/4] usb: phy: generic: Convert to dev_err_probe() Date: Wed, 21 Jan 2026 15:11:22 +0100 Message-ID: <68739eb048a394fe9198080e4e57503bb2fb9b64.1769004444.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the remaining error handling in the probe path to use the dev_err_probe() helper, to make sure error messages and codes are not missed, and recorded properly. Signed-off-by: Geert Uytterhoeven --- drivers/usb/phy/phy-generic.c | 31 +++++++++++++------------------ 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index 53b0262e6e306ada..9f3a38b93f2649a8 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -227,18 +227,15 @@ int usb_phy_gen_create_phy(struct device *dev, struct= usb_phy_generic *nop) return -ENOMEM; =20 nop->clk =3D devm_clk_get_optional(dev, "main_clk"); - if (IS_ERR(nop->clk)) { - dev_dbg(dev, "Can't get phy clock: %ld\n", - PTR_ERR(nop->clk)); - return PTR_ERR(nop->clk); - } + if (IS_ERR(nop->clk)) + return dev_err_probe(dev, PTR_ERR(nop->clk), + "Can't get phy clock\n"); =20 if (clk_rate) { err =3D clk_set_rate(nop->clk, clk_rate); - if (err) { - dev_err(dev, "Error setting clock rate\n"); - return err; - } + if (err) + return dev_err_probe(dev, err, + "Error setting clock rate\n"); } =20 nop->vcc =3D devm_regulator_get_optional(dev, "vcc"); @@ -283,17 +280,17 @@ static int usb_phy_generic_probe(struct platform_devi= ce *pdev) err =3D usb_phy_gen_create_phy(dev, nop); if (err) return err; + if (nop->gpiod_vbus) { err =3D devm_request_threaded_irq(dev, gpiod_to_irq(nop->gpiod_vbus), NULL, nop_gpio_vbus_thread, VBUS_IRQ_FLAGS, "vbus_detect", nop); - if (err) { - dev_err(dev, "can't request irq %i, err: %d\n", - gpiod_to_irq(nop->gpiod_vbus), err); - return err; - } + if (err) + return dev_err_probe(dev, err, "can't request irq %i\n", + gpiod_to_irq(nop->gpiod_vbus)); + nop->phy.otg->state =3D gpiod_get_value(nop->gpiod_vbus) ? OTG_STATE_B_PERIPHERAL : OTG_STATE_B_IDLE; } @@ -302,10 +299,8 @@ static int usb_phy_generic_probe(struct platform_devic= e *pdev) nop->phy.shutdown =3D usb_gen_phy_shutdown; =20 err =3D usb_add_phy_dev(&nop->phy); - if (err) { - dev_err(dev, "can't register transceiver, err: %d\n", err); - return err; - } + if (err) + return dev_err_probe(dev, err, "can't register transceiver\n"); =20 platform_set_drvdata(pdev, nop); =20 --=20 2.43.0