From nobody Wed Oct 8 17:34:34 2025 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBC2D2C1593 for ; Wed, 25 Jun 2025 15:22:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750864939; cv=none; b=ajG7/Sctil3Eq1Grnow9AjDVtYabstBZXMY4CswBSIe2Zqgwd7wx+3BAI7dz4izCv5YIQ2T++QaQNirBWlzLslsZFj+FYgEqMG9FjmyvPkH6cVpkFkh1WmHWVTAUMA0+4Qa/D8OP1C6gm2nZ7IOQXgDyT/jubxQ8xBjZcleXqI8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750864939; c=relaxed/simple; bh=5JYFEh/B1NhPLzWK+CJdykCD+u6h119UFbAkSy5RZmE=; h=Message-ID:Date:From:To:Cc:Subject:MIME-Version:Content-Type: Content-Disposition; b=g93mBvyIcgdc1x3zIgeYUhV6ls7OLKOqX1frvQ4STNApzFabwpji9m0uLoq9nZUhzC3gxdWeu6AJgcIESiRBwY6N2zcUFQZfIaS5mS1OePhfOh4owz6bCDGZwxzPiwg7cYAVCZMhpggWiKePtBFblcYOO4XOhRmVPIw/O1nfiH8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=w/OqBbMw; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w/OqBbMw" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2ef461b9daeso22947fac.2 for ; Wed, 25 Jun 2025 08:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750864937; x=1751469737; darn=vger.kernel.org; h=content-disposition:mime-version:subject:cc:to:from:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U+WU1qicrpfWVxiSKMDNqBCOmYnFjqwgecK16bJOOCw=; b=w/OqBbMwHZOSNUVqi+Oi00ejnZH4Hgk3KZLyBAfsqABeI7u0R1/kUqG9wXPtnpH10E nWhwgVPkBNkbyXij5hrvpdQrcUmaYhgRRxV0ojB+r2gP69p/K+ztzZIYsxdFNmYgmQDU 0qr53s1CuCK1V4cvA5h3AkRKxAmQPBIvr+CoBAsuagPghLF8GFL3RiX2dWbaWW+/PPrm QpOavzRlLrCJaGZ1B3uTEyvvtGC3nl1f+sNBhPJKC0RCDRgGJP45pXjBvZJDXx8LnCaU wdAUzDPZ16WdXQxCHmNoguYVFRum07XQvMiagHefKrm58IiRpEUdyWYva/Lxju3/U3aJ kvfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750864937; x=1751469737; h=content-disposition:mime-version:subject:cc:to:from:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U+WU1qicrpfWVxiSKMDNqBCOmYnFjqwgecK16bJOOCw=; b=wgW19YcpacG/uQgvcqIPekdVa5Gk9ubZgNdUAsV1jUnjrVbiEllnXKpMxLQD/mD8Ho DqIRfHT/QnqzU2PXC+px3iQIC8OAitFrgZAkmaAUg9Hq/TCnQAyE/QGE7pRsZhxp9zHN 4VrgoxEefVE4+PCy1HQHbje96KD6Qiz/20tRAvXwETqYXqpIsT9VJ8bNkVjxDAC58QPT 7f0B54Sxo4NhySTupi5E8OEBRptX2o4IQsdZnT1MxFRwfJry5WD/41ASuxGERa+D+gc9 WK4jkZ6jv8R4d0TM/OgUqoAycWjY6ipo2klszJ4ShFMmZEWYnr0vyIlCaIPmywRv3KMt qtXA== X-Forwarded-Encrypted: i=1; AJvYcCVfDM/3IypA6s/elJXVBqhnTQbFdLGMssuXi8OBKbezATCosuOwqBi5JPbyIKTjCYU6Pralp0A5gCpQeMg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3EABbI8dR8iUctvPyy2MBvCOqCDMzMYx5F6OYCK7NhBJsSQsS AUkH/q+XaMPqH+bTAmDStS9NXiPjjXdrVfsxZMr08Htc4gH7TyGbuhY1e7rizzA9Fk6hLIltEVs lDCzf X-Gm-Gg: ASbGncvG+9JdLVyHCY2tRrFV9MqFoBmPTNUsMPqCW6rSf/+X84Q6vOtzh0okUP196mV k9f8nYhcK7zj2OS/GH7OGaE83Ov05+wwLCetcUW0ZzqLXDGnDQ8PWabk24ZFRitxRuB/6CKng+f KfrjPeF/x6AUg0eGvVmrDfjPW7aYEPiMI/IvDz5D4SUxZ8EWHFd+OFKifvj8v+UbypyXmhdPluv Ia6wEd5ffNsZ+JCfskcjhYuzcw0g0w1/eqe6dL0bvox+4RXnNjC19l1k+KhpYeeR62RAOaNNgHU sok0jsA+3DPEscur3uy06vLUvqPFbjiRfb6v56Jw60wij+P2EPPCpsvRvo8TjUVnKqo0RA== X-Google-Smtp-Source: AGHT+IErLXYfNY1HcYwO06oS9rTd+ujnf6KFvXKf60FWeDN2HmwrG9jFGq4oLf9AmCw0fBHgkeUDew== X-Received: by 2002:a05:6870:e254:b0:2b7:f58d:6dcf with SMTP id 586e51a60fabf-2efce2d359amr92580fac.18.1750864936838; Wed, 25 Jun 2025 08:22:16 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:1fca:a60b:12ab:43a3]) by smtp.gmail.com with UTF8SMTPSA id 586e51a60fabf-2ee8dd151d9sm2595012fac.33.2025.06.25.08.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 08:22:16 -0700 (PDT) Message-ID: <685c1428.050a0220.346d5e.eafa@mx.google.com> X-Google-Original-Message-ID: <@sabinyo.mountain> Date: Wed, 25 Jun 2025 10:22:15 -0500 From: Dan Carpenter To: David Hildenbrand Cc: Oscar Salvador , Andrew Morton , Harry Yoo , Jonathan Cameron , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] mm,memory_hotplug: set failure reason in offline_pages() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "reason" variable is uninitialized on this error path. It's supposed to explain why the function failed. Fixes: e4e2806b639c ("mm,memory_hotplug: implement numa node notifier") Signed-off-by: Dan Carpenter Acked-by: David Hildenbrand --- mm/memory_hotplug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 4d864b4fb891..e954f81b55a0 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1977,8 +1977,10 @@ int offline_pages(unsigned long start_pfn, unsigned = long nr_pages, node_arg.nid =3D node; ret =3D node_notify(NODE_REMOVING_LAST_MEMORY, &node_arg); ret =3D notifier_to_errno(ret); - if (ret) + if (ret) { + reason =3D "nr_pages more than present_pages"; goto failed_removal_isolated; + } } =20 ret =3D memory_notify(MEM_GOING_OFFLINE, &mem_arg);