From nobody Sun Dec 28 22:54:20 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1BC3C4167B for ; Tue, 5 Dec 2023 09:55:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344937AbjLEJz3 (ORCPT ); Tue, 5 Dec 2023 04:55:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbjLEJz0 (ORCPT ); Tue, 5 Dec 2023 04:55:26 -0500 Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 10E2BA0; Tue, 5 Dec 2023 01:55:32 -0800 (PST) Received: from SIOS1075.ysato.name (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id 2DA221C066B; Tue, 5 Dec 2023 18:46:48 +0900 (JST) From: Yoshinori Sato To: linux-sh@vger.kernel.org Cc: Yoshinori Sato , Damien Le Moal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Thomas Gleixner , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , Greg Kroah-Hartman , Jiri Slaby , Magnus Damm , Daniel Lezcano , Rich Felker , John Paul Adrian Glaubitz , Lee Jones , Helge Deller , Heiko Stuebner , Jernej Skrabec , Chris Morgan , Linus Walleij , Randy Dunlap , Arnd Bergmann , Hyeonggon Yoo <42.hyeyoo@gmail.com>, David Rientjes , Vlastimil Babka , Baoquan He , Andrew Morton , Guenter Roeck , Stephen Rothwell , Guo Ren , Javier Martinez Canillas , Azeem Shaikh , Palmer Dabbelt , Bin Meng , Max Filippov , Tom Rix , Herve Codina , Jacky Huang , Lukas Bulwahn , Jonathan Corbet , Biju Das , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sam Ravnborg , Michael Karcher , Sergey Shtylyov , Laurent Pinchart , linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [DO NOT MERGE v5 23/37] mfd: sm501: Convert platform_data to OF property Date: Tue, 5 Dec 2023 18:45:42 +0900 Message-Id: <68532082074b0c8fe9945b481678aab77520f517.1701768028.git.ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Various parameters of SM501 can be set using platform_data, so parameters cannot be passed in the DeviceTree target. Expands the parameters set in platform_data so that they can be specified using DeviceTree properties. Signed-off-by: Yoshinori Sato --- drivers/mfd/sm501.c | 99 +++++++++++++++++++++++++++++++++++ drivers/video/fbdev/sm501fb.c | 82 +++++++++++++++++++++++++++++ 2 files changed, 181 insertions(+) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 28027982cf69..f0104fdf0f34 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -1370,6 +1370,99 @@ static int sm501_init_dev(struct sm501_devdata *sm) return 0; } =20 +static void sm501_of_read_reg_init(struct device_node *np, + const char *propname, struct sm501_reg_init *val) +{ + u32 u32_val[2]; + + if (!of_property_read_u32_array(np, propname, u32_val, sizeof(u32_val))) { + val->set =3D u32_val[0]; + val->mask =3D u32_val[1]; + } +} + +/* Read GPIO I2C configuration */ +static int sm501_parse_dt_gpio_i2c(struct device *dev, struct sm501_platda= ta *plat, + struct device_node *np) +{ + struct sm501_platdata_gpio_i2c *gpio_i2c_p; + struct property *prop; + u32 gpio_i2c[5]; + const __be32 *p; + unsigned int i; + u32 i2c_nr; + + prop =3D of_find_property(np, "smi,gpio-i2c", NULL); + if (!prop) + return 0; + + i2c_nr =3D of_property_count_u32_elems(np, "smi,gpio-i2c"); + + /* GPIO I2C define 5 words per channel. */ + if (i2c_nr % 5) + return -EINVAL; + i2c_nr /=3D 5; + plat->gpio_i2c =3D devm_kzalloc(dev, sizeof(*plat->gpio_i2c) * i2c_nr, + GFP_KERNEL); + if (!plat->gpio_i2c) + return -ENOMEM; + + plat->gpio_i2c_nr =3D i2c_nr; + gpio_i2c_p =3D plat->gpio_i2c; + + for (; i2c_nr > 0; i2c_nr--) { + for (i =3D 0; i < ARRAY_SIZE(gpio_i2c); i++) { + p =3D of_prop_next_u32(prop, p, &gpio_i2c[i]); + if (!p) + return -EINVAL; + } + gpio_i2c_p->bus_num =3D gpio_i2c[0]; + gpio_i2c_p->pin_sda =3D gpio_i2c[1]; + gpio_i2c_p->pin_scl =3D gpio_i2c[2]; + gpio_i2c_p->udelay =3D gpio_i2c[3]; + gpio_i2c_p->timeout =3D gpio_i2c[4]; + gpio_i2c_p++; + } + return 0; +} + +/* Build platform_data from OF property */ +static int sm501_parse_dt(struct sm501_devdata *sm, struct device_node *np) +{ + struct sm501_platdata *plat; + u32 u32_val; + int ret; + + plat =3D devm_kzalloc(sm->dev, sizeof(*plat), GFP_KERNEL); + if (!plat) + return -ENOMEM; + + plat->init =3D devm_kzalloc(sm->dev, sizeof(*plat->init), GFP_KERNEL); + if (!plat->init) + return -ENOMEM; + + if (!of_property_read_u32(np, "smi,devices", &u32_val)) + plat->init->devices =3D u32_val; + if (!of_property_read_u32(np, "smi,mclk", &u32_val)) + plat->init->mclk =3D u32_val; + if (!of_property_read_u32(np, "smi,m1xclk", &u32_val)) + plat->init->m1xclk =3D u32_val; + + sm501_of_read_reg_init(np, "smi,misc-timing", &plat->init->misc_timing); + sm501_of_read_reg_init(np, "smi,misc-control", &plat->init->misc_control); + sm501_of_read_reg_init(np, "smi,gpio-low", &plat->init->gpio_low); + sm501_of_read_reg_init(np, "smi,gpio-high", &plat->init->gpio_high); + + if (IS_ENABLED(CONFIG_MFD_SM501_GPIO) && + (plat->init->devices & SM501_USE_GPIO)) { + ret =3D sm501_parse_dt_gpio_i2c(sm->dev, plat, np); + if (ret) + return ret; + } + sm->platdata =3D plat; + return 0; +} + static int sm501_plat_probe(struct platform_device *dev) { struct sm501_devdata *sm; @@ -1406,6 +1499,12 @@ static int sm501_plat_probe(struct platform_device *= dev) goto err_res; } =20 + if (IS_ENABLED(CONFIG_OF) && dev->dev.of_node) { + ret =3D sm501_parse_dt(sm, dev->dev.of_node); + if (ret) + goto err_res; + } + platform_set_drvdata(dev, sm); =20 sm->regs =3D ioremap(sm->io_res->start, resource_size(sm->io_res)); diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c index d6fdc1737cd2..d35285819d28 100644 --- a/drivers/video/fbdev/sm501fb.c +++ b/drivers/video/fbdev/sm501fb.c @@ -1932,6 +1932,82 @@ static int sm501fb_start_one(struct sm501fb_info *in= fo, return 0; } =20 +#if defined(CONFIG_OF) +/* parse CRT / panel configuration */ +static struct sm501_platdata_fbsub *dt_fbsub(struct device *dev, + struct device_node *np, + const char *name) +{ + struct sm501_platdata_fbsub *fbsub =3D NULL; + struct fb_videomode *def_mode =3D NULL; + struct device_node *child; + const void *p_edid; + u32 flags =3D 0; + u32 bpp =3D 0; + int len; + + child =3D of_get_child_by_name(np, name); + if (child =3D=3D NULL) + return NULL; + + p_edid =3D of_get_property(child, "edid", &len); + if (p_edid && len =3D=3D EDID_LENGTH) { + struct fb_monspecs *specs; + u8 *edid; + + edid =3D kmemdup(p_edid, EDID_LENGTH, GFP_KERNEL); + if (edid) { + specs =3D kzalloc(sizeof(*specs), GFP_KERNEL); + if (specs) { + fb_edid_to_monspecs(edid, specs); + def_mode =3D specs->modedb; + } + } + kfree(edid); + } + + of_property_read_u32(child, "bpp", &bpp); + + /* If flags property is obtained, fbsub is returned. */ + if (!of_property_read_u32(child, "smi,flags", &flags)) { + fbsub =3D devm_kzalloc(dev, sizeof(*fbsub), GFP_KERNEL); + if (fbsub) { + fbsub->def_mode =3D def_mode; + fbsub->def_bpp =3D bpp; + fbsub->flags =3D flags; + } + } + return fbsub; +} + +/* Build platform_data from OF property */ +static struct sm501_platdata_fb *pdata_from_dt(struct device *dev, struct = device_node *np) +{ + enum sm501_fb_routing fb_route =3D SM501_FB_OWN; + struct sm501_platdata_fb *pdata =3D NULL; + struct sm501_platdata_fbsub *fb_crt; + struct sm501_platdata_fbsub *fb_pnl; + unsigned int flags =3D 0; + + if (of_property_read_bool(np, "route-crt-panel")) + fb_route =3D SM501_FB_CRT_PANEL; + if (of_property_read_bool(np, "swap-fb-endian")) + flags =3D SM501_FBPD_SWAP_FB_ENDIAN; + fb_crt =3D dt_fbsub(dev, np, "crt"); + fb_pnl =3D dt_fbsub(dev, np, "panel"); + if (fb_crt || fb_pnl) { + pdata =3D devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (pdata) { + pdata->fb_route =3D fb_route; + pdata->flags =3D flags; + pdata->fb_crt =3D fb_crt; + pdata->fb_pnl =3D fb_pnl; + } + } + return pdata; +} +#endif + static int sm501fb_probe(struct platform_device *pdev) { struct sm501fb_info *info; @@ -1974,6 +2050,12 @@ static int sm501fb_probe(struct platform_device *pde= v) if (info->edid_data) found =3D 1; } + /* Get platform data compatible configuration */ + if (!found) { + info->pdata =3D pdata_from_dt(dev, np); + if (info->pdata) + found =3D 1; + } } #endif if (!found) { --=20 2.39.2