From nobody Fri Oct 10 02:45:21 2025 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2070.outbound.protection.outlook.com [40.107.236.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53A67285CA1; Mon, 16 Jun 2025 11:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750075150; cv=fail; b=lC+X1/WPZmCVT5PIFd0KB6nYv5wFiUb56TQRowWCCUYoX9NkW2f16uNs6mpIR3oFSoSp6A1BkAURqdMss+pw0E42MjydpoyH+LBv90ZbsUTNho2KPQvlOwNvdlKbRVwC4di1aY6CNoS6oUzPH71PWixEwR2GSldEz7+l1kSWRXs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750075150; c=relaxed/simple; bh=NzIr0tANSNSbXLcQ/MZ3GdCv5rRjD2vZSDfH2x7w3Co=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=BNSRmR8jWqNebHDNr6212Fe6KPP47n5KUtYKjd3eMQiSQT9CdSV7fl51fp/SH0ZfdIcEZAIU/Z3obQcDr3dM0i0jdthQpTZqHushrZUiOBYQaa9NRRgeNt2hh/qvj8vToScZJYt2BGqaoBZ/ZHM3p8fdsfRmMQkj0df3Iw5RYKs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Rsna5Alq; arc=fail smtp.client-ip=40.107.236.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Rsna5Alq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QaZ7TwqfUTz8bUv0JVmAICkvyoBxR/LPZm+FfBuX8CbeN0pHlO//bphoDtd6G19rXRwRfM/7WkU12gDX1fHDfamJa+tRq3y/w6E9BOLQ8NkdUbQmc+8e/kauZau0nxTw9Tsvo+C8q8DZz8KE7ibMUr7zzrXfC/7zi2yoNMGKYiJRgHyc1goUbqrvOZpifYwq6bFH5H3RrV4xo8kki0zeVdPJ667nUOBDiBEnOiKJ8qWezgHR2FAxmkRx07Zrg+Z6mQT85bpqDeRJfvrKIii4tRvUClVtCLadtT/HvTtu33H2bS4gReF5Kvu2LBD5OuRLztSf8CNF/ngtgzAMRscSkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dtfJ4sC1sHvipc3AQoz4cFP5LuPWOfMwzfszFVhYRBM=; b=KXdNgLiEB5Vs7aU8XxlAPHuNHgPK+7qzTexA9DUpSw6jVmh2zVRpBpWos0PwvyJnA6Jg8uq3acc/9dENuGweGz+H1bwhtdFXOTjknWS/KwF1doMpUr5xkO3qd6tNeE2GH34f9gxuABdv27WdOYMZDIzr9pVvoPQ6KCqlsaQQUyt13oI+3+qJUdwOTaPx0uy3aM1PaWf1Zn6JllG6miibhn+JudKVm9tVhc7RT5yh6nauH49INIMfIXesqKJpBMHhOd10HapWqrwqsQgBe6mPOVt5GAWhcWSmlcK/nv8dXXB4R2FYVmFUqCuDk58oRywya/6RVycXJL2poq8QJb5nDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dtfJ4sC1sHvipc3AQoz4cFP5LuPWOfMwzfszFVhYRBM=; b=Rsna5AlqIZoK5JtfL92U2+zAypBfu4dMzzCtsHkvlF2DFv3iGoklxQ84KS9hHQi1Y+ViVKzrmDhcJvWEQZu9sjK4sv8BYwsXlc16DArsXlmctMu/i1G0piUBtvGz6lmLfFuN1/L+D+A2KFp1mo5HzK+wvxBgQLCu9woogtPFogURJchkayAvR45PO3QNqt6Bvp6TUeJMzBU7ijpuGBqeewfqLS1KkImQGjmyS/JCysk5HKgLtbENukiRoPFPwuQK/6iWPCUJt4wVqqYS9yo9BH5FciWF4iZNptym2TKr3G4t2sKzO6t4NJikaRCUkop5jfAR1YBk7SZ+BwyjQK474g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB7705.namprd12.prod.outlook.com (2603:10b6:930:84::9) by SA3PR12MB7878.namprd12.prod.outlook.com (2603:10b6:806:31e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Mon, 16 Jun 2025 11:59:06 +0000 Received: from CY8PR12MB7705.namprd12.prod.outlook.com ([fe80::4b06:5351:3db4:95f6]) by CY8PR12MB7705.namprd12.prod.outlook.com ([fe80::4b06:5351:3db4:95f6%5]) with mapi id 15.20.8835.026; Mon, 16 Jun 2025 11:59:06 +0000 From: Alistair Popple To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, Alistair Popple , gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, jgg@ziepe.ca, willy@infradead.org, david@redhat.com, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@Groves.net, m.szyprowski@samsung.com Subject: [PATCH v2 06/14] mm/huge_memory: Remove pXd_devmap usage from insert_pXd_pfn() Date: Mon, 16 Jun 2025 21:58:08 +1000 Message-ID: <67bc382c49ed8b165cfbd927886372272c35f508.1750075065.git-series.apopple@nvidia.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SYCPR01CA0008.ausprd01.prod.outlook.com (2603:10c6:10:31::20) To CY8PR12MB7705.namprd12.prod.outlook.com (2603:10b6:930:84::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB7705:EE_|SA3PR12MB7878:EE_ X-MS-Office365-Filtering-Correlation-Id: a5d11c88-504d-48b7-e429-08ddaccd3208 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?OPJ3b9tb00hydTmeZ0y/cpBCaToNNRXwgLuOZXrrQi3jRsVpH6IMiEbKjtYF?= =?us-ascii?Q?/Ep7atZAccmwgekfaiKP+z3qbCzNVopScP0LtU7O+gZOt6tc/pLiFQ3kRMEP?= =?us-ascii?Q?pXrtxkQstTMaOpw/BV6deTEgm6qNEUNanvd6+pV7/M5UT7HjoOD38y21mZHD?= =?us-ascii?Q?VjwjmgYgxh+Z4MUwT3S5HIExGkjGluw8ZqrMl8Hr9bjuRzIi03hqiU9YtP9p?= =?us-ascii?Q?T3TINWZDeCVKSdkXOVbfnox2z+fzD3HYpZlsw+L/WEjD53CJ8ppnYh6xASfi?= =?us-ascii?Q?yWjt4aE1+vv/POVKEnhI8GrH+wt1G735ilbGKCNWGGlrvRT0rK401Z30nfmL?= =?us-ascii?Q?H2tYtHlEEuYgzCiN/UgQgDm1rAJVV/eOwSOtrht1d2VFLVtOK14BDF+GpY0H?= =?us-ascii?Q?BBMTwmgeFALXXxVs6WW2WMv+xT5J33z7MbFENEbXFN4Fz+IBm10rRfPgHlIf?= =?us-ascii?Q?rTdgiH6Nvhw3ClCsd1ih9IzLgaN3LrNwzN9+OKk9/7w3UhYa8VfmugSXLWxY?= =?us-ascii?Q?Ms77SYCbyJTkdTqAs2Fm5AVjrukTP44+y/XnWgemnd7vHbUHF9+fDTPuGpMs?= =?us-ascii?Q?hcVtHFuLIvn+L83dRZpyNumAFOHBDyG6E9L+Eqi6/uA7KUEyqr4bxoEBmeeb?= =?us-ascii?Q?pSKZjMhWcZ67sTWnfplDvfSKVd7q3VCqo94vYzNcz5Ln4634fIUArzHgW0n1?= =?us-ascii?Q?E69qYIsw+t8AXVAboyPT0r4aJz1R+NY/4XvQBQdJt050Dnr86pBduc9WnMIx?= =?us-ascii?Q?o0BUDRO6LAcrHkp68Apd/Be3/TGEGTgm9fX3aWERUOvIBOy5y2kOh6dUAole?= =?us-ascii?Q?lt0RpykhzVzNcDFWj7wWU9Jt3YIS21fy7E+THRSpFjl30/Z95vVB8ZINFJYb?= =?us-ascii?Q?Qr7tkGBE384Ca98V0fL/e8UxmvZP7C9Y/iNjlj7cvCNQcd6gmBYWnzF0nB88?= =?us-ascii?Q?5qTIfyQyIsHPdBuY9B+gyw7G0fEes1cSjRhyAjDBep0i2LkCK2uTL4x0dNvW?= =?us-ascii?Q?l3qWLFk+lSyNo2rkpqIIbqL8ous4LiyPQ+R1tXPWcpgO/lCmHcvTSM/Bi1r/?= =?us-ascii?Q?joAcrFGRJyOlCkzANyaPt5uwhEAoKYxbj7cEmKX8XL+N+v15i9o4naDBRj8S?= =?us-ascii?Q?Oz4oir+DZ+AVWZl0itU3zA1rA94BC7p7PjdNPxhod+2tSXRYz1aqkOevxuC0?= =?us-ascii?Q?G28q8Q9bkIcPDIysjerj7unCcacMfXgUorHc22SfoK6lMnlEDsG0eboalxzi?= =?us-ascii?Q?PAsuRBuhIbrDzSR7yB24jQkBMIPNwLQssVXYFWzo/5Q4paHCJGhK0By5/aI6?= =?us-ascii?Q?dOaNomgYh35S+VecT2VUOaIPeN9iFskbq1q/zoxRFrx8H2cC8vX8dd+oGgfL?= =?us-ascii?Q?+i0dNzR3of7z1p/IHfFPiMHFW3Y/vHbO8eSTs856VXlGcp9iJtaP3ExrFn+T?= =?us-ascii?Q?O+gmcC9vmCE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB7705.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?igE7p3Ped9vKZljYan8Jr6njisD/99hr3AIlAAfGI+HQBw9tdY1sgbFFtMOI?= =?us-ascii?Q?uqwnt8r/7TuS+lXSgEIAx0PfHzkV89HfocrqTl7yiiH1rS9kFoYjP2KMy2pR?= =?us-ascii?Q?1vwpTq012DeNHkJq758oEr6hvnqJVwGtowjCzpWaIdIfeHMEKV1uAJrM9K/T?= =?us-ascii?Q?1A/s522/udEZ/R4C65lq9yU7tPvICQTPmgabvAixvXmM8F8UG4z2rde8bonm?= =?us-ascii?Q?esT+PyNvY29Y4ZaESr6G+bmlq7d2Z4FpakRFAaDSGZeFT2HIZo0hRdmxoRkf?= =?us-ascii?Q?IYiFdsdKsjyVfRqPknndlbFU69U+dn6R/EXsvhTcLf3soNK0Dkv9qgHA4x4f?= =?us-ascii?Q?Ih8QSqRq5KjPUuLxHc2uZRjvCUqoCNMG+ykTemXBOA4nU/XVyHWjK0RYssku?= =?us-ascii?Q?3SmBU/Od3oYFszQ9i5R2MzmRfZs9x6zQwt6q7v6Hu3Ln6Wm0sEHmwewGRee5?= =?us-ascii?Q?UEp+moUWqLNHt8bzT1dsaCA9Aq0r3YLy5+mhTrNlFx0NEljTCJIKNFB6Jj18?= =?us-ascii?Q?BzYzAG9umSNSgpvaA65gpGq0VI8PNRsudBP6kGw6VcTuYRis3yFMSuQewZPl?= =?us-ascii?Q?nSI+MTZ6c/xX0oXPbTZw7/z92NNiyCf+8cecDB31YiNYv+o2eoynSIkNnGuC?= =?us-ascii?Q?O8OUB4NgtKghuA8xLSBlkhB9i1BpgOT9QL19KA2F4LnXX2jAUCBTqeLfdLmh?= =?us-ascii?Q?wuDAdV65wX/0ND+5H6z2E0Nb6tMCw9XGafYqt3+V+NlRnLoRHjVWbe/X50js?= =?us-ascii?Q?8xgIBKmqZUNR87msSo5Nw9yN7hXCVO5uvgNf5NM2h35lbAGBXhdcxNQBIcbz?= =?us-ascii?Q?ePgkvSXKhjCHyl/cu+h2LpyXgzf4d4IHmhRPrJPkfrbnNLd6FLgJIX1Tid8q?= =?us-ascii?Q?IIh46SK2WiRMbyqVApZXASAJFBo4x55F4Q9TiQCXnIJSA8zj3pMbKim5tb32?= =?us-ascii?Q?g4uwomonJs/SH3ft+LGBo5fSYvC0qLtCv22Vbcf2VDFMp6Z/bSwtr2gDj7Qm?= =?us-ascii?Q?o4+jXHBQ9H3vk8l5zMRhqID+8zHqhCVV74ylNHNY14i9fich+hXk6Lob8xZ/?= =?us-ascii?Q?JQGBqNINq8yOvaK6MJROTW/FLAYnoA2MCfpQPH+Qd8quMsJDeqouT/SjlkCq?= =?us-ascii?Q?jGkpjB+x9WHYuBsFG+TawvMnbXh9EpA9AP8K3CvbXiN6aHeezfmy2hgQ3Q3Z?= =?us-ascii?Q?apLF0cgI0oozAIqiY9RLiXNXa632cB02dgqzAXuA7E6EbXoLRVGpc+4mLSrf?= =?us-ascii?Q?xVxv8ZJfYUvysPpizHopw1rpk2IZD8jfP5LSngcJzL+CMtWwk28wnIHb03ui?= =?us-ascii?Q?X+U/Suz2wQNHG5S3BxcZPWuGH9wKCT961ePBQj4u7b5kh2EzhjjM+GruZWMl?= =?us-ascii?Q?37X9vGJiEFko91kvUStGXA4u4i+6rFg8k2cgs/fCrXxM2xkcPbr0mF7adJMz?= =?us-ascii?Q?BJrKjVt01u4bmpW4Mjk7FfJCgPvdmP2icI5Nc//VFH4aEv1E/lsdbJtD/kB4?= =?us-ascii?Q?fyEpwI40EdaZSCl3dogdnk8UEUBXeEWLi8WfSDhtYadKEOl4vOKsDfN9A7p8?= =?us-ascii?Q?7a5UPCK/NlQu61o+U9ZbMCrYVSwvPghU7kap2Ywl?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5d11c88-504d-48b7-e429-08ddaccd3208 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB7705.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 11:59:06.6090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CWj61tfbQ/TqtM12AjFQ5nUrPMl7Sn1NxjqwIJqIf7+EM7vHN7CEABOmUyDezx3sgRpFMUplgjfXvX3FUnj/3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7878 Content-Type: text/plain; charset="utf-8" Nothing uses PFN_DEV anymore so no need to create devmap pXd's when mapping a PFN. Instead special mappings will be created which ensures vm_normal_page_pXd() will not return pages which don't have an associated page. This could change behaviour slightly on architectures where pXd_devmap() does not imply pXd_special() as the normal page checks would have fallen through to checking VM_PFNMAP/MIXEDMAP instead, which in theory at least could have returned a page. However vm_normal_page_pXd() should never have been returning pages for pXd_devmap() entries anyway, so anything relying on that would have been a bug. Signed-off-by: Alistair Popple --- Changes since v1: - New for v2 --- mm/huge_memory.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index b096240..6514e25 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1415,11 +1415,7 @@ static int insert_pmd(struct vm_area_struct *vma, un= signed long addr, add_mm_counter(mm, mm_counter_file(fop.folio), HPAGE_PMD_NR); } else { entry =3D pmd_mkhuge(pfn_t_pmd(fop.pfn, prot)); - - if (pfn_t_devmap(fop.pfn)) - entry =3D pmd_mkdevmap(entry); - else - entry =3D pmd_mkspecial(entry); + entry =3D pmd_mkspecial(entry); } if (write) { entry =3D pmd_mkyoung(pmd_mkdirty(entry)); @@ -1565,11 +1561,7 @@ static void insert_pud(struct vm_area_struct *vma, u= nsigned long addr, add_mm_counter(mm, mm_counter_file(fop.folio), HPAGE_PUD_NR); } else { entry =3D pud_mkhuge(pfn_t_pud(fop.pfn, prot)); - - if (pfn_t_devmap(fop.pfn)) - entry =3D pud_mkdevmap(entry); - else - entry =3D pud_mkspecial(entry); + entry =3D pud_mkspecial(entry); } if (write) { entry =3D pud_mkyoung(pud_mkdirty(entry)); --=20 git-series 0.9.1