From nobody Mon Dec 1 23:04:11 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A0D93101C4 for ; Sat, 29 Nov 2025 14:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427873; cv=none; b=KUpaHB8/ni/hyqNS+/0EPsGaAxP+/FDHGK8uJrbWFhScgpNS+Lm3U4yxAAbP9oTRLGBITmEPuZNBWHHDL/Vm3cVnVSzbkxSX9xs9Jm1zBZ1GtSl7HCXTLUye6ymv3g9ecrUIVdZtA1Gwlbmb0DXNl1QbFKyOPIzEMOmZP+SIh5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427873; c=relaxed/simple; bh=liK4LfPiU0pY5XDiNJ+cSHVdLUrTAgHETaseY8tBJKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o/Oq83qhm+tvNtHgnmM8y9v2j07qlkJ/Vj857llFoY3xijX8/zrM838eZ5jDHyp0rzxcOgpXM/7l/2Jyq34rc6Ch0rYm84qY92nV6n5/DKnOcHMrTuc2KFC47OpXQoXtUeK66SiJ/Y7nDdjbngHFewAA9l2LmwYhWI47TS53YjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OTp0JeTY; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OTp0JeTY" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42b31507ed8so2489069f8f.1 for ; Sat, 29 Nov 2025 06:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764427869; x=1765032669; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zkWGeeB7i8StC9hMxWOTKSpu55uDyb2ej0mWJX0OlQI=; b=OTp0JeTYcnM7wS0ZfC8saS190+0Jynbzk/rWFOrtBoOOPzuz+1fWIxOYfNiJ0j5Eaa Uq803kVZMCFUQ3w9P7SP1ApyyU2KvyYJz80Tc+cz24w9bHkOBTz4OPcqSrK6JLIV60CX ljOLeKI7CTotbb/ZqjowVUvhsm+uRPTUO9aRJTmDzEumR4UgxzRiHmCxZTjb+wGJ+Evc BXxDdCcfYgn5Y5+BNF5HM6dP5cLq7HJOwq9bbf6gDstWuetBMYUJmCd4hs5SWijY31Hl 39R67hIoGMPlOORmo9SCEaBCCjEnNvnNLYMIxxOYBcjFRlkDakuwWVyNMUlAoCt7IgKT 9vyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764427869; x=1765032669; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zkWGeeB7i8StC9hMxWOTKSpu55uDyb2ej0mWJX0OlQI=; b=Bm8Q7hkRBC9H0YG/XqDmJ8ARd7lbir83fk8u7d4t0jedDTdUE7tMnD6/xIeOsAOBHj Qe3d1OV9t3hyyj9EROaALwG1WZsGP/8HvQG52gB3cUNTHY5haS3ru2Oy/I6Y5Bk6ot4/ 1R7wQ95lU3dmkH2Km/yVrlnbtK3zqh4cPv7HJ4up9L92p38RaG7cEPqkE9GoAWA8ojZH WwI/4Fg4OB3zG0hxVLbDKmer6MwdDw94Oe2RTbnAFD+EV3Q3Z93PzuHTFLFUzyCzTyhR QGqPWv814FWfH43G3M50VdHTEm7AF1RCI7RV/j8GiMfWg3LvFGCoQZsu30RDQkgJfbkH 8kCg== X-Forwarded-Encrypted: i=1; AJvYcCWVpP9lqbkshHp/ZOH3MffY7xIjn/U7juK7KZM1QaYbUAnfLzk+/Wd/Z8hb77xG1fp4+1dnRnYJv2fgohU=@vger.kernel.org X-Gm-Message-State: AOJu0YzPuKIyAmyaNX5RtwpSEC8+W+Lnw11tNBIgWlbLANaN1g0YqpTa zJwb8kOe1TfJXhRDZiqM8Cg+mrLcpgExoC1GkDtJ6apdGFNIfkoXoehk9PB9/rqSz5E= X-Gm-Gg: ASbGncvvfk+DWVQWxYlaK9/lAf2tobJzBIqzdwSpfUq4SSNfe+NvukGzP/kS6hcS7NI 2XwyHAs0C5mphU5RKa3SuJVV63EvPJEyJh+ockeqqPjZa7IbaRVSjLq8oTbPcURw1HXVsCbsIW+ BxUjzofrjqW7ZGX5MnD0JXPlF9yQq1AES5WCBVNdRX2nNl0YD6YxiRhRuLF18HBS66dMYnJImNa thx3SThAwRutRnJ5+ksWRy38lSzmVo73IOm1BMp/7RBqBPV+diBt5/lIlQvPwPjgihqhHg1F95P dp/A3bPs0mU5+EBRlA79c4rq9P0YgPhyHrtSjQmWUn2rrxCp32ilrWBUNBdy0lUkcWsfEuEP299 FTD4ke0OZ2bdOzUiYKWVB2Rb5HHW6izxAqsr+m+GwhmJGNdVu0FLjgXyQ2qHtlTtPn5gTMcbbvp L1SxanHoBbhuUjfmTA X-Google-Smtp-Source: AGHT+IHtQkQGQCuMCo6bY3Ja5uUySeD4yPVpGdxPG7jpQTsa5cwSzFut7/w/KfuwVM8RFg93hJTJ6A== X-Received: by 2002:a05:6000:3106:b0:429:cda2:9ffe with SMTP id ffacd0b85a97d-42e0f1fb97amr21174292f8f.7.1764427869395; Sat, 29 Nov 2025 06:51:09 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1ca1a38bsm16309890f8f.24.2025.11.29.06.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 06:51:08 -0800 (PST) Date: Sat, 29 Nov 2025 17:51:05 +0300 From: Dan Carpenter To: Rob Herring Cc: Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] remoteproc: qcom: q6v5: Fix NULL vs IS_ERR() bug in q6v5_alloc_memory_region() Message-ID: <674b32a78563282adeaf3cdf941314a0b8181026.1764427595.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the checking to match. Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functi= ons for "memory-region"") Signed-off-by: Dan Carpenter --- drivers/remoteproc/qcom_q6v5_wcss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_= q6v5_wcss.c index ca748e3bcc7f..d96af0e0f665 100644 --- a/drivers/remoteproc/qcom_q6v5_wcss.c +++ b/drivers/remoteproc/qcom_q6v5_wcss.c @@ -887,9 +887,9 @@ static int q6v5_alloc_memory_region(struct q6v5_wcss *w= css) wcss->mem_reloc =3D res.start; wcss->mem_size =3D resource_size(&res); wcss->mem_region =3D devm_ioremap_resource_wc(dev, &res); - if (!wcss->mem_region) { + if (IS_ERR(wcss->mem_region)) { dev_err(dev, "unable to map memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(wcss->mem_region); } =20 return 0; --=20 2.51.0