From nobody Wed Feb 11 05:13:58 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CFF831159C for ; Mon, 9 Feb 2026 22:14:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770675303; cv=none; b=cKq8cE10auTk39P28BqIroYK6gw+bUZ9Memy5yCq2Hg0gwAyFjSj0YMZ4Lbp1CIHFL7Do30KNe8JX+R0U907fk+g0LxNLRXjGZ8uyn6MchhXNA23SMDEv5YDrfIBRoh/jvGxiLcYUc41V/KZ2dN86IY1Rs54s/q33vKJnTpC5Mo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770675303; c=relaxed/simple; bh=xFm3Mvuiaek3TQObiEg+n/ibmgn1WObQdw7k5y1quJ0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=boo94S177NuloHZQWeFAgH7H027IXD3KTxztkSCjVirJtMJfD+ARjUMDDP5OIyz9ZfTtbl8Vpg3TU0XBltw9/y7FzcnG97jRDWxAivQgzoAtuOkYcYDyhoBQ51pvD3zkrGeBRukD7eiBZT6pvwA8pXKNgcUOcmCN1VF/NqhDNdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GhHud+P1; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GhHud+P1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770675298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zhOcvH5cMErbpuFO1qD4X5xOtlaPVDROEke9rfA1j/w=; b=GhHud+P1+wv2hLrqgeis51PzPOC0kLyaOTEDBA000OsAUK+zgX0nY6yRw8tVvDOhD8ZBUB 1y5P6LTz6/CzOq03K+jvmbi3w0oVTAhROzE0C5O1S3sKOnygfoJb0TSURe2PDrvKwTEqD7 T54Ha/+cJINmBTo7Jj5e4hkkEFK8ilQ= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-445--ENewiPxMw6ecghvTqURYA-1; Mon, 09 Feb 2026 17:14:57 -0500 X-MC-Unique: -ENewiPxMw6ecghvTqURYA-1 X-Mimecast-MFC-AGG-ID: -ENewiPxMw6ecghvTqURYA_1770675295 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C93D71800465; Mon, 9 Feb 2026 22:14:55 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.65.66]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B554918003F6; Mon, 9 Feb 2026 22:14:54 +0000 (UTC) From: Luiz Capitulino To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, david@kernel.org, baolin.wang@linux.alibaba.com Cc: ryan.roberts@arm.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com Subject: [PATCH v2 07/11] mm: shmem: drop has_transparent_hugepage() usage Date: Mon, 9 Feb 2026 17:14:29 -0500 Message-ID: <66846ee3aec32c04d20bc7e0e823ba21d4ef278c.1770675272.git.luizcap@redhat.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" Shmem performs two kinds of has_transparent_hugepage() usage: 1. shmem_parse_one() and shmem_init(): since the calls to has_transparent_hugepage() are protected by #ifdef CONFIG_TRANSPARENT_HUGEPAGE, this actually checks if the CPU supports PMD-sized pages. This is irrelevant for shmem as it supports mTHP 2. shmem_parse_huge(): This is checking if THP is enabled and on architectures that implement has_transparent_hugepage(), this also checks if the CPU supports PMD-sized pages While it's necessary to check if CONFIG_TRANSPARENT_HUGEPAGE is enabled, shmem can determine mTHP size support at folio allocation time. Therefore, drop has_transparent_hugepage() usage while keeping the CONFIG_TRANSPARENT_HUGEPAGE checks. Signed-off-by: Luiz Capitulino Reviewed-by: Baolin Wang --- mm/shmem.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 79af5f9f8b90..32529586cd78 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -689,7 +689,7 @@ static int shmem_parse_huge(const char *str) else return -EINVAL; =20 - if (!has_transparent_hugepage() && + if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && huge !=3D SHMEM_HUGE_NEVER && huge !=3D SHMEM_HUGE_DENY) return -EINVAL; =20 @@ -4678,8 +4678,7 @@ static int shmem_parse_one(struct fs_context *fc, str= uct fs_parameter *param) case Opt_huge: ctx->huge =3D result.uint_32; if (ctx->huge !=3D SHMEM_HUGE_NEVER && - !(IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && - has_transparent_hugepage())) + !IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) goto unsupported_parameter; ctx->seen |=3D SHMEM_SEEN_HUGE; break; @@ -5463,7 +5462,7 @@ void __init shmem_init(void) #endif =20 #ifdef CONFIG_TRANSPARENT_HUGEPAGE - if (has_transparent_hugepage() && shmem_huge > SHMEM_HUGE_DENY) + if (shmem_huge > SHMEM_HUGE_DENY) SHMEM_SB(shm_mnt->mnt_sb)->huge =3D shmem_huge; else shmem_huge =3D SHMEM_HUGE_NEVER; /* just in case it was patched */ --=20 2.53.0