From nobody Thu Apr 2 12:14:53 2026 Received: from canpmsgout01.his.huawei.com (canpmsgout01.his.huawei.com [113.46.200.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACCB6280A20; Mon, 30 Mar 2026 01:03:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.216 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774832632; cv=none; b=Bb42xCKVqjxyCz/2eSvWApcscUxJw2vwgVt5xSQ8MWNlMd1uqqCeQ5+PbrV9wBQsfEFM6K+mV1T1EB458qc7XgQBv9Zy9Nl7FsmpvvKCHBtEyD/mdP3tgTtz3H3KltaCiAOKnLNboFG0mHWzeoL9aGGVxlIHBAh0C8cqGlPlVJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774832632; c=relaxed/simple; bh=WHtFJ2WfWzNoEFlaOGsliw2COgU7dl5m738goI0pwRo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YfBad9m9oMUB0nVgWFmzwbjrUCEzxgi8PkybRRzuZwYzcl+gxAcqKiF27Asp4CmgPQsxz8QP4pjrIrTfCGaUsPQwRK1yfrgYrbXHbEO+GhjSRk0OD/FrBZCrQJGL0YhPnezxStoqnve6riaCXRLz/r+JMsmCS36lmppwYV0f9kM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=k3C6yJOQ; arc=none smtp.client-ip=113.46.200.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="k3C6yJOQ" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=YwfSrPCHCl+uJGc2fx+OVzAn8fZBKv6wc0veh7li0Cg=; b=k3C6yJOQ9VUKOOdtt9pjSre9qLUx5WA2B/nNGS8YRgzSVjNwhvXTTErqf7PMuKdpfoVOflzrU VgfT28SICU+fG+ri/sqLahCbfnUM9tPU1F5eh63tkS6I6WG5EFUowRqsSQWFWzXiCx013f/go61 /TYBtCOMFZb3Z0YVxCk3UQ8= Received: from mail.maildlp.com (unknown [172.19.162.144]) by canpmsgout01.his.huawei.com (SkyGuard) with ESMTPS id 4fkXt24WFSz1T4Hs; Mon, 30 Mar 2026 08:58:02 +0800 (CST) Received: from kwepemf100013.china.huawei.com (unknown [7.202.181.12]) by mail.maildlp.com (Postfix) with ESMTPS id 3AE424056E; Mon, 30 Mar 2026 09:03:40 +0800 (CST) Received: from DESKTOP-62GVMTR.china.huawei.com (10.174.189.124) by kwepemf100013.china.huawei.com (7.202.181.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Mon, 30 Mar 2026 09:03:38 +0800 From: Fan Gong To: Fan Gong , Zhu Yikai , , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , Ioana Ciornei CC: , , luosifu , Xin Guo , Zhou Shuai , Wu Like , Shi Jing , Zheng Jiezhen , Maxime Chevallier Subject: [PATCH net-next v02 6/6] hinic3: Remove unneed coalesce parameters Date: Mon, 30 Mar 2026 09:03:23 +0800 Message-ID: <651938818c0401ce51b8fae3e3129fe25842d1dc.1774684571.git.zhuyikai1@h-partners.com> X-Mailer: git-send-email 2.51.0.windows.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemf100013.china.huawei.com (7.202.181.12) Content-Type: text/plain; charset="utf-8" Remove unneed coalesce parameters in irq handling. Co-developed-by: Zhu Yikai Signed-off-by: Zhu Yikai Signed-off-by: Fan Gong --- drivers/net/ethernet/huawei/hinic3/hinic3_irq.c | 6 +----- drivers/net/ethernet/huawei/hinic3/hinic3_rx.h | 3 --- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c b/drivers/net/= ethernet/huawei/hinic3/hinic3_irq.c index d3b3927b5408..42464c007174 100644 --- a/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c @@ -156,13 +156,9 @@ static int hinic3_set_interrupt_moder(struct net_devic= e *netdev, u16 q_id, spin_unlock_irqrestore(&nic_dev->channel_res_lock, flags); =20 err =3D hinic3_set_interrupt_cfg(nic_dev->hwdev, info); - if (err) { + if (err) netdev_err(netdev, "Failed to modify moderation for Queue: %u\n", q_id); - } else { - nic_dev->rxqs[q_id].last_coalesc_timer_cfg =3D coalesc_timer_cfg; - nic_dev->rxqs[q_id].last_pending_limit =3D pending_limit; - } =20 return err; } diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.h b/drivers/net/e= thernet/huawei/hinic3/hinic3_rx.h index cd2dcaab6cf7..a64a51d766c5 100644 --- a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.h +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.h @@ -112,9 +112,6 @@ struct hinic3_rxq { dma_addr_t cqe_start_paddr; =20 struct dim dim; - - u8 last_coalesc_timer_cfg; - u8 last_pending_limit; } ____cacheline_aligned; =20 struct hinic3_dyna_rxq_res { --=20 2.43.0