From nobody Wed Dec 17 00:17:37 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 773C9C4167B for ; Fri, 8 Dec 2023 16:09:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233632AbjLHQJb (ORCPT ); Fri, 8 Dec 2023 11:09:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233712AbjLHQJO (ORCPT ); Fri, 8 Dec 2023 11:09:14 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 729D2198C for ; Fri, 8 Dec 2023 08:09:20 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPe-00008A-Et; Fri, 08 Dec 2023 17:09:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPd-00ES0V-7c; Fri, 08 Dec 2023 17:09:13 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPc-00GUaW-Ug; Fri, 08 Dec 2023 17:09:12 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: Viresh Kumar , Lee Jones , Linus Walleij , Arnd Bergmann , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 6/7] pcmcia: sa1100: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:11 +0100 Message-ID: <6473afe67fc5c320a8184d0871a8561f7685e265.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1892; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=soQnZWwWX5NPDCGNgya11PcjXTdqO51zNv14LXCtkeM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz96dq8FIqBF+9nhRULOPdYII0+SJ2lmN0qx4 vOsf7RMtN2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/egAKCRCPgPtYfRL+ TsaZCACGrDJbeg57n+TS5zDu2iOt3i8CZPfzAc6KKsn7mM7PtesUBYd47RUUdVFme+9wLJBlq2h z/ybFAM6vFgwnMuArx9SE8DJH712b+aLSnOlmlmCABTBjK3JssgIwT0+0/7DYyntyCS7NOUl0t4 FTwFReArCVrjsTf0R8RewDs5ntQKD4Dy4GtjPecVCcrb9wdONxaJ2D+ui8ioy0Qh/Ixpcl2Ptus Vdgv9EXACyiFSaCmuqcjl3mwb2JgW2FsbWRcTru3TziMRAS/rM3VjTCdVv9L2Z4JdnzhCBRJKd5 PkHLWFxTBCprnaj/y6kcBAA4cyg2MeD/niAksyFzW9Ts9YqS X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/pcmcia/sa1100_generic.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/pcmcia/sa1100_generic.c b/drivers/pcmcia/sa1100_generi= c.c index 89d4ba58c891..ccb219c38761 100644 --- a/drivers/pcmcia/sa1100_generic.c +++ b/drivers/pcmcia/sa1100_generic.c @@ -158,20 +158,18 @@ static int sa11x0_drv_pcmcia_probe(struct platform_de= vice *pdev) return sa11xx_drv_pcmcia_add_one(skt); } =20 -static int sa11x0_drv_pcmcia_remove(struct platform_device *dev) +static void sa11x0_drv_pcmcia_remove(struct platform_device *dev) { struct soc_pcmcia_socket *skt; =20 if (dev->id =3D=3D -1) { sa11x0_drv_pcmcia_legacy_remove(dev); - return 0; + return; } =20 skt =3D platform_get_drvdata(dev); =20 soc_pcmcia_remove_one(skt); - - return 0; } =20 static struct platform_driver sa11x0_pcmcia_driver =3D { @@ -179,7 +177,7 @@ static struct platform_driver sa11x0_pcmcia_driver =3D { .name =3D "sa11x0-pcmcia", }, .probe =3D sa11x0_drv_pcmcia_probe, - .remove =3D sa11x0_drv_pcmcia_remove, + .remove_new =3D sa11x0_drv_pcmcia_remove, }; =20 /* sa11x0_pcmcia_init() --=20 2.42.0