From nobody Fri Dec 19 10:00:15 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CA8B2D7D2F; Tue, 9 Dec 2025 14:01:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765288875; cv=none; b=kzGfa2rNW8amz6dqd4yEDNk/qHFDcizePIDEGj2obJ7hdJuxePKhTyKnRpkeJWXRZYqCdc/CNhDFV5kzE86Hwir9Hn1RyZ/VdWPF9fSooWUIwd95i6SwcGNrDmf3UwBSh4tQGjaYo6bYQyaxXpMknfVb6+7o52lJXydaOxgIvMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765288875; c=relaxed/simple; bh=cA1k0ZgxLBdb4xdZVxc9tFf/9+gu4EaouVVW56rw7Wc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AyYSMW/TVtqfmMeVxCRV8b4G39u4EnRPhd58hoAJDg3R8WAw9pGwhyejJ8ZDunQJCntr3ShotdI4PlSJHldAkmHQv+cnL9wirC/O7gUm4Lbm3/X9n+89vx3S6qrtWRRe+F6GLBBQ6lsvraS9geCdn8ezHIPD3wOQ5+ooFG3qte4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HeL75Qal; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HeL75Qal" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3979C4CEF5; Tue, 9 Dec 2025 14:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765288874; bh=cA1k0ZgxLBdb4xdZVxc9tFf/9+gu4EaouVVW56rw7Wc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HeL75QalhHQahfGEACBqrAKe6kLoRPEkbuwYCjnEeZqDhsvb3h5LL5nLWsbPLT3s5 g9qQz/832Amj4QKWSkeXiYLgHhhUjpIKZmozkgq8XTdHC0ZFgM7RIB4hnYCS7Qwl8n Kh328K5b0qD3Ckt5tALAqKKbGB1c75icTeHCGsGtv96J64kxaYXlNIaUwEqiaow/4a j1kME37Mfd+FlgRT+U9PmuWzzBFNTQdEVhczxVsopafrecKAFCF3nY381S6sFo7uzJ PQIKsotCINGbWHOgF6sn8GMP06hjHyHK2iJRgs7p+UTCgqaeto0NmyRaXP5aozsST5 fRCiIDOmqU6Lw== From: "Rafael J. Wysocki" To: Linux ACPI Cc: Hans de Goede , LKML , Linux PM , Thomas =?ISO-8859-1?Q?Wei=DFschuh?= , Armin Wolf Subject: [PATCH v1 02/10] ACPI: scan: Reduce code duplication related to fixed event devices Date: Tue, 09 Dec 2025 14:53:09 +0100 Message-ID: <6119210.MhkbZ0Pkbq@rafael.j.wysocki> Organization: Linux Kernel Development In-Reply-To: <2339822.iZASKD2KPV@rafael.j.wysocki> References: <2339822.iZASKD2KPV@rafael.j.wysocki> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Rafael J. Wysocki Move duplicate fixed event device registration code from acpi_bus_scan_fixed() into a new function called acpi_bus_add_fixed_device_object() and make acpi_bus_scan_fixed() invoke that function as needed. No intentional functional impact. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/scan.c | 42 +++++++++++++++++------------------------- 1 file changed, 17 insertions(+), 25 deletions(-) --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -2647,37 +2647,29 @@ int acpi_bus_register_early_device(int t } EXPORT_SYMBOL_GPL(acpi_bus_register_early_device); =20 -static void acpi_bus_scan_fixed(void) +static void acpi_bus_add_fixed_device_object(enum acpi_bus_device_type typ= e) { - if (!(acpi_gbl_FADT.flags & ACPI_FADT_POWER_BUTTON)) { - struct acpi_device *adev =3D NULL; + struct acpi_device *adev =3D NULL; =20 - acpi_add_single_object(&adev, NULL, ACPI_BUS_TYPE_POWER_BUTTON, - false); - if (adev) { - adev->flags.match_driver =3D true; - if (device_attach(&adev->dev) >=3D 0) - device_init_wakeup(&adev->dev, true); - else - dev_dbg(&adev->dev, "No driver\n"); + acpi_add_single_object(&adev, NULL, type, false); + if (adev) { + adev->flags.match_driver =3D true; + if (device_attach(&adev->dev) >=3D 0) + device_init_wakeup(&adev->dev, true); + else + dev_dbg(&adev->dev, "No driver\n"); =20 - acpi_default_enumeration(adev); - } + acpi_default_enumeration(adev); } +} =20 - if (!(acpi_gbl_FADT.flags & ACPI_FADT_SLEEP_BUTTON)) { - struct acpi_device *adev =3D NULL; - - acpi_add_single_object(&adev, NULL, ACPI_BUS_TYPE_SLEEP_BUTTON, - false); - if (adev) { - adev->flags.match_driver =3D true; - if (device_attach(&adev->dev) < 0) - dev_dbg(&adev->dev, "No driver\n"); +static void acpi_bus_scan_fixed(void) +{ + if (!(acpi_gbl_FADT.flags & ACPI_FADT_POWER_BUTTON)) + acpi_bus_add_fixed_device_object(ACPI_BUS_TYPE_POWER_BUTTON); =20 - acpi_default_enumeration(adev); - } - } + if (!(acpi_gbl_FADT.flags & ACPI_FADT_SLEEP_BUTTON)) + acpi_bus_add_fixed_device_object(ACPI_BUS_TYPE_SLEEP_BUTTON); } =20 static void __init acpi_get_spcr_uart_addr(void)