From nobody Mon Apr 6 09:12:34 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A702DE6FF for ; Sat, 21 Mar 2026 10:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774088033; cv=none; b=lsnJgG8IXqJy4IYuzUv2xC9rEPwg1QGXW9+mG5APp5fXAFKaCoqtqZXjQg4wt7E3px7K1P4nqHtkeBarKAnmutrb6cH0Ul5FxjiAaiKA094J7N+I100a+G8PJr/VroP8NWec1eXDGMINGAbuf1ZKmHu8iFcy05chiToTUEe/0lw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774088033; c=relaxed/simple; bh=9TT6fPPrCVPWyWOTkQtvqNji+N8nh0GAaHIQ5G61F/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dvNeGmAtCC3iHKZmfj8iJIl81lFdDPswFazJFEINOpTuMR8h3li6vRdO1DfnJGCrqUAHztOut8Ldqk5/GjKTqhNbvTRLglopvq1IBN2Bay2Ncgkg5cAMTARTIMniEgNPzgzk9hJLAc8WJBmWyCmOvgtED7wApv85AHnzJ8PoXkY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=j1xOTkMz; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j1xOTkMz" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-486b9675d36so20598635e9.0 for ; Sat, 21 Mar 2026 03:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774088031; x=1774692831; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5nvE2qXP7SXrFq3OejPF5HK1aF/+SsVNdOeY2ld3e5k=; b=j1xOTkMzdobbHtAYCpJ1yICxLtvfy4yrGWBvdKF5KUhsjwvMQeCrXTrTjM4JXCWJdI SEHzXxPR89YsmeP1yBeuR9eLRHkiPVJd2HdG93JAaWv8PE6hCEc877mwEFoDKwJEYpjn 6arMh81gx9bFxw/wr3V46mMeWdh6cSFcJosDAWjVm1Mr5MaGB2uS0GNTXfx8uNGrrMVl zMc+2r3WG8Vt9gI3SLiW0w8S9AKleqTMC14f/8MVpdVQ+b6mWDyXHLhI3xkN9slMKQOE VvoYj5x2Jdox2vTq1liHvZ9HxdJVPibb7i46vhZ0ZyyoBck8L1uUKdZZWPd83JG2wdvX +pBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774088031; x=1774692831; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5nvE2qXP7SXrFq3OejPF5HK1aF/+SsVNdOeY2ld3e5k=; b=UtnCPYp49hNhzbnwoucO7IGlxZAD3LpjE7d7EzkeMp1jLAMdqwlskFKxvJqbZWwZuN o7iGX+MmTXcZpbpM8wrAHlzUc6Z5vV+mNYtJmO91NRDRogXkYtT13MA12luae9naJ6F+ QXWmjnldDh9elyqcFMQDdYcn6FHDN+nVPlfFOXAa7vHbb6uwbTS8RONQHaOfTXrYIIWw FTeYhhX1RUEywPIJZpoLmBe2qcn0aOjoHdH59H8Oh/08klxp+q1eC2vqHRj2H5F8B07Q Pew0cLENuguQD9KAfVj3Fpcx/ZldKFCKWfcJobx/3e31fjNQRI6/P3EXSwrSqRMC5+9W 8bGw== X-Forwarded-Encrypted: i=1; AJvYcCVBWQ0iCR5HgRcVWelWiAjhE1XEnt2FI7z//khRVI4DvR/IZGC4bxbGai9P78fElyL9NaVd27My6sX9gpk=@vger.kernel.org X-Gm-Message-State: AOJu0YxPCRB0kfmx0wmMyc1kJxmyVshAXVTc4qU5CkseS4f0E3bv7et3 L9u2qn5xMF7SGZEZY2ga8YH/17UMnLkRqZZsuQOsgAFgQYD4/DHRBXN9pvFz3XJHWX4= X-Gm-Gg: ATEYQzxTunACuX+2OTB+ySfjLfZq4Y2W6PcEj5TTvmeJCt+s2/Q6K+mk3i+KYiDOAF4 dJov2O5cFdnN08ckvG/hQj3PcDKkREyyt2r0UJOurY0tWkFKtHMhhvu6crZmoTxwSKs/10C/ogg o9BfIlHiZBprqZEeRkFLnKtP6aWt2DuJvBFEr2NVX/64RiGpST1ICyKqZXpW1VYA7Z0KVP6t67e 6PreHY2nEuApzjcSJgkK9EIP3+uVb+CVDd7ZAJHM5cLutvk+x8Q7fyHkQ88kEp9rqCIdJ9CVPSG kyOJu/pXrDU2IdTPSRKkoZMW04ZVqhhJ3dDqXToCFdd5zndifeUY6IzJmnVz+2sMANiAsW3vVY5 Oe4NZYPYtsCgWklyuVsBqzA3wlf1EYDVs5iS3Rp1jODLl0URXj+zskE2o1cesvMoFja7xW5CkLI 7fxxXQ6h88dcbAbN8ic94THBk5sxSY X-Received: by 2002:a05:600c:4e8e:b0:483:c35d:3659 with SMTP id 5b1f17b1804b1-486fee04a48mr82485135e9.18.1774088030748; Sat, 21 Mar 2026 03:13:50 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe8159dcsm47760825e9.0.2026.03.21.03.13.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 03:13:50 -0700 (PDT) Date: Sat, 21 Mar 2026 13:13:47 +0300 From: Dan Carpenter To: Sudeep Holla , AKASHI Takahiro Cc: Cristian Marussi , Linus Walleij , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Bartosz Golaszewski , Vincent Guittot , Khaled Ali Ahmed , Michal Simek Subject: [PATCH v5 4/7] pinctrl: scmi: ignore PIN_CONFIG_PERSIST_STATE Message-ID: <6087ce1233834f554de6f1941ff5bc85ffa059a0.1774087290.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The PIN_CONFIG_PERSIST_STATE setting ensures that the pin state persists across a sleep or controller reset. The SCMI spec does not have an equivalent command to this so just ignore it. Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij --- v5: fix subsystem prefix v4: Add r-b tags v3: No change drivers/pinctrl/pinctrl-scmi.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index de8c113bc61d..f22be6b7b82a 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -361,7 +361,7 @@ static int pinctrl_scmi_pinconf_set(struct pinctrl_dev = *pctldev, unsigned long *configs, unsigned int num_configs) { - int i, ret; + int i, cnt, ret; struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; u32 config_value[SCMI_NUM_CONFIGS]; @@ -377,17 +377,21 @@ static int pinctrl_scmi_pinconf_set(struct pinctrl_de= v *pctldev, if (ret) return ret; =20 + cnt =3D 0; for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); + if (param =3D=3D PIN_CONFIG_PERSIST_STATE) + continue; + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[cnt]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; } - p_config_value[i] =3D pinconf_to_config_argument(configs[i]); + p_config_value[cnt] =3D pinconf_to_config_argument(configs[i]); + cnt++; } =20 - ret =3D pinctrl_ops->settings_conf(pmx->ph, pin, PIN_TYPE, num_configs, + ret =3D pinctrl_ops->settings_conf(pmx->ph, pin, PIN_TYPE, cnt, p_config_type, p_config_value); if (ret) dev_err(pmx->dev, "Error parsing config %d\n", ret); --=20 2.51.0