From nobody Fri Dec 19 20:00:21 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 754742E3390 for ; Mon, 31 Mar 2025 09:45:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743414317; cv=none; b=mxatLeLEkZ/pmfsmErGATCTIEj5YJaxl6FWaY/WO88+ifVM7vPPvATbRgD01wfeQpNXabCCvO8UGxCsUx2iin2x8txn3y/Wt3azeumeWCbk2LGEwKvopUrxWC3ItaeEueR1rFuC+0rk92EmGKJeCeU7ETtTfFLmxD9Qe6ZPBvtY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743414317; c=relaxed/simple; bh=eb5lElBQ52SQo2tJMBhxvP50tBy4RgLuAmk+7/7KVYM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=ckU5W6OTaVAev1GoUuIG/JKhrOnDjIfvvyOw8a3fnXzYO4W8jJrY8MUfrlUA0Md9BUBNiJt1el0KjjkT7sHXZ0CVq5B64WoZJbJ73jYWIL72265TXoy6wH6HUtQZubVGYjKwG83FunYd64EpisTE5d2YcUCD8e6QA62ud91Kli0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fK12p+UV; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fK12p+UV" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43cfb6e9031so39176265e9.0 for ; Mon, 31 Mar 2025 02:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743414314; x=1744019114; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=aKS0Fboa1dtHIDG4S6gLCYTAz2lAP8mKMrYFIOMeSw4=; b=fK12p+UVwSTQk21hUWwQ9pWJpdybFLDovx4h8HgAAxGbV+KYv9uxvopVmmCjmWBUVk ZG+Xb1Lqq69CWNWo5Fg7fHTp5bpncmAaHIrFwVYNyBsJ/hCMjtwttSSbsGz9lUbr/HyD SXsvKe9xyLV7xVnyHZCBf0adqBzerEVTw2et0MxOWev4YnttYGifmg3Ysb8w8K+l7h2q 9WV2g7Xoz6Sz6s+YWTpV9ofJfjiEWcAow/fRwiiBLgj8XwYkDj9NZvZpfHHFtjqRFt6U RMs0U/+gYNASifZF/IyEMkVV9OwWAAWwd/2r05A3kBDIQTGlSCe8GohO83BsI7l37stE SqFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743414314; x=1744019114; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aKS0Fboa1dtHIDG4S6gLCYTAz2lAP8mKMrYFIOMeSw4=; b=dBKMRqPLutIRZ9R81WfKQL7MHNIl718TJ8UNx4NxDAofPV0fI3Wg3f4FCcSGGBXWe2 0XRN7VxUHnrBXH0Am+yoJSNyOrs++pN+GveMU68Sxz9Ij2Pia2Wy3Ta70O5uTFwBJSUf 7rvhKiUlAssevmarxYhMq1cJfAzoGYItfgbgSc82D5hry0Pn4OFpri52WzFdaRUqL/Bx +y2YnGt8yTXIRMrzLgJWLtKttlywZb4Js/hgPERMGfY5WLTmTEa+DxwsSuqWQt3xTczy piY2l+lqYUAwytYG+HruLlIHd0ClHDmVHa49ho76f3hY55ZlZFhbxoNUAF8EAaVzmqmG hiAA== X-Forwarded-Encrypted: i=1; AJvYcCW1xUYFTth0Dkp/76rNnltnviP/d8qat+rw8YcvCjZubFpx9tVtUbqOoC0F4Qhe+jYg5x93xP16aiYjKdY=@vger.kernel.org X-Gm-Message-State: AOJu0YwGSH0fS7wIs1jKGdM7oqZnKAgCaq55ENeJsBOgxN4R7qq0aX6b rQaUhpI+nXK7eUHwkY44JJO6CSGrXy+iCAWMrR0zJ9VkADIs394fEamNY1u4cxw= X-Gm-Gg: ASbGncu+OgFaOpCU2aMQgJ31XaEoeFH6k5IYytAdkn6rVFIPZXAwbpbzVca0PuNP8/+ 1hOOagjliw72VR9DSANaoISBiJzyMPIwccPFD+DSbvfzGxl0oitToYCKA/KIQQaKGPDByxHVwUN kNZBfzm1AWX480KnSSK9vSnRzu0kICEXbadR5cY6tHBQh9Bea6oSiUkpv/NIKrhneIrZqrH/+LO z9nd267zgM/HpIDCYMqJ2ScV0kEv6LpHmJzI+pauLaRPjaDKQtC5r19lXExzjppSeE+Ar/749x5 VD5siw/XTd8G0dBMOuSlTpPgXHsPGlv9d0PQMMe+zW/NdJ1Xng== X-Google-Smtp-Source: AGHT+IFVzFpYmKBAGEXWi3zw7wUU5N+0+BO4pZCgxv4I35ZkC0wJP7yiqMMStfAjpc9DsFCTgkEtog== X-Received: by 2002:a05:600c:83c4:b0:43c:ec28:d31b with SMTP id 5b1f17b1804b1-43db62283d1mr102074565e9.10.1743414313954; Mon, 31 Mar 2025 02:45:13 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43d8fbc10e1sm115778485e9.12.2025.03.31.02.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 02:45:13 -0700 (PDT) Date: Mon, 31 Mar 2025 12:45:11 +0300 From: Dan Carpenter To: Rob Clark Cc: Sumit Semwal , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , Dmitry Baryshkov , Pekka Paalanen , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] dma-buf/sw_sync: Decrement refcount on error in sw_sync_ioctl_get_deadline() Message-ID: <5dbd6105-3acf-47ad-84d6-2920171916ac@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Call dma_fence_put(fence) before returning an error on this error path. Fixes: 70e67aaec2f4 ("dma-buf/sw_sync: Add fence deadline support") Signed-off-by: Dan Carpenter --- drivers/dma-buf/sw_sync.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/sw_sync.c b/drivers/dma-buf/sw_sync.c index f5905d67dedb..b7615c5c6cac 100644 --- a/drivers/dma-buf/sw_sync.c +++ b/drivers/dma-buf/sw_sync.c @@ -438,8 +438,10 @@ static int sw_sync_ioctl_get_deadline(struct sync_time= line *obj, unsigned long a return -EINVAL; =20 pt =3D dma_fence_to_sync_pt(fence); - if (!pt) + if (!pt) { + dma_fence_put(fence); return -EINVAL; + } =20 spin_lock_irqsave(fence->lock, flags); if (test_bit(SW_SYNC_HAS_DEADLINE_BIT, &fence->flags)) { --=20 2.47.2