From nobody Fri Dec 26 11:20:09 2025 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEA812D612 for ; Fri, 5 Jan 2024 12:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xneem7OM" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a275b3a1167so179652866b.3 for ; Fri, 05 Jan 2024 04:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704457239; x=1705062039; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=VPgoGs4JCmFCXEz83XMMwyrfsqP4QMFdJVq1Hj+FDjY=; b=xneem7OMkoDf3atnrKXSeY3V1gjCPnM7C6WMYvHrjIkLcJ/zxaBjSeiaFyGIrg7w78 RLry8F4sQXDfg/Tjso7fY43ILc0h/UYoqsCHascN37sU8kUDh2f/GeZ9Tk1BrKR0s4uf IYbwKdXMb7IzNtDc1mGnUZEUMtri/UheOyWuG7vUMIXmMFb4U9we1VmOt2M+y6Y7HmuU PTP+YjobJEpP85sZCr0Lgji76UAihWb5ntRa4MAZ8jqEIiBpBtWXghC0B8nlNbjiFJx9 zJoz942agkVdMpt0tvTeFQ+EuyT+WEbti1fdRM+kAtEsRL319TbG8678RJ7S7wOJ9njs VPTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704457239; x=1705062039; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VPgoGs4JCmFCXEz83XMMwyrfsqP4QMFdJVq1Hj+FDjY=; b=dGy3CwGjyNRTCqZF2RBBR+aGA6dT+7pzn2KNfeF1G4pw7xKE5T+XNo4ETwDvyliIYL gUC+RzcuNMQ/2dAQdK8EqaaGuVR+VxXYboqFNAGSQmLnU4CiObBQqecXzcV4qeCgOlqI ECA9Ax0xjyaIHpeWePv0eIKGiMdkPodWQJrXY+OtV6Ye8+jSRD8OtTJcaN1Igm5wqsuY 5q6a/wJMDEwCudGd4qP9N7cpo29cCzRLXXap80t4zwzKTj3NNcIpHGapWwzuMS3VtiVv qt59DynCuu4QYxAx2oANseGnyaYfNpkmAQe++gaNxV37Y6IPZ6xADLUPj6ArteSj87Cz Zrdg== X-Gm-Message-State: AOJu0YyFrwGp/5730ktoEnaQPNUdA75Ec6ZCaqyjjDvEVdoQXhC3MfPv ZHyff9VPWTSNEIgnBu1Rrah9vk8bwmUWeQ== X-Google-Smtp-Source: AGHT+IGTi4ByJkUR6/L3sBCprInPncsNYvpNn81WSpgeD5kLCGkvWCFb+4d+d6d898+eLssOzT1V0A== X-Received: by 2002:a17:906:51c1:b0:a28:fa55:3597 with SMTP id v1-20020a17090651c100b00a28fa553597mr923237ejk.98.1704457239116; Fri, 05 Jan 2024 04:20:39 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id r3-20020a170906704300b00a27e4d34455sm820240ejj.183.2024.01.05.04.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 04:20:38 -0800 (PST) Date: Fri, 5 Jan 2024 15:20:35 +0300 From: Dan Carpenter To: Himal Prasad Ghimiray Cc: Lucas De Marchi , Oded Gabbay , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rodrigo Vivi , Matthew Auld , Nirmoy Das , Matt Roper , Matthew Brost , Pallavi Mishra , intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/xe/selftests: Fix an error pointer dereference bug Message-ID: <5c0db456-2d8a-485f-875d-6408386fcaa5@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Check if "bo" is an error pointer before calling xe_bo_lock() on it. Fixes: d6abc18d6693 ("drm/xe/xe2: Modify xe_bo_test for system memory") Signed-off-by: Dan Carpenter Reviewed-by: Matthew Brost --- drivers/gpu/drm/xe/tests/xe_bo.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/tests/xe_bo.c b/drivers/gpu/drm/xe/tests/xe= _bo.c index 412b2e7ce40c..3436fd9cf2b2 100644 --- a/drivers/gpu/drm/xe/tests/xe_bo.c +++ b/drivers/gpu/drm/xe/tests/xe_bo.c @@ -125,14 +125,13 @@ static void ccs_test_run_tile(struct xe_device *xe, s= truct xe_tile *tile, =20 bo =3D xe_bo_create_user(xe, NULL, NULL, SZ_1M, DRM_XE_GEM_CPU_CACHING_WC, ttm_bo_type_device, bo_flags); - - xe_bo_lock(bo, false); - if (IS_ERR(bo)) { KUNIT_FAIL(test, "Failed to create bo.\n"); return; } =20 + xe_bo_lock(bo, false); + kunit_info(test, "Verifying that CCS data is cleared on creation.\n"); ret =3D ccs_test_migrate(tile, bo, false, 0ULL, 0xdeadbeefdeadbeefULL, test); --=20 2.42.0