From nobody Wed Feb 11 05:18:06 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CCDEC76196 for ; Sun, 2 Apr 2023 09:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230481AbjDBJws (ORCPT ); Sun, 2 Apr 2023 05:52:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230367AbjDBJw3 (ORCPT ); Sun, 2 Apr 2023 05:52:29 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 459BB1D86D for ; Sun, 2 Apr 2023 02:52:16 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id y4so106365714edo.2 for ; Sun, 02 Apr 2023 02:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680429136; x=1683021136; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0/d2ZeR1z4unotF600EGJ8LS6r3TxAXihhwj6OvhZ4s=; b=Vhs4KIS8EiSOEDtFrW5LWi892ufy5hYLekAexhJ7VTBT23bHuDBUUwV4vArZaxEZcP 9/cay62aOVWWH6M1N6cNHvZ1QZ2nqCtqyw2a7LdjK0p1KfuWrz1FSmG2yOdDr4PQIGCB jW2DNQLlxPjl/zdnZ1mEXrqWhBzDJk3ftS74carwEtcG3vBucvzwnWxHKZbyJ567US68 js1CLL5WF2k0/pvNwmjxPLvD4rYY+eTPsj9wh+jLXQbUj3kPt6RovjY/2p4FvsDQj2ry bPnQojhYRCn5EVaJ0i2lK4Z6wKr+OnGeed0w4UspfqBqLkcrCDbRBD3HNtdpyBko14Jm 5q7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680429136; x=1683021136; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0/d2ZeR1z4unotF600EGJ8LS6r3TxAXihhwj6OvhZ4s=; b=mdj1+QG6N3KsP4JBO02yK2s9J8Wk7dlHH1Kt4k2IJuzlD6XFkQuopTX1GTU034EcVl cRxbu3CGEJjFmqd3U6ntvPfs9zPWJcHinEjCtL0oCeaCfb6Bd4GjilVf/g55GB1loGJW AU0A+kZcC8oR4fDGSXM05gpBx+v/BO+xronh8XZ37D2iFU4DOtieVvhP9x8sYBJfkm61 ogxBlyT0NOiQylvmKL5m8SXTUulyfwCPd2hyfnJsrAfw19Fhq0uVDdkhBktG1xIx1viW rx0Aw4jzVn1HZYOCSvk3gMFWMR37ja4UrKsv5JzpAinrPVYPIEAsQF8TtYZer9nW0jyr hldg== X-Gm-Message-State: AAQBX9e5g6It6l+a+IlXk0nr72nGoHD6SoxXK1nHnBAqDO2GAJ2kAAeE qtltiQTB9iPhUHMHb8X6nQAISumeqP0= X-Google-Smtp-Source: AKy350aQqBJ/2FYaGFnaqBoz8Ycuma9lVMpJrH9jMw4Iw4fCEoK/T2T88jeXnaAnFeUxBEjVsn38dw== X-Received: by 2002:a17:906:7390:b0:947:8734:a058 with SMTP id f16-20020a170906739000b009478734a058mr8284146ejl.4.1680429135633; Sun, 02 Apr 2023 02:52:15 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id p16-20020a170906a01000b008cc920469b5sm3099067ejy.18.2023.04.02.02.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 02:52:15 -0700 (PDT) Date: Sun, 2 Apr 2023 11:52:13 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/6] staging: rtl8192e: Remove case customer_id = RT_CID_DEFAULT, .. Message-ID: <58df9db5da84991206266e739b2a12c893d1be8e.1680427945.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" customer_id is initialize to zero. Changing customer_id to RT_CID_DEFAULT will not change customer_id as it is already zero. default and EEPROM_CID_WHQL contain only a break. Remove useless code lines to increase readability. Signed-off-by: Philipp Hortmann --- V1->V2: No changes --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 -------- drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 2 -- 2 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index df8de35cbe0e..aed53fedeb61 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -432,9 +432,6 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) priv->chnl_plan =3D priv->reg_chnl_plan; =20 switch (priv->eeprom_customer_id) { - case EEPROM_CID_DEFAULT: - priv->customer_id =3D RT_CID_DEFAULT; - break; case EEPROM_CID_NetCore: priv->customer_id =3D RT_CID_819X_NETCORE; break; @@ -445,11 +442,6 @@ static void _rtl92e_read_eeprom_info(struct net_device= *dev) else priv->chnl_plan =3D 0x0; break; - - case EEPROM_CID_WHQL: - break; - default: - break; } =20 if (priv->chnl_plan > CHANNEL_PLAN_LEN - 1) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h b/drivers/stagin= g/rtl8192e/rtl8192e/r8192E_hw.h index 4ee78b7a558e..f4d4b01630a2 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h @@ -30,10 +30,8 @@ enum baseband_config { #define EEPROM_TxPwIndex_CCK 0x2C #define EEPROM_TxPwIndex_OFDM_24G 0x3A =20 -#define EEPROM_CID_DEFAULT 0x0 #define EEPROM_CID_TOSHIBA 0x4 #define EEPROM_CID_NetCore 0x5 -#define EEPROM_CID_WHQL 0xFE enum _RTL8192PCI_HW { MAC0 =3D 0x000, MAC4 =3D 0x004, --=20 2.40.0