From nobody Mon Feb 9 03:29:05 2026 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A571171C4 for ; Sat, 16 Mar 2024 09:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710581296; cv=none; b=rI7eAl0tCZ7/AT9hOi/6qsxCCEaxqDqw0l6OvYJxthXCNOqChOM65umuPj9xRRfp91L035i2AzZV5o3kmAciuPamzr0nQ5LhDqzt+9j8+ZoadgrXV7rvqTZky+wIgdGMRvljbTg5OxOhx99I70WAfAuqXepYO2+ZRhiZTH8xDn0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710581296; c=relaxed/simple; bh=Sk3IUMq+ynWrhub4+s7U0qctho1XK9mVRiKtEWsFTG8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=hwOS9L/A8XsR9XAwlS/ustE8dc2MP5VZmByLGgOJn518koXiqyy9YSNgmyGiz6l28hXYHwjpwyL0zMVW8EnMZJpEi/Hhb067PcTlwAVh5fItkVe3iJ1hlVe8nJtXKpkXEFmRfwEuOUnBkrMMJ8wzEoxSdr7jDbyYwirBslU0gbg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vDu55L3S; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vDu55L3S" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-513a6416058so4057905e87.1 for ; Sat, 16 Mar 2024 02:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710581291; x=1711186091; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=aohr4d7BClKxelEDFFKHCRuY2eGHwzyMDzY2KtCl00o=; b=vDu55L3SUpAwQhATy9P+ivNW+VyK+Gn7qM01kDVzqJ4lYauDbTmO5zsQraO76vRu7/ 2j4OQIdFeUIbkIOTbQkj2asMQN0Ihm2c5Sg4ar9ljBUt8P3Ddf4CpEY34qgI2gQExDRe TashIZkLVa3YS2Q7QCRkWDsf746UFfcNxs0MYFaSF8wXBFa2OutzdbMxxoCB0ToOLv9c F2FYt4QIks5S4BZT8LsL4AgUpWadrLSlawF6okpu9X6PgzyUrzP55iw56QXw1J86Cfym oJ7CPZ3C9eAcmEgSLIUpg3p7iCLVOD7hO9ZKzkFzbmzVpShVmPupgRGDLY5UnETdoAwG 9Wlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710581291; x=1711186091; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aohr4d7BClKxelEDFFKHCRuY2eGHwzyMDzY2KtCl00o=; b=PgiIlhLa/dAolrHQ1KkdkPbZp/DRvumUygbyV4TIdmEYtViwEmlPvev/4S0QO+/LFd YTujeSsX2u07WsqnsCzaDCJlO1PZg7DizfEoSUZqoslUZS+FU/cLskTzSf1YS/lLxf+X Os5F/zb2Hx2UQIDcYXSmGpG7Jo8rw+5+DGBUzFgF8hj3pB13eG4wf69SEQNTwVqJdeMb mi1VVPpAcdcJctmg/Gm+6GefN4Y2gWOMQaFuKk7E6xumiASmOGnQWuybkx6AFzOlh93x i2nPctAgwxfBBmnb8mc/TwVi8a+Q0J3oJ+vdufX0eaFA22cfx1l0Shre1g07M/0ydu0c wt9A== X-Forwarded-Encrypted: i=1; AJvYcCU+cDqbuHb/aFXkKc8958/ofhU38CBqjIGDUhzueS7zvXebozY9z3nCk3HTsoHc2fW8aN2+jFBgPWwvsGZVII6YVQdkvhwi/NJ06+Y2 X-Gm-Message-State: AOJu0YzQCp1U1mu9/cgiNUIjVFKaPQ0lfFBR+ks+zMR6iPjme2u8HiSB yEjTGqF5NeFOTJE5HjFBtxnnW4gy4kqkDm31tgfQ1cpv0ImKRZA5z4QISoMljWE= X-Google-Smtp-Source: AGHT+IEcnp7qiM6IXTp0ox63XBBssfGbXKm5O93H133J9J0QTjrgFwKlcFwMjSWaSlH8P9wUdPdZJQ== X-Received: by 2002:a19:4353:0:b0:513:cc34:342a with SMTP id m19-20020a194353000000b00513cc34342amr4706454lfj.14.1710581290898; Sat, 16 Mar 2024 02:28:10 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id n20-20020a05600c4f9400b00412f8bf2d82sm11391125wmq.28.2024.03.16.02.28.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Mar 2024 02:28:10 -0700 (PDT) Date: Sat, 16 Mar 2024 12:28:06 +0300 From: Dan Carpenter To: Harry Wentland Cc: Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Nicholas Kazlauskas , Charlene Liu , Jun Lei , Alex Hung , Daniel Miess , Sung Joon Kim , Yang Li , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/amd/display: delete unnecessary check in dcn35_set_long_vblank() Message-ID: <56712ad5-ed41-4d64-a317-10cc1275137a@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" "timing" is "&pipe_ctx[i]->stream->timing" where ->timing is not the first struct member of ->stream. So it's the address which points into the middle of a struct. It can't be NULL so delete the NULL check. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c b/driv= ers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c index 2e8ec58a16eb..87cfd9f1cec9 100644 --- a/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c @@ -1411,10 +1411,7 @@ void dcn35_set_long_vblank(struct pipe_ctx **pipe_ct= x, if (pipe_ctx[i]->stream) { struct dc_crtc_timing *timing =3D &pipe_ctx[i]->stream->timing; =20 - if (timing) - params.vertical_blank_start =3D timing->v_total - timing->v_front_porc= h; - else - params.vertical_blank_start =3D 0; + params.vertical_blank_start =3D timing->v_total - timing->v_front_porch; =20 if ((pipe_ctx[i]->stream_res.tg !=3D NULL) && pipe_ctx[i]->stream_res.t= g->funcs && pipe_ctx[i]->stream_res.tg->funcs->set_long_vtotal) --=20 2.43.0