From nobody Fri Sep 20 11:31:28 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94130EE4993 for ; Mon, 21 Aug 2023 16:14:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236458AbjHUQOC (ORCPT ); Mon, 21 Aug 2023 12:14:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235706AbjHUQOB (ORCPT ); Mon, 21 Aug 2023 12:14:01 -0400 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B45EEDB; Mon, 21 Aug 2023 09:13:59 -0700 (PDT) Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1qY7X8-0002rU-0F; Mon, 21 Aug 2023 16:13:38 +0000 Date: Mon, 21 Aug 2023 17:12:44 +0100 From: Daniel Golle To: Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Sujuan Chen , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net v2] net: ethernet: mtk_eth_soc: fix NULL pointer on hw reset Message-ID: <5465c1609b464cc7407ae1530c40821dcdf9d3e6.1692634266.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a hardware reset is triggered on devices not initializing WED the calls to mtk_wed_fe_reset and mtk_wed_fe_reset_complete dereference a pointer on uninitialized stack memory. Break out of both functions in case a hw_list entry is 0. Fixes: 08a764a7c51b ("net: ethernet: mtk_wed: add reset/reset_complete call= backs") Signed-off-by: Daniel Golle Reviewed-by: Simon Horman Acked-by: Lorenzo Bianconi --- Changes since v1: * remove unneeded {} initialization for stack allocated memory drivers/net/ethernet/mediatek/mtk_wed.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet= /mediatek/mtk_wed.c index 00aeee0d5e45f..94376aa2b34c5 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed.c +++ b/drivers/net/ethernet/mediatek/mtk_wed.c @@ -222,9 +222,13 @@ void mtk_wed_fe_reset(void) =20 for (i =3D 0; i < ARRAY_SIZE(hw_list); i++) { struct mtk_wed_hw *hw =3D hw_list[i]; - struct mtk_wed_device *dev =3D hw->wed_dev; + struct mtk_wed_device *dev; int err; =20 + if (!hw) + break; + + dev =3D hw->wed_dev; if (!dev || !dev->wlan.reset) continue; =20 @@ -245,8 +249,12 @@ void mtk_wed_fe_reset_complete(void) =20 for (i =3D 0; i < ARRAY_SIZE(hw_list); i++) { struct mtk_wed_hw *hw =3D hw_list[i]; - struct mtk_wed_device *dev =3D hw->wed_dev; + struct mtk_wed_device *dev; + + if (!hw) + break; =20 + dev =3D hw->wed_dev; if (!dev || !dev->wlan.reset_complete) continue; =20 --=20 2.41.0