From nobody Mon Feb 9 06:48:57 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D03471E47B4 for ; Wed, 30 Apr 2025 11:56:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746014186; cv=none; b=K6cxQp7X9dZmn8+Ei49GEStPMJsoqysQBwXMAUy6mgLCJv9mMBRVw0SjX9lNTKjbFzWmp8YJEUJzZsaaMvbzVUr2j+qbcQfSEL4vpe04Gt6BOWccY08wjG5J5UQUp7WHPKldXx9mizkl8KKOXnvQtaSFHEG/pRtRa/AEaMOQEsk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746014186; c=relaxed/simple; bh=pmPfZfdhpe08zFnN5tLlJkVDVkEeNQk+NEZc/D1fbGQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i8h6ldEIGn+tUiOfCUEnNf8u6KUwMo3DfcgTd2rPLxkQBJv4Nlga46xe+eGKdCSbqB8dvSIUqoN9UohCOVZWdZ/DaTxYSqoDyO/iiVDemXiWFQxZA76g2M4pR/EnLrqcJyM1tCZs8p+PDK/miTB+RdGFK/Z+lv/Fc28+dYFb7JM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=U1lTjCq/; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="U1lTjCq/" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-39c14016868so7708819f8f.1 for ; Wed, 30 Apr 2025 04:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1746014183; x=1746618983; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F2xHxs3KnDeNu7WRbSnqj4aOhMB1CBDFvBqUKG0qcVk=; b=U1lTjCq/A/NsedpPy+FqXPajbHINPe4dUnxJsZ8BGfdZbfFo1915Va7zYqO/BjC613 s9q98Nd6VZ9IvqLu9Hz3TsH0Pe1i+hJHtht2ozjRTll0CH2gFHzKxUxzvS/d3koDj1RC W7C1YPSna6De01HlTqm9w8+OEPbU5quI2mURzJxDyCTRLhmb0yTAtdMg9ik95paBfPKz owH6m+4Ab11AEeOZT6u/7MP9cw/TyzqcK7GSvS0L5uaG48POzBVd/nnamoDSxyZU8b3Y +QKF4esqJWRou94ZpeCt+zkfOe/O6eEayaQZSA1Fpjy2EdsjhbmW2uFG5broEf7RffWy LCGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746014183; x=1746618983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F2xHxs3KnDeNu7WRbSnqj4aOhMB1CBDFvBqUKG0qcVk=; b=J514NbvNJW06GJ7I+QlpzhP+BxGU00oKGLiXalQPo27B0RaavNS4Gcz3vv59kNfXWj BGnpPSKEIXbWjb3wmUHCrGM3Ft8VWqMkI0BI4Q9iJI204J+2cSOmaeRHM6sB5RkJiN8L XvMDLbcxlqr0HZmGBbLY+JMr4hecsZqTEYWbo7EG7c7/cuhTb6wy7WU2cdJAYufMiDd5 rOyqFu7tqNoO0dTdaZMzW5+E83Yh6ghD9i+ONcJWOyfc0810U/LTo8o3zPaTb8x+1TaL ryiolQ0mAD7qYBsfDI9UnJyK1ixNdsGBwghiYs1dbsH6296qG6MaEf6oKmOuDp8TQd8H 9FUg== X-Forwarded-Encrypted: i=1; AJvYcCUq0bMFQ+4hYyaaVlllwdZFxEX07BFe0GZTEHrAPXZkl7oUncEETFddgWlKTPBLSmLjfGm9kJUbZkQUET0=@vger.kernel.org X-Gm-Message-State: AOJu0YwK6iApFUFC+lEiTQCaNsrKARxA1pkxvG72VRdscysiUppw/sR2 joy+MsCTlXP+BJzZCq5mMDASwfGZgc6Tp6DgwAXlW4kzRpaQd0iwBUCnhlkpRJs= X-Gm-Gg: ASbGnctKfr27zs+40+upYmGBIvyORi5M0KU7177n+TQiw53P9GY4grwk7FsgxXQkaXR zRRM5Y/WCVPzRAUFSbGwwWe97UIFkkMQHBwFEGE6UW1RRAOSMY6Gz5TsBnKsOY2ul9oYQkP6J8H phlK1GR1/bdV69dB1s6TN1pokQAx/zwff+XutviOPaQ7LwzL/UeO9fTmid5LsK6X9fXOqw102CJ eKoyvEiXK6TBgK7p25Epv/a4mnrVLbXi6TeoIkJo9/Mr9cQ45kQjpOib3P+NvunTfHUiWuke0BK qyEhBxgHUjicLhD33QbOOXD8iM7A2z1PJJKmpN9FdCvXvbiTNLQVh3MAtHOsz+NERl4KCVb0Xos NQmgLOBQ= X-Google-Smtp-Source: AGHT+IEIVW9hCC7khpxN5eC7lwB7Nqf2uJEp51BVHaLSAHCM2w4LxwKU+3btSCLoZCrVcxQtJJXnLQ== X-Received: by 2002:a05:600c:19c8:b0:43c:fee3:2bce with SMTP id 5b1f17b1804b1-441b1f5be9cmr20071305e9.26.1746014183134; Wed, 30 Apr 2025 04:56:23 -0700 (PDT) Received: from localhost (p200300f65f00780800000000000001b9.dip0.t-ipconnect.de. [2003:f6:5f00:7808::1b9]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-441ad81c19fsm39248705e9.0.2025.04.30.04.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 04:56:22 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: linux-pwm@vger.kernel.org Cc: David Lechner , Kent Gibson , linux-kernel@vger.kernel.org Subject: [PATCH v7 2/4] pwm: Let pwm_set_waveform_might_sleep() return 0 instead of 1 after rounding up Date: Wed, 30 Apr 2025 13:55:59 +0200 Message-ID: <528cc3bbd9e35dea8646b1bcc0fbfe6c498bb4ed.1746010245.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2135; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=pmPfZfdhpe08zFnN5tLlJkVDVkEeNQk+NEZc/D1fbGQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBoEg/VsjKyV93JzbnPFh5tLFh0UPbIAUVfCmmlT MRb5M0C+pSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaBIP1QAKCRCPgPtYfRL+ TiS6B/sE4DJYf8tPuMmZjF5NMTHFVXtusXFoGZ7tEhv2XsdL4zhkmhdiPGvNJ/Vdo0hmA/+CGF0 ZPc8oeVrDfZpTtmfeitvKJxXrIpmHbOEET7HaqNwgqXDI/jkH5onHb8Q1VM7ndAdIHG6sOzn7eB TxuRnK9NarmXREUKOesQ5by0RYVpW1UM25BPne2kW5z6A/BrscgPkIYVGCtpU07jh9Ra/OE/B9S Zddt+uF0GmECErrKM8z2bRN5HqCnpfqRhVRLx8oIo1nn3m8nHkAu5MIIzPirKhsusSJ6RYcl0Af /nZckWkKkMMiiCBYjalpaxqnkpi0kvlkLQJ+62xuVFlHsyRe X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable While telling the caller of pwm_set_waveform_might_sleep() if the request was completed by rounding down only or (some) rounding up gives additional information, it makes usage this function needlessly hard and the additional information is not used. A prove for that is that currently both users of this function just pass the returned value up to their caller even though a positive value isn't intended there. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/pwm/core.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 28cb6ab0f62d..5cf64b3a4cdf 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -411,9 +411,8 @@ static int __pwm_set_waveform(struct pwm_device *pwm, * possible/needed. In the above example requesting .period_length_ns =3D = 94 and * @exact =3D true, you get the hardware configured with period =3D 93.5 n= s. * - * Returns: 0 on success, 1 if was rounded up (if !@exact), -EDOM if setti= ng - * failed due to the exact waveform not being possible (if @exact), or a - * different negative errno on failure. + * Returns: 0 on success, -EDOM if setting failed due to the exact wavefor= m not + * being possible (if @exact), or a different negative errno on failure. * Context: May sleep. */ int pwm_set_waveform_might_sleep(struct pwm_device *pwm, @@ -442,14 +441,17 @@ int pwm_set_waveform_might_sleep(struct pwm_device *p= wm, } =20 /* - * map err =3D=3D 1 to -EDOM for exact requests. Also make sure that -EDO= M is - * only returned in exactly that case. Note that __pwm_set_waveform() - * should never return -EDOM which justifies the unlikely(). + * map err =3D=3D 1 to -EDOM for exact requests and 0 for !exact ones. Al= so + * make sure that -EDOM is only returned in exactly that case. Note that + * __pwm_set_waveform() should never return -EDOM which justifies the + * unlikely(). */ if (unlikely(err =3D=3D -EDOM)) err =3D -EINVAL; else if (exact && err =3D=3D 1) err =3D -EDOM; + else if (err =3D=3D 1) + err =3D 0; =20 return err; } --=20 2.47.2