From nobody Sat Dec 27 22:52:05 2025 Received: from irl.hu (irl.hu [95.85.9.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DEC6671F0; Thu, 14 Dec 2023 22:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=irl.hu Received: from fedori.lan (51b687c3.dsl.pool.telekom.hu [::ffff:81.182.135.195]) (AUTH: CRAM-MD5 soyer@irl.hu, ) by irl.hu with ESMTPSA id 0000000000070E5B.00000000657B7C0C.0012CBE8; Thu, 14 Dec 2023 23:04:59 +0100 From: Gergo Koteles To: Shenghao Ding , Kevin Lu , Baojun Xu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Gergo Koteles , stable@vger.kernel.org Subject: [PATCH] ASoC: tas2781: check the validity of prm_no/cfg_no Date: Thu, 14 Dec 2023 23:04:44 +0100 Message-ID: <523780155bfdca9bc0acd39efc79ed039454818d.1702591356.git.soyer@irl.hu> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mime-Autoconverted: from 8bit to 7bit by courier 1.0 Content-Type: text/plain; charset="utf-8" Add additional checks for program/config numbers to avoid loading from invalid addresses. If prm_no/cfg_no is negative, skip uploading program/config. The tas2781-hda driver caused a NULL pointer dereference after loading module, and before first runtime_suspend. the state was: tas_priv->cur_conf =3D -1; tas_priv->tasdevice[i].cur_conf =3D 0; program =3D &(tas_fmw->programs[-1]); BUG: kernel NULL pointer dereference, address: 0000000000000010 Call Trace: ? __die+0x23/0x70 ? page_fault_oops+0x171/0x4e0 ? vprintk_emit+0x175/0x2b0 ? exc_page_fault+0x7f/0x180 ? asm_exc_page_fault+0x26/0x30 ? tasdevice_load_block_kernel+0x21/0x310 [snd_soc_tas2781_fmwlib] tasdevice_select_tuningprm_cfg+0x268/0x3a0 [snd_soc_tas2781_fmwlib] tasdevice_tuning_switch+0x69/0x710 [snd_soc_tas2781_fmwlib] tas2781_hda_playback_hook+0xd4/0x110 [snd_hda_scodec_tas2781_i2c] Fixes: 915f5eadebd2 ("ASoC: tas2781: firmware lib") CC: stable@vger.kernel.org Signed-off-by: Gergo Koteles --- sound/soc/codecs/tas2781-fmwlib.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-f= mwlib.c index eb55abae0d7b..1dfac9b2fca2 100644 --- a/sound/soc/codecs/tas2781-fmwlib.c +++ b/sound/soc/codecs/tas2781-fmwlib.c @@ -2219,11 +2219,11 @@ int tasdevice_select_tuningprm_cfg(void *context, i= nt prm_no, goto out; } =20 - conf =3D &(tas_fmw->configs[cfg_no]); for (i =3D 0, prog_status =3D 0; i < tas_priv->ndev; i++) { if (cfg_info[rca_conf_no]->active_dev & (1 << i)) { - if (tas_priv->tasdevice[i].cur_prog !=3D prm_no - || tas_priv->force_fwload_status) { + if (prm_no >=3D 0 + && (tas_priv->tasdevice[i].cur_prog !=3D prm_no + || tas_priv->force_fwload_status)) { tas_priv->tasdevice[i].cur_conf =3D -1; tas_priv->tasdevice[i].is_loading =3D true; prog_status++; @@ -2258,7 +2258,8 @@ int tasdevice_select_tuningprm_cfg(void *context, int= prm_no, } =20 for (i =3D 0, status =3D 0; i < tas_priv->ndev; i++) { - if (tas_priv->tasdevice[i].cur_conf !=3D cfg_no + if (cfg_no >=3D 0 + && tas_priv->tasdevice[i].cur_conf !=3D cfg_no && (cfg_info[rca_conf_no]->active_dev & (1 << i)) && (tas_priv->tasdevice[i].is_loaderr =3D=3D false)) { status++; @@ -2268,6 +2269,7 @@ int tasdevice_select_tuningprm_cfg(void *context, int= prm_no, } =20 if (status) { + conf =3D &(tas_fmw->configs[cfg_no]); status =3D 0; tasdevice_load_data(tas_priv, &(conf->dev_data)); for (i =3D 0; i < tas_priv->ndev; i++) { @@ -2311,7 +2313,7 @@ int tasdevice_prmg_load(void *context, int prm_no) } =20 for (i =3D 0, prog_status =3D 0; i < tas_priv->ndev; i++) { - if (tas_priv->tasdevice[i].cur_prog !=3D prm_no) { + if (prm_no >=3D 0 && tas_priv->tasdevice[i].cur_prog !=3D prm_no) { tas_priv->tasdevice[i].cur_conf =3D -1; tas_priv->tasdevice[i].is_loading =3D true; prog_status++; @@ -2356,7 +2358,7 @@ int tasdevice_prmg_calibdata_load(void *context, int = prm_no) } =20 for (i =3D 0, prog_status =3D 0; i < tas_priv->ndev; i++) { - if (tas_priv->tasdevice[i].cur_prog !=3D prm_no) { + if (prm_no >=3D 0 && tas_priv->tasdevice[i].cur_prog !=3D prm_no) { tas_priv->tasdevice[i].cur_conf =3D -1; tas_priv->tasdevice[i].is_loading =3D true; prog_status++; base-commit: ffc253263a1375a65fa6c9f62a893e9767fbebfa --=20 2.43.0