From nobody Tue Apr 7 15:56:27 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54058C4332F for ; Mon, 17 Oct 2022 16:27:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbiJQQ1O (ORCPT ); Mon, 17 Oct 2022 12:27:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229747AbiJQQ1M (ORCPT ); Mon, 17 Oct 2022 12:27:12 -0400 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4576A6D573 for ; Mon, 17 Oct 2022 09:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666024017; bh=FMafp2VnUlBIYWBO1+8OqeP18GRVh8GYQ+34OLtL540=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=FLIQ+Jv6K7l0/i4v25rGrUZ9zGngATvllqhyQhSClQDtpJJsw0sV2CjnMQMlq6YOp 2k+0tIa3d6bgPbABZZ6C9BultkI1nXk/6hgACfxDZKeJ4OEB4Tl7iRjjapL+c9Ornx IDycAzzCL84NL0yhzQXL4A+wCls8y96SsfuC9DFU= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via [213.182.55.206] Mon, 17 Oct 2022 18:26:57 +0200 (CEST) X-EA-Auth: h+mTrog4EchL0r0jdzSVGtG2gfqaUS4O4sNE206hQ/HAsFT2NIUnkecd+IJC5kr8cr+UZJNwQci+Pd8hELparF1C/zeasDCn Date: Mon, 17 Oct 2022 21:27:24 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, paskripkin@gmail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: [PATCH v1 1/4] staging: r8188eu: use Linux kernel variable naming convention Message-ID: <5226d30242be78ab1ee32bfdd87239ca82569642.1666021212.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Follow the Linux Kernel coding style variable naming convention instead of using camelCase style. Issue reported by checkpatch script for these variables: tagLen, tagType, networkAddr, ipAddr, macAddr Signed-off-by: Deepak R Varma --- Changes in v1: 1. Improve patch description per feedback from julia.lawall@inria.fr drivers/staging/r8188eu/core/rtw_br_ext.c | 112 +++++++++++----------- 1 file changed, 56 insertions(+), 56 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8= 188eu/core/rtw_br_ext.c index 4c5f30792a46..79daf8f269d6 100644 --- a/drivers/staging/r8188eu/core/rtw_br_ext.c +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c @@ -50,17 +50,17 @@ static unsigned char *__nat25_find_pppoe_tag(struct pppoe_hdr *ph, unsigne= d short type) { unsigned char *cur_ptr, *start_ptr; - unsigned short tagLen, tagType; + unsigned short tag_len, tag_type; start_ptr =3D (unsigned char *)ph->tag; cur_ptr =3D (unsigned char *)ph->tag; while ((cur_ptr - start_ptr) < ntohs(ph->length)) { /* prevent un-alignment access */ - tagType =3D (unsigned short)((cur_ptr[0] << 8) + cur_ptr[1]); - tagLen =3D (unsigned short)((cur_ptr[2] << 8) + cur_ptr[3]); - if (tagType =3D=3D type) + tag_type =3D (unsigned short)((cur_ptr[0] << 8) + cur_ptr[1]); + tag_len =3D (unsigned short)((cur_ptr[2] << 8) + cur_ptr[3]); + if (tag_type =3D=3D type) return cur_ptr; - cur_ptr =3D cur_ptr + TAG_HDR_LEN + tagLen; + cur_ptr =3D cur_ptr + TAG_HDR_LEN + tag_len; } return NULL; } @@ -111,32 +111,32 @@ static int __nat25_has_expired(struct nat25_network_= db_entry *fdb) return 0; } -static void __nat25_generate_ipv4_network_addr(unsigned char *networkAddr, - unsigned int *ipAddr) +static void __nat25_generate_ipv4_network_addr(unsigned char *network_addr, + unsigned int *ip_addr) { - memset(networkAddr, 0, MAX_NETWORK_ADDR_LEN); + memset(network_addr, 0, MAX_NETWORK_ADDR_LEN); - networkAddr[0] =3D NAT25_IPV4; - memcpy(networkAddr + 7, (unsigned char *)ipAddr, 4); + network_addr[0] =3D NAT25_IPV4; + memcpy(network_addr + 7, (unsigned char *)ip_addr, 4); } -static void __nat25_generate_pppoe_network_addr(unsigned char *networkAddr, +static void __nat25_generate_pppoe_network_addr(unsigned char *network_add= r, unsigned char *ac_mac, __be16 *sid) { - memset(networkAddr, 0, MAX_NETWORK_ADDR_LEN); + memset(network_addr, 0, MAX_NETWORK_ADDR_LEN); - networkAddr[0] =3D NAT25_PPPOE; - memcpy(networkAddr + 1, (unsigned char *)sid, 2); - memcpy(networkAddr + 3, (unsigned char *)ac_mac, 6); + network_addr[0] =3D NAT25_PPPOE; + memcpy(network_addr + 1, (unsigned char *)sid, 2); + memcpy(network_addr + 3, (unsigned char *)ac_mac, 6); } -static void __nat25_generate_ipv6_network_addr(unsigned char *networkAddr, - unsigned int *ipAddr) +static void __nat25_generate_ipv6_network_addr(unsigned char *network_add= r, + unsigned int *ip_addr) { - memset(networkAddr, 0, MAX_NETWORK_ADDR_LEN); + memset(network_addr, 0, MAX_NETWORK_ADDR_LEN); - networkAddr[0] =3D NAT25_IPV6; - memcpy(networkAddr + 1, (unsigned char *)ipAddr, 16); + network_addr[0] =3D NAT25_IPV6; + memcpy(network_addr + 1, (unsigned char *)ip_addr, 16); } static unsigned char *scan_tlv(unsigned char *data, int len, unsigned char= tag, unsigned char len8b) @@ -200,40 +200,40 @@ static int update_nd_link_layer_addr(unsigned char *d= ata, int len, unsigned char return 0; } -static int __nat25_network_hash(unsigned char *networkAddr) +static int __nat25_network_hash(unsigned char *network_addr) { - if (networkAddr[0] =3D=3D NAT25_IPV4) { + if (network_addr[0] =3D=3D NAT25_IPV4) { unsigned long x; - x =3D networkAddr[7] ^ networkAddr[8] ^ networkAddr[9] ^ networkAddr[10]; + x =3D network_addr[7] ^ network_addr[8] ^ network_addr[9] ^ network_addr= [10]; return x & (NAT25_HASH_SIZE - 1); - } else if (networkAddr[0] =3D=3D NAT25_IPX) { + } else if (network_addr[0] =3D=3D NAT25_IPX) { unsigned long x; - x =3D networkAddr[1] ^ networkAddr[2] ^ networkAddr[3] ^ networkAddr[4] = ^ networkAddr[5] ^ - networkAddr[6] ^ networkAddr[7] ^ networkAddr[8] ^ networkAddr[9] ^ net= workAddr[10]; + x =3D network_addr[1] ^ network_addr[2] ^ network_addr[3] ^ network_addr= [4] ^ network_addr[5] ^ + network_addr[6] ^ network_addr[7] ^ network_addr[8] ^ network_addr[9] ^= network_addr[10]; return x & (NAT25_HASH_SIZE - 1); - } else if (networkAddr[0] =3D=3D NAT25_APPLE) { + } else if (network_addr[0] =3D=3D NAT25_APPLE) { unsigned long x; - x =3D networkAddr[1] ^ networkAddr[2] ^ networkAddr[3]; + x =3D network_addr[1] ^ network_addr[2] ^ network_addr[3]; return x & (NAT25_HASH_SIZE - 1); - } else if (networkAddr[0] =3D=3D NAT25_PPPOE) { + } else if (network_addr[0] =3D=3D NAT25_PPPOE) { unsigned long x; - x =3D networkAddr[0] ^ networkAddr[1] ^ networkAddr[2] ^ networkAddr[3] = ^ networkAddr[4] ^ networkAddr[5] ^ networkAddr[6] ^ networkAddr[7] ^ netwo= rkAddr[8]; + x =3D network_addr[0] ^ network_addr[1] ^ network_addr[2] ^ network_addr= [3] ^ network_addr[4] ^ network_addr[5] ^ network_addr[6] ^ network_addr[7]= ^ network_addr[8]; return x & (NAT25_HASH_SIZE - 1); - } else if (networkAddr[0] =3D=3D NAT25_IPV6) { + } else if (network_addr[0] =3D=3D NAT25_IPV6) { unsigned long x; - x =3D networkAddr[1] ^ networkAddr[2] ^ networkAddr[3] ^ networkAddr[4] = ^ networkAddr[5] ^ - networkAddr[6] ^ networkAddr[7] ^ networkAddr[8] ^ networkAddr[9] ^ net= workAddr[10] ^ - networkAddr[11] ^ networkAddr[12] ^ networkAddr[13] ^ networkAddr[14] ^= networkAddr[15] ^ - networkAddr[16]; + x =3D network_addr[1] ^ network_addr[2] ^ network_addr[3] ^ network_addr= [4] ^ network_addr[5] ^ + network_addr[6] ^ network_addr[7] ^ network_addr[8] ^ network_addr[9] ^= network_addr[10] ^ + network_addr[11] ^ network_addr[12] ^ network_addr[13] ^ network_addr[1= 4] ^ network_addr[15] ^ + network_addr[16]; return x & (NAT25_HASH_SIZE - 1); } else { @@ -241,7 +241,7 @@ static int __nat25_network_hash(unsigned char *networkA= ddr) int i; for (i =3D 0; i < MAX_NETWORK_ADDR_LEN; i++) - x ^=3D networkAddr[i]; + x ^=3D network_addr[i]; return x & (NAT25_HASH_SIZE - 1); } @@ -269,17 +269,17 @@ static void __network_hash_unlink(struct nat25_networ= k_db_entry *ent) } static void __nat25_db_network_insert(struct adapter *priv, - unsigned char *macAddr, unsigned char *networkAddr) + unsigned char *mac_addr, unsigned char *network_addr) { struct nat25_network_db_entry *db; int hash; spin_lock_bh(&priv->br_ext_lock); - hash =3D __nat25_network_hash(networkAddr); + hash =3D __nat25_network_hash(network_addr); db =3D priv->nethash[hash]; while (db) { - if (!memcmp(db->networkAddr, networkAddr, MAX_NETWORK_ADDR_LEN)) { - memcpy(db->macAddr, macAddr, ETH_ALEN); + if (!memcmp(db->networkAddr, network_addr, MAX_NETWORK_ADDR_LEN)) { + memcpy(db->macAddr, mac_addr, ETH_ALEN); db->ageing_timer =3D jiffies; spin_unlock_bh(&priv->br_ext_lock); return; @@ -291,8 +291,8 @@ static void __nat25_db_network_insert(struct adapter *p= riv, spin_unlock_bh(&priv->br_ext_lock); return; } - memcpy(db->networkAddr, networkAddr, MAX_NETWORK_ADDR_LEN); - memcpy(db->macAddr, macAddr, ETH_ALEN); + memcpy(db->networkAddr, network_addr, MAX_NETWORK_ADDR_LEN); + memcpy(db->macAddr, mac_addr, ETH_ALEN); atomic_set(&db->use_count, 1); db->ageing_timer =3D jiffies; @@ -366,7 +366,7 @@ void nat25_db_expire(struct adapter *priv) int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) { unsigned short protocol; - unsigned char networkAddr[MAX_NETWORK_ADDR_LEN]; + unsigned char network_addr[MAX_NETWORK_ADDR_LEN]; unsigned int tmp; if (!skb) @@ -395,9 +395,9 @@ int nat25_db_handle(struct adapter *priv, struct sk_buf= f *skb, int method) if (iph->saddr =3D=3D 0) return 0; tmp =3D be32_to_cpu(iph->saddr); - __nat25_generate_ipv4_network_addr(networkAddr, &tmp); + __nat25_generate_ipv4_network_addr(network_addr, &tmp); /* record source IP address and , source mac address into db */ - __nat25_db_network_insert(priv, skb->data + ETH_ALEN, networkAddr); + __nat25_db_network_insert(priv, skb->data + ETH_ALEN, network_addr); return 0; default: return -1; @@ -421,8 +421,8 @@ int nat25_db_handle(struct adapter *priv, struct sk_buf= f *skb, int method) memcpy(arp_ptr, GET_MY_HWADDR(priv), ETH_ALEN); arp_ptr +=3D arp->ar_hln; sender =3D (unsigned int *)arp_ptr; - __nat25_generate_ipv4_network_addr(networkAddr, sender); - __nat25_db_network_insert(priv, skb->data + ETH_ALEN, networkAddr); + __nat25_generate_ipv4_network_addr(network_addr, sender); + __nat25_db_network_insert(priv, skb->data + ETH_ALEN, network_addr); return 0; default: return -1; @@ -495,9 +495,9 @@ int nat25_db_handle(struct adapter *priv, struct sk_buf= f *skb, int method) return -1; } } else { /* session phase */ - __nat25_generate_pppoe_network_addr(networkAddr, skb->data, &ph->sid); + __nat25_generate_pppoe_network_addr(network_addr, skb->data, &ph->sid); - __nat25_db_network_insert(priv, skb->data + ETH_ALEN, networkAddr); + __nat25_db_network_insert(priv, skb->data + ETH_ALEN, network_addr); if (!priv->ethBrExtInfo.addPPPoETag && priv->pppoe_connection_in_progress && @@ -548,8 +548,8 @@ int nat25_db_handle(struct adapter *priv, struct sk_buf= f *skb, int method) return -1; case NAT25_INSERT: if (memcmp(&iph->saddr, "\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\= x0", 16)) { - __nat25_generate_ipv6_network_addr(networkAddr, (unsigned int *)&iph->= saddr); - __nat25_db_network_insert(priv, skb->data + ETH_ALEN, networkAddr); + __nat25_generate_ipv6_network_addr(network_addr, (unsigned int *)&iph-= >saddr); + __nat25_db_network_insert(priv, skb->data + ETH_ALEN, network_addr); if (iph->nexthdr =3D=3D IPPROTO_ICMPV6 && skb->len > (ETH_HLEN + sizeof(*iph) + 4)) { @@ -639,17 +639,17 @@ void dhcp_flag_bcast(struct adapter *priv, struct sk_= buff *skb) } } -void *scdb_findEntry(struct adapter *priv, unsigned char *ipAddr) +void *scdb_findEntry(struct adapter *priv, unsigned char *ip_addr) { - unsigned char networkAddr[MAX_NETWORK_ADDR_LEN]; + unsigned char network_addr[MAX_NETWORK_ADDR_LEN]; struct nat25_network_db_entry *db; int hash; - __nat25_generate_ipv4_network_addr(networkAddr, (unsigned int *)ipAddr); - hash =3D __nat25_network_hash(networkAddr); + __nat25_generate_ipv4_network_addr(network_addr, (unsigned int *)ip_addr); + hash =3D __nat25_network_hash(network_addr); db =3D priv->nethash[hash]; while (db) { - if (!memcmp(db->networkAddr, networkAddr, MAX_NETWORK_ADDR_LEN)) { + if (!memcmp(db->networkAddr, network_addr, MAX_NETWORK_ADDR_LEN)) { return (void *)db; } -- 2.30.2