From nobody Tue Apr 7 18:51:23 2026 Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB94D3921DD for ; Fri, 27 Feb 2026 05:36:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772170565; cv=none; b=BZjWiVFHt0L87yVHvfQyzA8KpOQPrclp5ee3IIo3ObTFpfzwWRABGYZixwijXyGaLs6kYZjRqe5A1CNSnCpCrR3QSzlTyCaD6hx8Wp2ZB70dl+SUKPkhq3I0Uu3vH8SlX9Op0tQFZ83P4+rXqoMCH+c8YsoFCMgO1oUhqMCvqx4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772170565; c=relaxed/simple; bh=7D+t6AZUYiHvvmGQ1ox/DgSRaKhS+kPTO4Semp3A/Go=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TCPy5uBGAkxLf32Py8wQmzMCxzTzxzwiq41BJGTZWYGlZB2EhsJzHshyaW8uXRUklH+okVQYWweBQhZvRUAsDwhv0bFZhOnLizhO5T9hBYfZO3WUisBc8tng0UxSVE1GYhXdsOP2hh+EbGIC+mP2eKkXcEugoDvJ++ecPRgS/kk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mXjoXkYQ; arc=none smtp.client-ip=209.85.222.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mXjoXkYQ" Received: by mail-ua1-f48.google.com with SMTP id a1e0cc1a2514c-94ddffda372so1917705241.1 for ; Thu, 26 Feb 2026 21:36:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772170563; x=1772775363; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MDesqVRO1Tim7+gISdrskbEX51kvM+tTCym0v98yq+w=; b=mXjoXkYQzf1kcddtfcCcIwhDd15HOtO3IT8DODrJDVZO6NxFIcquGsy3TlKfArOEkq v1i+FEPxOQBbtu8szf9FnyOIoVlToxbREcDYo7GSFYRaS/anitJPRy4leYnBcDZq4Nn3 Xru8hNNexcTZM+I7xePTNz7atj55Y9sZzq90jDgqvLoBHhI85DKSA5O0EdstAAtLL2n0 kUizhdiV6eMQoz+PVdIrsDNDWD6mdJOUm3OzUlEkFEZ6IghPhg8Su1ygrWWJrjIJp5xv Z6Yz47/S4P81ti7pNfkQOmcURUfzbHT4ceDsqNXwQsybIUHqIAoG56d7URDz1hWVYblk gr3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772170563; x=1772775363; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MDesqVRO1Tim7+gISdrskbEX51kvM+tTCym0v98yq+w=; b=WoMlfb6Oov79QCNEUSt8LPNTno+5+loLObHVuIjbIOYY6A0cclvS1BMiXQVjM33fpG Bn60XmclB8qRxwFG3+x9w5vGFOFbKScnjiGtRT7MU6DBwUWfjmAdtJFNLdvejPnSoluc rUdpPqPmqf8loBNSp34zzNwxjR1l14BQt+vxPgzVl8sETchbHP7lciTtMhEU9LFeKisR wHbn0dG9xVUzDcI6NHQJDMH0+FRt3//5mnhVR4B9JyyHFgXN/wEXpiyd17e53RhpdJj7 mSwA7Bz+fSxzCNkL7lOgVpmgYKs2xL+cDMsuL5/9W1eInib8QFV/ikfjHrGURMnPEcud YLPQ== X-Forwarded-Encrypted: i=1; AJvYcCUZ2gUHUwdaE8/cVZSHrMZ3A3hTMAwTzmBvizbHAywMjrGO6re43tLC4KDvl1aXcoUpr4ue33lbsWGWO+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzqTilSc31LO47JZKWQTo3a36ndGJgvIz3FpMPlIEX8eYA/yElX CI0e8sp2qVM0BLC5U8e3kuwJnJ43Dc+RJ0tuqW2KRqYJe2kubwqTJAjI X-Gm-Gg: ATEYQzzKXGupfhbiG0G/2x1PYk3i9rVjSHXYh5JM07vWgjN2LLLLcITvJ1ipzO1puPX nxvcANTfKAoWnHkZzeCij1hbaU3Kh27cRNYctLU3nO3GgiNPYP/DG881gTASkChN+B3/AWdTLIP +Au883nsN/Ity/4vBrsiEmk64H4kVnfdaywkiOljEP8KUNDtXtB7eaQ9euOsv3shru/wBlw6Jvf TcV5SboR5Ub6lyy4MxJviMaRuXpuKfxliDfIJcr6abBnIVkzmBd6f/ds0lCmFEApgBxViOAqmOr Zzt0fr46HzarPE71kz81Q/eGFbgunK96sNo9jnrL+lWkRR0Kf3Glhrp97YSlRSp7lJHr9yaoFCI YN0PxMn47JBfKuoWEJYSSiJ488vJ8WTr45AnT5W4hJFTl9WKq5MgPJVDequh4RwPoFfFEYtnLj5 AGXbRmPRs7zA== X-Received: by 2002:a05:6102:a48:b0:5ff:11dc:2ed7 with SMTP id ada2fe7eead31-5ff33712140mr755878137.16.1772170562643; Thu, 26 Feb 2026 21:36:02 -0800 (PST) Received: from geday ([2804:7f2:800b:feb1::dead:c001]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ff1ea1596asm4361324137.9.2026.02.26.21.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 21:36:01 -0800 (PST) Date: Fri, 27 Feb 2026 02:35:54 -0300 From: Geraldo Nascimento To: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Geraldo Nascimento , Dragan Simic Cc: linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/4] PCI: rockchip: drop 2.5 GT/s defines Message-ID: <5172389ba8d291fe05bc0887bc97fe73f110c5c0.1772169998.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop the 2.5 GT/s Link Speed defines from Rockchip PCIe header definitions. The reason is that Shawn Lin from Rockchip has reiterated that there may be danger of "catastrophic failure" in using their PCIe with 5.0 GT/s speeds. While Rockchip has done so informally without issuing a proper errata, and the particulars are thus unknown, this may cause data loss or worse. This change is corroborated by RK3399 official datasheet [1], which states maximum link speed for this platform is 2.5 GT/s. [1] https://opensource.rock-chips.com/images/d/d7/Rockchip_RK3399_Datasheet= _V2.1-20200323.pdf Fixes: 956cd99b35a8 ("PCI: rockchip: Separate common code from RC driver") Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@rock= -chips.com/ Cc: stable@vger.kernel.org Reported-by: Dragan Simic Reported-by: Shawn Lin Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controlle= r/pcie-rockchip.h index 3e82a69b9c00..b5da15601b58 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -42,7 +42,6 @@ #define PCIE_CLIENT_MODE_RC HWORD_SET_BIT(0x0040) #define PCIE_CLIENT_MODE_EP HWORD_CLR_BIT(0x0040) #define PCIE_CLIENT_GEN_SEL_1 HWORD_CLR_BIT(0x0080) -#define PCIE_CLIENT_GEN_SEL_2 HWORD_SET_BIT(0x0080) #define PCIE_CLIENT_LEGACY_INT_CTRL (PCIE_CLIENT_BASE + 0x0c) #define PCIE_CLIENT_INT_IN_ASSERT HWORD_SET_BIT(0x0002) #define PCIE_CLIENT_INT_IN_DEASSERT HWORD_CLR_BIT(0x0002) @@ -197,8 +196,6 @@ (((x) & PCIE_CORE_PL_CONF_LS_MASK) =3D=3D PCIE_CORE_PL_CONF_LS_READY) #define PCIE_LINK_UP(x) \ (((x) & PCIE_CLIENT_LINK_STATUS_MASK) =3D=3D PCIE_CLIENT_LINK_STATUS_UP) -#define PCIE_LINK_IS_GEN2(x) \ - (((x) & PCIE_CORE_PL_CONF_SPEED_MASK) =3D=3D PCIE_CORE_PL_CONF_SPEED_5G) =20 #define RC_REGION_0_ADDR_TRANS_H 0x00000000 #define RC_REGION_0_ADDR_TRANS_L 0x00000000 --=20 2.52.0