From nobody Sat Feb 7 17:41:49 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19373329395; Wed, 7 Jan 2026 12:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767789467; cv=none; b=Vb6MXsHRbA9YGXQBRYrZX0RONznh8upf+d2HGGKk/DSqFzVRiitt6CvBSRwddMJdz9uPTNKUCCXRBhRSICpE0Pao8n//Impvcyqlm9nCJ9TuLCfohi5J5hxniGCixfjiYk+8jdhuFUn67B5iN7yTObp1Fy71pMfXm0/K/Y1Gdxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767789467; c=relaxed/simple; bh=3rZ3aSqDtIQegdbz0UiHC1dGQWKjQrUwSTJAJTSwECw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kIa/NI7XWopupXxye9ONlvve/idJ3Vld4yIFlnkNREsM07PzYw614A1+E85oZSjUF9QNYmutwD5fu1Vpa99hUprSXf7Y0cUePe5wRlKzdmShGxk6Jvb5Yl5VQn67RNFL5NcWh+Qz7bu39eJ7dFAQWrynKGpMvExAz/UD1OZC09U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hlNR8W/3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hlNR8W/3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DCEEC4CEF7; Wed, 7 Jan 2026 12:37:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767789466; bh=3rZ3aSqDtIQegdbz0UiHC1dGQWKjQrUwSTJAJTSwECw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hlNR8W/3AVrpb8ASe87LFsEhWBoubhWmsxr04CZtHK2Vg/IJeTgzKtZ9um+fFfeOw bC+4X8FByJwNz2HWfmM8ZWqG51v0/GFeJvs5wFGx/28O7ph2qKD2qDeFb2hPWOH2r2 sdaOmpJ7fmn+FlBYWkRJIMbaCtYB2R/wVSUTCqMF4CBdAS6260wEmyEmf4hkB/Tni4 nAlqEMERywSjxxDxJV24W7fgUuxfIfCH7Mm4+52hFsL5qpdCfQXcgS0xw2QixEU9uQ s5vNMkcwVI4Ap9y+U/U8eZd1EuQypeASpJ1zO25uJoLNmFH9v8S/KU+p8d2T2ohxye GDKdLbUAkRb2Q== From: "Rafael J. Wysocki" To: Linux PM , Jakub Kicinski Cc: LKML , Ulf Hansson , Brian Norris , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Siddharth Vadapalli , Roger Quadros , netdev@vger.kernel.org, Nicolas Ferre , Claudiu Beznea , Simon Horman Subject: [RESEND][PATCH v2 1/3] net: ethernet: ti: am65-cpsw: Discard pm_runtime_put() return value Date: Wed, 07 Jan 2026 13:34:02 +0100 Message-ID: <5042490.GXAFRqVoOG@rafael.j.wysocki> Organization: Linux Kernel Development In-Reply-To: <2816529.mvXUDI8C0e@rafael.j.wysocki> References: <6245770.lOV4Wx5bFT@rafael.j.wysocki> <2816529.mvXUDI8C0e@rafael.j.wysocki> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Rafael J. Wysocki" Printing error messages on pm_runtime_put() returning negative values is not particularly useful. Returning an error code from pm_runtime_put() merely means that it has not queued up a work item to check whether or not the device can be suspended and there are many perfectly valid situations in which that can happen, like after writing "on" to the devices' runtime PM "control" attribute in sysfs for one example. Accordingly, update am65_cpsw_ethtool_op_begin() and cpsw_ethtool_op_begin() to simply discard the return value of pm_runtime_put(). This will facilitate a planned change of the pm_runtime_put() return type to void in the future. Signed-off-by: Rafael J. Wysocki --- v1 -> v2: No changes --- drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 5 +---- drivers/net/ethernet/ti/cpsw_ethtool.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-ethtool.c b/drivers/net/ethe= rnet/ti/am65-cpsw-ethtool.c index c57497074ae6..98d60da7cc3b 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-ethtool.c +++ b/drivers/net/ethernet/ti/am65-cpsw-ethtool.c @@ -391,11 +391,8 @@ static int am65_cpsw_ethtool_op_begin(struct net_devic= e *ndev) static void am65_cpsw_ethtool_op_complete(struct net_device *ndev) { struct am65_cpsw_common *common =3D am65_ndev_to_common(ndev); - int ret; =20 - ret =3D pm_runtime_put(common->dev); - if (ret < 0 && ret !=3D -EBUSY) - dev_err(common->dev, "ethtool complete failed %d\n", ret); + pm_runtime_put(common->dev); } =20 static void am65_cpsw_get_drvinfo(struct net_device *ndev, diff --git a/drivers/net/ethernet/ti/cpsw_ethtool.c b/drivers/net/ethernet/= ti/cpsw_ethtool.c index bdc4db0d169c..a43f75ee269e 100644 --- a/drivers/net/ethernet/ti/cpsw_ethtool.c +++ b/drivers/net/ethernet/ti/cpsw_ethtool.c @@ -374,11 +374,8 @@ int cpsw_ethtool_op_begin(struct net_device *ndev) void cpsw_ethtool_op_complete(struct net_device *ndev) { struct cpsw_priv *priv =3D netdev_priv(ndev); - int ret; =20 - ret =3D pm_runtime_put(priv->cpsw->dev); - if (ret < 0) - cpsw_err(priv, drv, "ethtool complete failed %d\n", ret); + pm_runtime_put(priv->cpsw->dev); } =20 void cpsw_get_channels(struct net_device *ndev, struct ethtool_channels *c= h) --=20 2.51.0