From nobody Wed Dec 17 19:04:55 2025 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C2F618C3D for ; Sat, 4 May 2024 11:26:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714821979; cv=none; b=RcpEMTfe47hCsAeebcfYvEeW5yPIXPc5EOcIY2UVS6311u8qA2AIozXat8u4ZU8fnpI7sa93AlroKLAfaoHs31lNWNSHOjaQOAEjGKmGY4H51D8wa/DwPo5TmyH7qUX8OjH9JahUFXdj8iwf7o125X8QwzSovkTJrbL4NbNUHVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714821979; c=relaxed/simple; bh=q9hMV1BT9OJQ7HePS+PG9LFG1oZyrdoizmQncp9kOz8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=klZL0h/8pWkC4Ifxbvw41ibUS0Fb0HV1kkW0JCYQcPqOdpDC/dBekf4y+9PO786HV4aMpGQcUhv6LUliGni1O2iSN/Nx3grb5hVCNkBNaUQ+HnGupzaLDxtKLx1+kM5GwgUUi+RpPZcyGka39PHIIrXHrJpeSBYgO05N/5NwBeQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=u8tIGbUm; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u8tIGbUm" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-34d0aa589a4so358780f8f.1 for ; Sat, 04 May 2024 04:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714821976; x=1715426776; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=acScVzoT0UgSxQf+NXyCSZ3pQCph88n8DycCWGq+e7Q=; b=u8tIGbUmyYcGQntLcsxP8rRqauFoGukkjBqCzpRqW9uRldZbIUV5I8z4Vw3Y1sOrm2 v/5KfgeKMXyeSr+KF6zRcAEfPPaWEJ98zJfPHs5Lb0Dz8GHuBLjinsgGQyjzlvfPAUQr eXO/wIe3RmpkS3vshAl1DswEtuuruCd6kmIema1I5HR8fYhNaqpraYsYh6i0y9E7/aU7 RPMcGGFvKVckpEjynT/KTuQXdM4JI3wPR4B/iidowQmfD5T6i814X1hxeS7nLVcK87pQ aQk8GqMVT1xMITFfppPUVR3Hch1JOAYh2Dq776UCQbOJj0Qim/Y7ywG7OO4HjLvDICkF kF2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714821976; x=1715426776; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=acScVzoT0UgSxQf+NXyCSZ3pQCph88n8DycCWGq+e7Q=; b=wN8xwdeEH2LSQ4UIPVPPDxuaR0bH2lTm9Ol9J4A+74bQFk3KUdUENJAQ27yORK1W9E xaU5nO1dE4yk3kgsIidDuPRznelG9I7VFovMRHL5F5+RwZXLHxt0NrqN87cxSqyavHVT 5o1+EkkNdSxxSAVMFFFbNSk4dddDPqUuuVPhRr7rUMbPV8ICVVIj7X37X+9UlsWIqOeC YnITQoAwzHipLEJ14J6kI3ycyp6fAeSdtpq1JGP1VVRwYArM9u1L/J01FJM3G0Z/trIp mTv5dR4gVkA4cDb2FqK4wXKDERYuEvVVEjy5JY0K+dWXx8XnbvAjxYnXO/QmtGmxT7zn 7z/A== X-Forwarded-Encrypted: i=1; AJvYcCVvE9OY+kWIkgu0YsnrmShcMOZ1qu7MQfqtZi1kUlqCWM0eqJqnMqrCkAi0q8BE6gRujXwHhQWKJT4PWVDTj+9G++SObofWKIqYTTZY X-Gm-Message-State: AOJu0YwIx4zfKqULcMIu1SZdX8Aprpc1mPLqgUPmQlRqm9Gfqbk38Fkv PuUgEftA2Xgnd8z8zLprbRL5JOVG+RGlGcdjXKGbnKeKN7UJRMMFl5NIRiJq72U= X-Google-Smtp-Source: AGHT+IFhfIrzcRrSB3PRVXEa7IfD64x3DWvrLyolPJso7AtMaTEliUXy1Di5c3Y9F+bGsvZnwecfpw== X-Received: by 2002:a5d:5542:0:b0:34d:1d09:f06d with SMTP id g2-20020a5d5542000000b0034d1d09f06dmr4990315wrw.13.1714821976417; Sat, 04 May 2024 04:26:16 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id p8-20020a5d4588000000b00341ce80ea66sm6013320wrq.82.2024.05.04.04.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 May 2024 04:26:16 -0700 (PDT) Date: Sat, 4 May 2024 14:26:04 +0300 From: Dan Carpenter To: Evan Quan Cc: Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Tim Huang , Lijo Lazar , Jesse Zhang , Ma Jun , Ruan Jinjie , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/amd/pm: Fix error code in vega10_hwmgr_backend_init() Message-ID: <502fda28-fde7-4851-b17f-4d48848955bc@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return -EINVAL on error instead of success. Also on the success path, return a literal zero instead of "return result;" Fixes: e098bc9612c2 ("drm/amd/pm: optimize the power related source code la= yout") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/driver= s/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c index 37c915d7723c..9b9f8615070a 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c @@ -924,7 +924,7 @@ static int vega10_hwmgr_backend_init(struct pp_hwmgr *h= wmgr) =20 data->total_active_cus =3D adev->gfx.cu_info.number; if (!hwmgr->not_vf) - return result; + return -EINVAL; =20 /* Setup default Overdrive Fan control settings */ data->odn_fan_table.target_fan_speed =3D @@ -947,7 +947,7 @@ static int vega10_hwmgr_backend_init(struct pp_hwmgr *h= wmgr) "Mem Channel Index Exceeded maximum!", return -EINVAL); =20 - return result; + return 0; } =20 static int vega10_init_sclk_threshold(struct pp_hwmgr *hwmgr) --=20 2.43.0