From nobody Mon Jun 8 05:36:36 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DFEA31F9A0 for ; Tue, 2 Jun 2026 18:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780423663; cv=none; b=YelcuP+dMW+rj15Anmz1nJEI3XgGm8LDm1vyolhH5VWZby/u2LcoLXdjmmnGOp6G162QDt8VMkSdA26vALtlTmNvFsv8INo5UhzauO4vBQ7QJIdEdjWkpgw4gJImgYXoxFumnQ51Nw54NlDQSDoTpQhUjlZo+5riF1TQEYxB864= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780423663; c=relaxed/simple; bh=KDP8InSM3yiK7fCFWwfl8LkylZRFQlKexHWuEF6Umes=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=f6GdXm6OtPXzdTKwH1EQM6UP6M/4XS9j5wBFnclfEqABssfuB/6B/E0skf2Qrz/NyZhgYUG74TKBoWTS3F8/mRv/uUpz2MAviuPb4KSpkfPdx93mU2tq85WidNS0z9LV0WLP8i0O7FJNUjcDow/YDtyKLEkfQI2svmRyYLg5GW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mAiSVCBg; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mAiSVCBg" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-8423f420455so1232249b3a.3 for ; Tue, 02 Jun 2026 11:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780423661; x=1781028461; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qrQo8hWu8mZTqQKgbvlcH4244C8HHHp4MKKXZ8fPbnA=; b=mAiSVCBgueGKZDZT75fi+Ogp77XBxpUjnXNGybqKJ/Gvjg37rdr9BhnSmssVbtsAER Ekep3wtzLRLKixpO3ZPAwBm9/Cahc2Bet5raWCCSqSXreXOhjXPVA0MrWE/gNuSYxIZT h9chCx3L6Le7XEkpxdKGl+zPKC9YzPNeRy166AUGfIv8N3He4uDf7y1jlkajMAQWai2M JltNf7irpX843W8rdM3sP88K0Dt9o6xAa6q/qUzk+HSSdEoxc+4iX6M7UGlme/+/EKNp DLSSvRnKTFrlUHN7/FzUTZYqcfWXbu9zkoiOks2V09BzDVHAsCajNGcfV4+6x35CqFMa gYWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780423661; x=1781028461; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qrQo8hWu8mZTqQKgbvlcH4244C8HHHp4MKKXZ8fPbnA=; b=MUVDurrSuQp+0T/zij+zBye1AHzgjK86C96xlyBcmmYbE6GQaXsZ7LRAJzmYTjx0Ae ekmF4vKrKJt5GrH5CIHMqzqoxF4wDTzc7U0w2ubRpWgrk2b9RKx0jXkQlfRgHUZwGih8 pKIaDsxRqiAgLpblmK7/gseIFQaqjSNcwIYiedAoQRJrphYwndAIWS+Pd+IUCuUMSAgC 5c8VHXQZwhcMbw3BT5x+VzAezk2zEjROzwPsYqIFGHZPT1Q1m1n1VYqESsndciMK9mB3 dBJLBLnFdeO7DbJ7kY+DsfBfRkLPVHIfzN1v8zvJQWJnV5dKtlvkwozxyQ5sPJgWWTh8 CgFQ== X-Forwarded-Encrypted: i=1; AFNElJ+lsThJRYqyQ8jMdC7aFNQULYo6URNxUDlC+5t+HZ9+NC0Mf1Sg50jlT5S5IaTtyz1EYHSl0s+h0y5xNpA=@vger.kernel.org X-Gm-Message-State: AOJu0YxOu+TZvi/1i3E4tnEYBS9Hux3m3SGt2WRnC85/crZG3CRgCcOv d7wFZUfYNIpPsylNh4OBEAE6ydNl71ISbmQN6z3WFzGJFe8Nt29C9AnS X-Gm-Gg: Acq92OHAmA4IYbER6Dq83PxIKbK16480PvwX8TYt5oY6ylhbcrK1wovZwdruu50uJfN qUo9TIzD2bnpj1g7dQCUA4KkxPcOksCTOzIRrdcd4jTeCRtHwiMGNvOb5A2JFczWqdvvHSvf9wH 09AAtMxSWLZ/BnglwVg9cQ+KSooQLL+om2SjDRFODsOYNnlEJy6upui4PyVmw2R37s51Mr1eJT5 T12UhxtOoh1iroxep0nAtHHDg9UOmm6bm1QY+4VrTOmPt1lWVORocw50WwywxK8pFdoH6v3bWGI XZ+TZrAt5bJFCjQKZPQoTifmeOfbO33yFgwRs7b7P4dz3HSyGHFIhxlF+yj+U7fMD7Y3x6spELq EaoAaYPUuCZvANtXfM5exWS/O40RrKBXBxNd9nUepUCL4YgYpDS+76UYyTLFjUjIEPoEV9tZJ3i xAIFIi30PRZX0EkPmrc+HIpLJt/Upk+CNiztc= X-Received: by 2002:a05:6a00:4c11:b0:83e:f5d7:6e9a with SMTP id d2e1a72fcca58-84283012f7dmr581457b3a.50.1780423661319; Tue, 02 Jun 2026 11:07:41 -0700 (PDT) Received: from localhost ([2405:201:4027:a919:e2b2:8560:26ea:4d1]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8428290067dsm445038b3a.53.2026.06.02.11.07.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 11:07:40 -0700 (PDT) Date: Tue, 2 Jun 2026 23:37:37 +0530 From: Naveen Kumar Chaudhary To: jstultz@google.com Cc: tglx@kernel.org, sboyd@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] time: Fix off-by-one in settimeofday() usec validation Message-ID: <4rikk44zew3s6577dugmx4jyblz7o5c57niuap6ct3td5yfm6w@gh7pcumg7qor> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The validation check uses '>' instead of '>=3D' when comparing tv_usec against USEC_PER_SEC, allowing the value 1000000 through. After conversion to nanoseconds (*=3D 1000), this produces tv_nsec =3D=3D NSEC_PER_SEC, violating the timespec invariant that tv_nsec must be less than NSEC_PER_SEC. Use '>=3D' to reject tv_usec values that are not in the valid range of 0 to 999999. Fixes: 5e0fb1b57bea ("y2038: time: avoid timespec usage in settimeofday()") Signed-off-by: Naveen Kumar Chaudhary Acked-by: John Stultz --- v1 -> v2: - Added missing 'Fixes:' tag pointing to the breaking commit 5e0fb1b57bea as requested during review. kernel/time/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/time.c b/kernel/time/time.c index 0d832317d576..771cef87ad3b 100644 --- a/kernel/time/time.c +++ b/kernel/time/time.c @@ -207,7 +207,7 @@ SYSCALL_DEFINE2(settimeofday, struct __kernel_old_timev= al __user *, tv, get_user(new_ts.tv_nsec, &tv->tv_usec)) return -EFAULT; =20 - if (new_ts.tv_nsec > USEC_PER_SEC || new_ts.tv_nsec < 0) + if (new_ts.tv_nsec >=3D USEC_PER_SEC || new_ts.tv_nsec < 0) return -EINVAL; =20 new_ts.tv_nsec *=3D NSEC_PER_USEC; --=20 2.43.0