From nobody Fri May 8 05:17:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6EC0C433EF for ; Tue, 10 May 2022 14:34:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344709AbiEJOiE (ORCPT ); Tue, 10 May 2022 10:38:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344440AbiEJOfG (ORCPT ); Tue, 10 May 2022 10:35:06 -0400 Received: from mail.pcs.gmbh (mail.pcs.gmbh [89.27.162.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B48342DD1F4 for ; Tue, 10 May 2022 06:54:02 -0700 (PDT) Received: from mail.csna.de (mail.csna.de [89.27.162.50]) by mail.pcs.gmbh with ESMTPA ; Tue, 10 May 2022 15:54:00 +0200 Received: from EXCHANGE2019.pcs.ditec.de (mail.pcs.com [89.27.162.5]) by mail.csna.de with ESMTPA ; Tue, 10 May 2022 15:53:59 +0200 Received: from EXCHANGE2019.pcs.ditec.de (192.168.8.214) by EXCHANGE2019.pcs.ditec.de (192.168.8.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 10 May 2022 15:54:00 +0200 Received: from lxtpfaff.pcs.ditec.de (192.168.9.96) by EXCHANGE2019.pcs.ditec.de (192.168.8.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22 via Frontend Transport; Tue, 10 May 2022 15:54:00 +0200 Date: Tue, 10 May 2022 15:54:00 +0200 From: Thomas Pfaff To: Greg Kroah-Hartman , Jiri Slaby CC: Thomas Gleixner , Subject: [PATCH] tty: Remove pointless synchronize_irq() in uart_port_shutdown() Message-ID: <4fe2d4a1-fc6a-c7fa-d884-5ebd01bebd3@pcs.com> MIME-Version: 1.0 X-KSE-ServerInfo: EXCHANGE2019.pcs.ditec.de, 9 X-KSE-AntiSpam-Interceptor-Info: white sender email list X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 10.05.2022 10:11:00 X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Thomas Pfaff Calling synchronize_irq() after free_irq() is pointless, the context to the irq is already lost. It was noticed while creating the bugfix "genirq: Synchronize interrupt=20 thread startup". Signed-off-by: Thomas Pfaff Reviewed-by: Thomas Gleixner --- diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_c= ore.c index 57840cf90388..b76e76e650ba 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1704,12 +1704,6 @@ static void uart_port_shutdown(struct tty_port *port) */ if (uport) uport->ops->shutdown(uport); - - /* - * Ensure that the IRQ handler isn't running on another CPU. - */ - if (uport) - synchronize_irq(uport->irq); } =20 static int uart_carrier_raised(struct tty_port *port)