From nobody Tue Sep 16 18:08:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34BCDC3DA7D for ; Fri, 30 Dec 2022 15:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231392AbiL3P3V (ORCPT ); Fri, 30 Dec 2022 10:29:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbiL3P3S (ORCPT ); Fri, 30 Dec 2022 10:29:18 -0500 Received: from smtp.smtpout.orange.fr (smtp-11.smtpout.orange.fr [80.12.242.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AF43A449 for ; Fri, 30 Dec 2022 07:29:17 -0800 (PST) Received: from pop-os.home ([86.243.100.34]) by smtp.orange.fr with ESMTPA id BHJope39eoBUEBHJopwrqH; Fri, 30 Dec 2022 16:29:15 +0100 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Fri, 30 Dec 2022 16:29:15 +0100 X-ME-IP: 86.243.100.34 From: Christophe JAILLET To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/bridge: tc358767: Use devm_clk_get_enabled() helper Date: Fri, 30 Dec 2022 16:29:10 +0100 Message-Id: <4f855984ea895e1488169e77935fa6e044912ac2.1672414073.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The devm_clk_get_enabled() helper: - calls devm_clk_get() - calls clk_prepare_enable() and registers what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the need of a dedicated function used with devm_add_action_or_reset(). Signed-off-by: Christophe JAILLET Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc3= 58767.c index 2a58eb271f70..b95c36ca660d 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -2022,13 +2022,6 @@ static int tc_probe_bridge_endpoint(struct tc_data *= tc) return -EINVAL; } =20 -static void tc_clk_disable(void *data) -{ - struct clk *refclk =3D data; - - clk_disable_unprepare(refclk); -} - static int tc_probe(struct i2c_client *client, const struct i2c_device_id = *id) { struct device *dev =3D &client->dev; @@ -2045,21 +2038,13 @@ static int tc_probe(struct i2c_client *client, cons= t struct i2c_device_id *id) if (ret) return ret; =20 - tc->refclk =3D devm_clk_get(dev, "ref"); + tc->refclk =3D devm_clk_get_enabled(dev, "ref"); if (IS_ERR(tc->refclk)) { ret =3D PTR_ERR(tc->refclk); dev_err(dev, "Failed to get refclk: %d\n", ret); return ret; } =20 - ret =3D clk_prepare_enable(tc->refclk); - if (ret) - return ret; - - ret =3D devm_add_action_or_reset(dev, tc_clk_disable, tc->refclk); - if (ret) - return ret; - /* tRSTW =3D 100 cycles , at 13 MHz that is ~7.69 us */ usleep_range(10, 15); =20 --=20 2.34.1