From nobody Mon Feb 9 01:21:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F58C41513 for ; Tue, 25 Jul 2023 22:24:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232753AbjGYWYc (ORCPT ); Tue, 25 Jul 2023 18:24:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230407AbjGYWWT (ORCPT ); Tue, 25 Jul 2023 18:22:19 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61E304C3A; Tue, 25 Jul 2023 15:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690323465; x=1721859465; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OBXugoeG43vdHjZJrGLYTbh1iSwz4x9BVpSGJUSumzA=; b=YlBRuxUWchhJ3vQRm49EZySMhox0lJ+MpGbRgRjDW0AT7U3nRlQAZebd 8+xndJfEB3s45Cp/5/2vwV+0bGZOnOUeCv0HKDwqFmx6HAbHSjMWnUH6T l5Asy/iX1ZcC6l4x6/hmL2XNTbZnpEf8evruWWxK60rO2Vb1+94q+DTM2 V89vOSvvR7CT8hOlQQZ+pL4UV9R8AS+oBS5UJLwVoa12qwrJvXdHo91Bo +jv4FAOWtqagUFwl0jri34E+qBXzUpLB1ulmWibCO9myps4aKsCHwmZky H9e4lrphMs2U2m9uHxaR0Lhu9LqRGXz67wqjn8gRNGHBeczZ+74yD7CVO w==; X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="367882661" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="367882661" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 15:15:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="840001868" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="840001868" Received: from ls.sc.intel.com (HELO localhost) ([172.25.112.31]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 15:15:59 -0700 From: isaku.yamahata@intel.com To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: isaku.yamahata@intel.com, isaku.yamahata@gmail.com, Paolo Bonzini , erdemaktas@google.com, Sean Christopherson , Sagi Shahar , David Matlack , Kai Huang , Zhi Wang , chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com, Yao Yuan Subject: [PATCH v15 084/115] KVM: TDX: Handle vmentry failure for INTEL TD guest Date: Tue, 25 Jul 2023 15:14:35 -0700 Message-Id: <4e1b23fd3a7d4ccb3543d5420b15741d0bd63499.1690322424.git.isaku.yamahata@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Yao Yuan TDX module passes control back to VMM if it failed to vmentry for a TD, use same exit reason to notify user space, align with VMX. If VMM corrupted TD VMCS, machine check during entry can happens. vm exit reason will be EXIT_REASON_MCE_DURING_VMENTRY. If VMM corrupted TD VMCS with debug TD by TDH.VP.WR, the exit reason would be EXIT_REASON_INVALID_STATE or EXIT_REASON_MSR_LOAD_FAIL. Signed-off-by: Yao Yuan Signed-off-by: Isaku Yamahata --- arch/x86/kvm/vmx/tdx.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c index 865d7ae30813..0dfd6ea07aa0 100644 --- a/arch/x86/kvm/vmx/tdx.c +++ b/arch/x86/kvm/vmx/tdx.c @@ -1171,6 +1171,28 @@ int tdx_handle_exit(struct kvm_vcpu *vcpu, fastpath_= t fastpath) goto unhandled_exit; } =20 + /* + * When TDX module saw VMEXIT_REASON_FAILED_VMENTER_MC etc, TDH.VP.ENTER + * returns with TDX_SUCCESS | exit_reason with failed_vmentry =3D 1. + * Because TDX module maintains TD VMCS correctness, usually vmentry + * failure shouldn't happen. In some corner cases it can happen. For + * example + * - machine check during entry: EXIT_REASON_MCE_DURING_VMENTRY + * - TDH.VP.WR with debug TD. VMM can corrupt TD VMCS + * - EXIT_REASON_INVALID_STATE + * - EXIT_REASON_MSR_LOAD_FAIL + */ + if (unlikely(exit_reason.failed_vmentry)) { + pr_err("TDExit: exit_reason 0x%016llx qualification=3D%016lx ext_qualifi= cation=3D%016lx\n", + exit_reason.full, tdexit_exit_qual(vcpu), tdexit_ext_exit_qual(vc= pu)); + vcpu->run->exit_reason =3D KVM_EXIT_FAIL_ENTRY; + vcpu->run->fail_entry.hardware_entry_failure_reason + =3D exit_reason.full; + vcpu->run->fail_entry.cpu =3D vcpu->arch.last_vmentry_cpu; + + return 0; + } + WARN_ON_ONCE(fastpath !=3D EXIT_FASTPATH_NONE); =20 switch (exit_reason.basic) { --=20 2.25.1