From nobody Mon Feb 9 04:59:35 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F31270816 for ; Fri, 24 Jan 2025 14:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737730153; cv=none; b=YFLuJ1TpPSQj9vcxmBAXIxFQOV9AePgr2FUNH0+LqEywrD90HuHMgjJqdZGsIqND9z2a2M0LyPsiAh0Te+ZJsVoryTjAZ8XTMudMWON8oe5kMMi3uEbdHJx1HA76a01sKc/i5bVrIyaFiiMc9qu2hyYpDadpo+4Bn1jBiNmy8f0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737730153; c=relaxed/simple; bh=NydxaqTP6EDkgEiMRsHp+UOOwmDSujay0sykB5esncE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=bUPJ6hlSyl9iR1h/bYL2UE50JvwmBGKmS6hO/bSCIoJ8Zyt120SV1WC6EIHfvHa+nsR1IKcllgvMnkBHJjX+fM5dByFfveLRDJclMJ7+mOjYz447UliHskZlouRurNc66XorluwKKwZeI3pQnSLC6vqDY7Yg7ViThUCby2W3NQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JfHvaCro; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JfHvaCro" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-436281c8a38so15660625e9.3 for ; Fri, 24 Jan 2025 06:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737730149; x=1738334949; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=eMkuRdm7dMRfIqCxtB5bKSUeXy3ZdBxZh7yMlRtwENM=; b=JfHvaCrotFxm9c1I7INCx8GEipqinY+truHUK5gAvBakqZ8GZSiBZMDKupviSi+tmJ Cfwhgeg96ASoMuR1tfwbJwhs0d2a/i62aOR2gGw9MmtuJFiFZVYwZ5/lGVrK6YR4GlMq Iq7cn2oMytPXCvavphWgsKfZgN6Al9npXznOteFrgZpwn5qXgK8AbLU92k8LKZgDyquG 7CEs3zjrEshn2s2kbTa0rGoLpV2JJ4HLEAhUiHwoGr8kcOOOQp+eDU2TQ4qAjapqSb0z 4HeqxgPYdFd0yUKVmK0PfHhp+VuZEMkXaeC8M9GlTglK48p5HwK+kj+Zeenk3cpsSuK1 RjhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737730149; x=1738334949; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eMkuRdm7dMRfIqCxtB5bKSUeXy3ZdBxZh7yMlRtwENM=; b=M88uQRBPd6oWfyPi9UtEdt4zmdaKIoVbCg4tBaa/nG5Qord2fUMJYmqo6P1lzBTlZc x8s/epTfX1cTf2O+IQdUUewaq40269YwFzrEbGTSVE8EPBZraPgbMKrIjXtpGLe7WMyp CLLLkOlfW63BZwGUvlE4pobj4iHRV07B+ZuxQu4cuP0e2qpag2AJzAuGiy0VAFMNcXRX 4VK8zQYWTKSnu9vXJ0MNi7yUjV13MDue4yYj2B/MQu3zgXEz0BBvL/qH00cYuSf6GATb 7nHIEHFsjdKT+LcxvuXXnwUOt/49lyBDgC9rXHktVwmpLJvElp2s0WXc270cZ4t+hN7G uufw== X-Forwarded-Encrypted: i=1; AJvYcCX6Hrc3FKE4sWzsU9e5QLsAujRbtHR5KOMPjKpYnQHW4SGTz05N0soc1BDIrqimky7KFAViRXoOKuKyWpg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6jI8bcyOhktVoqAcKqGo80wkLV8P2YeVys3eOKvj53VNlDv2d 8Bn1OOns6HjiaalG61G34mhTe9ZAtXYJkPlkqzmqhk2CwFTJ3ZihmBkDxOMiLuA= X-Gm-Gg: ASbGncsQ/cUxCHMzrMfO4yJbezr41XIc1EpY+gbDEIbJkJlJ7YUF35qe3B5wiiQk6ig s9YKNRnYOD2Kq0r5vvNQt4RC0UqGOHd5ffVPDX9CleJol5HiXv4fj/G8MoKPxvzoohoKhl0ja8S /pTPyps9UyZh74C7OznDSPBfmwiXT0T4p4xU5WzKZKoCc73FQcr/zqF/kCLvHnWQfiIHZLcnXA5 pAcdvL9OIT9kFRymRFb0UsYwVzwXo2KsNzC0ctJLbhfoEfpMnrXVdhpRo7q0xCwB7RR4uY8UAr9 Qc9pxDxOyg== X-Google-Smtp-Source: AGHT+IEgUTZS8mCn7dY7aS1e3HW4uNtkQsxfIiRO3BnkLr8VQ2g9RvGQrurzRlcy0FFiD4+EtIbf7Q== X-Received: by 2002:a05:600c:524c:b0:435:306:e5dd with SMTP id 5b1f17b1804b1-4389143a66dmr264487745e9.22.1737730149323; Fri, 24 Jan 2025 06:49:09 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a188bf5sm2964758f8f.50.2025.01.24.06.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 06:49:09 -0800 (PST) Date: Fri, 24 Jan 2025 17:49:05 +0300 From: Dan Carpenter To: William Tu Cc: Pravin B Shelar , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH net] net: ovs: prevent underflow in queue_userspace_packet() Message-ID: <4d6d9d9e-b4d9-42f1-aa78-1a5979679b2e@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If "hlen" less than "cutlen" then when we call upcall_msg_size() the "hlen - cutlen" parameter will be a very high positive number. Later in the function we use "skb->len - cutlen" but this change addresses that potential underflow since skb->len is always going to be greater than or equal to hlen. Fixes: f2a4d086ed4c ("openvswitch: Add packet truncation support.") Signed-off-by: Dan Carpenter --- From code review not testing. net/openvswitch/datapath.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 225f6048867f..bb25a2bbe8a0 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -477,6 +477,11 @@ static int queue_userspace_packet(struct datapath *dp,= struct sk_buff *skb, else hlen =3D skb->len; =20 + if (hlen < cutlen) { + err =3D -EINVAL; + goto out; + } + len =3D upcall_msg_size(upcall_info, hlen - cutlen, OVS_CB(skb)->acts_origlen); user_skb =3D genlmsg_new(len, GFP_ATOMIC); --=20 2.45.2