From nobody Sun Sep 14 08:39:12 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1478C27C76 for ; Wed, 25 Jan 2023 20:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236269AbjAYUJJ (ORCPT ); Wed, 25 Jan 2023 15:09:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236255AbjAYUJG (ORCPT ); Wed, 25 Jan 2023 15:09:06 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC54135260 for ; Wed, 25 Jan 2023 12:08:43 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id r2so18190805wrv.7 for ; Wed, 25 Jan 2023 12:08:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e3159gyzRYnyKWw0j8EF0nhK1aLDWnlIYkjwkYEv8/0=; b=qJ4Uwx/LpirhfkkhaNbEw7UgnQvUkGfwnShlH39beNasN0JvKq0Twaon7yywI92r5w wcmcqVKrrgD2ZIb5lHH2sRMo+KPkUEcDMCLfYyfRVik0S6NyIFIdM98kOGTL/b8lWlY4 vq/ieZXk1x//6+O9bCm1T7uP2Ib9hv8ha1+cn/ng8bd9kkRDj6X/Klh7CH2hVutweWvv q6zf4VzIYK/O6lJ575FPZZRVya7ujTLCpD6/MM8D7ypP0Ynn/OEIWGkaANA9Zq2KLiVo O/FuqEND8d6YYYzOqdn/qOKUQ+V9DZvgFTsicizungZ/ZHqUGT12+9Xl3VAAR5ymyyKC 4tdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e3159gyzRYnyKWw0j8EF0nhK1aLDWnlIYkjwkYEv8/0=; b=H/eRjcd2ooczv02kSqszFzNsU6tdt/phlOKjg0egWEUsPeGJxF3JoMEbkJwy92KwA1 c/+z+iK/2vsxZ8IjxrQZuGDIFtS/XSQNxmL8Qc/kufPEc677YH1xeRcDole5wEhSVqPn D/E/qdz9F8Qis1umIvsJLpBaWV0JpfC/xi5+SzQiGRM4nAYO+lie2cUCAjYklzT/wSbJ nEoZ6f0sjnHYGTqXPkOETTF5hhq0GT2InDPWkkVcoJF2xEzSc715fns4AVDhj3pakPks VJESraNyIM3im6GYX5rn3mqU2gKxyJIz+1yGu/9GJ3Hy2PkD8TNi2/lo5cXEoIIi2UBJ tqvQ== X-Gm-Message-State: AFqh2kqurFtON2I6/gwuySlmyjk9lMNWRPNwtFup/JtXrfpWUMMn9BLx LLmGAyBrsM/Zg1ce6tA+Az50sqJ//KQ= X-Google-Smtp-Source: AMrXdXvtUFtCFxHlZsDC0OlmrcZnQBmN47kgB/Rp9Et3pN+lO9A/kzbf8ThueNXsV/QYtezuFBh5Kg== X-Received: by 2002:a5d:6b0e:0:b0:2be:1672:748b with SMTP id v14-20020a5d6b0e000000b002be1672748bmr5353853wrw.0.1674677322437; Wed, 25 Jan 2023 12:08:42 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id x10-20020adfdcca000000b002bbddb89c71sm5121166wrm.67.2023.01.25.12.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:08:41 -0800 (PST) Date: Wed, 25 Jan 2023 21:08:40 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/11] staging: rtl8192e: Remove unused variables rxcrcerrmin and friends Message-ID: <4c791fbb3559ce15de60b7bdcabbc50b0ee9adb9.1674675808.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rxcrcerrmin, rxcrcerrmax and rxcrcerrmid are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 10 ---------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 9260d308e68b..e9273dfb638e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1812,7 +1812,6 @@ static void _rtl92e_update_received_rate_histogram_st= ats( bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *s= tats, struct rx_desc *pdesc, struct sk_buff *skb) { - struct r8192_priv *priv =3D rtllib_priv(dev); struct rx_fwinfo *pDrvInfo =3D NULL; =20 stats->bICV =3D pdesc->ICV; @@ -1825,15 +1824,6 @@ bool rtl92e_get_rx_stats(struct net_device *dev, str= uct rtllib_rx_stats *stats, =20 if (stats->bHwError) { stats->bShift =3D false; - - if (pdesc->CRC32) { - if (pdesc->Length < 500) - priv->stats.rxcrcerrmin++; - else if (pdesc->Length > 1000) - priv->stats.rxcrcerrmax++; - else - priv->stats.rxcrcerrmid++; - } return false; } =20 diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index f91a6f7a4e0a..167c4aeea44e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -183,9 +183,6 @@ enum reset_type { }; =20 struct rt_stats { - unsigned long rxcrcerrmin; - unsigned long rxcrcerrmid; - unsigned long rxcrcerrmax; unsigned long received_rate_histogram[4][32]; unsigned long received_preamble_GI[2][32]; unsigned long numpacket_matchbssid; --=20 2.39.1