From nobody Fri Dec 19 19:17:16 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 717181F3D44 for ; Wed, 8 Jan 2025 09:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736329049; cv=none; b=FDknipaRbbBayD6kZSvbDI+74IQSOiFemRXJ7blJf/u969RMovnp2O/8U2dRXp04rZFAXa1PRzFzwrObRpfNISIFNshDnbkSPy707g76UYZX0E8QF3SAAZjI0iD1f7WTiGXCyJQjVpfXynrAfx62bZl+AuKyrnH8ydBnbsd2J+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736329049; c=relaxed/simple; bh=tN5okRrYoBGpX5AHsBFQyTsnw6M+opkwftx20mNQmpg=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=ZvzlecJIKqBCNgx8TDJjt9GQT64bltX6ShYnxO4DGQ+DD/ZsakiLGnyvu2+i6kWIbUSFwe0km4Gj6tbAUwh/wnA2K4XOfNvCs48F6b39sUJCb5SA6rjTx4jjpKbZVjgMzhoQP/woh5pgKp/I8hUbWWGEBPmqNR6tc5qUU6S0taQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WbvLTg1b; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WbvLTg1b" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-38a25d4b9d4so6278499f8f.0 for ; Wed, 08 Jan 2025 01:37:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736329046; x=1736933846; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=G7qr+xH74BUjb8c6klWG/dnkZsYFFWd8nuIpiiYr2Do=; b=WbvLTg1bOmHUScDAg6n3Jcf72LV0C4F5BaYbkrNhVv4Etq9SwL2YtmmHXcKRsSC9iO DjaNjiCcM72pgH47QUAfRfTDrupjZQVAfjogC3S+8m4AfHjSHbo/LQpRew+zCbLEdC/m BKKmQCehxIRxSwXoZQLaydQ/v5m1yEcuwIrBSeR62YjD2UVU7lSt5eAryNusF669Erii zFigFZO2fUso82hFFzgRDfOpJSvRvNSFhh9uG5X2P+hnda5umM0BXPxsAWpDMXJXFU5x TfqPz7vhHT5DG5ufWAMLZvV10qVS5i3qKCxWEuLYZOBky7giI4ybkruhZyW2UN1RE1T+ Kmlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736329046; x=1736933846; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G7qr+xH74BUjb8c6klWG/dnkZsYFFWd8nuIpiiYr2Do=; b=p/D5JYOvdTDH5LgtgBufOj9q5jkMnWEfMI2alq5Y4BjQNSMHeqhMZMmHYyQq0O0eME OmasgWXOuJJrNgbuvJ3mt0LwA9rzpVAiPlB1CcaPTFvs1nu1shOYcoUEeHHclhWMBo+9 QuIzmQ2gmdOlkpGSMoRa12ivk7qu8BY2k4P5Ko2misdrPLqFP6a3BZONFSqE0vTYr8PS hjEP3gUxZrc0jkbQchu51OSCpFD2WsWOPNsEA4yE2pebRw9QteatlCFMqwmr3yTvjSSY WOCPh5fjMQgSpSMxPZcUmJXjGTrDeQjhNW4xMrsu7XdK/anNgym2G8VTsZ7GF6lwZSGz 4+Vg== X-Forwarded-Encrypted: i=1; AJvYcCUxDq19eVDdylNpNea5yX5S9Lja1BjP06V2XmlLthtyJj6EPqmLVTfzz95Qf/H5nRMMSJd3nA9Npal4LGY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5wDVHvtQKqwelqGgsm/PYctE5u2FvJprkr15EMHcHdhV0yAkF 8D/fLYzhBpRDimhnVK0cklREFBqYXPspFXGy+A5uvRhC6ogAAl7tEnIwFD2YvX8= X-Gm-Gg: ASbGncv2dgfJE0Nk9up97iTClYAIEqP/Il0S33LWhumuHbO55wH8h1F0wPhDMPRgDSk Qa4eUnmIrW2204KYxBvexI/aC7vgzIHRuGhWgodouRiROIgRFKq9dpdnaGhw7rwcWCKLVzlR24t 3m5jSU7yy/VDKg8UmJzMLm59kzhMIr+2HoNpMXwMl8cLUGJnghcRK0yeXUr9ULirbFIhG2JUGyg n1OgTlbyXaTeNemaTkk1/yyeH0/j402r1JzWvjDnq6RNpUPA+HKf1Z1Fc3cMA== X-Google-Smtp-Source: AGHT+IErnSBFhYxUJzsggddRVs3RbCystP6n1/ZQ4IX9uvuRMpjYqQBmS+F0oGJazwIWYP0YaTEAwQ== X-Received: by 2002:a05:6000:18a7:b0:385:f220:f798 with SMTP id ffacd0b85a97d-38a872c93eemr1482892f8f.6.1736329045814; Wed, 08 Jan 2025 01:37:25 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8acb17sm51765404f8f.97.2025.01.08.01.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 01:37:25 -0800 (PST) Date: Wed, 8 Jan 2025 12:37:22 +0300 From: Dan Carpenter To: Vasileios Amoiridis Cc: Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] iio: chemical: bme680: Fix uninitialized variable in __bme680_read_raw() Message-ID: <4addb68c-853a-49fc-8d40-739e78db5fa1@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The bme680_read_temp() function takes a pointer to s16 but we're passing an int pointer to it. This will not work on big endian systems and it also means that the other 16 bits are uninitialized. Pass an s16 type variable. Fixes: f51171ce2236 ("iio: chemical: bme680: Add SCALE and RAW channels") Signed-off-by: Dan Carpenter Acked-by: Vasileios Amoiridis --- drivers/iio/chemical/bme680_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme6= 80_core.c index 26eb0fa77a43..9d73fd2cf52c 100644 --- a/drivers/iio/chemical/bme680_core.c +++ b/drivers/iio/chemical/bme680_core.c @@ -879,11 +879,11 @@ static int __bme680_read_raw(struct iio_dev *indio_de= v, case IIO_CHAN_INFO_RAW: switch (chan->type) { case IIO_TEMP: - ret =3D bme680_read_temp(data, (s16 *)&chan_val); + ret =3D bme680_read_temp(data, &temp_chan_val); if (ret) return ret; =20 - *val =3D chan_val; + *val =3D temp_chan_val; return IIO_VAL_INT; case IIO_PRESSURE: ret =3D bme680_read_press(data, &chan_val); --=20 2.45.2