From nobody Mon Jun 8 12:14:20 2026 Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 385D23A8723; Fri, 29 May 2026 09:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.206.16.166 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780046454; cv=none; b=TNRz2BmfoimqtdVaqmsqNyG++NuH0oaRsEQcJFDT+ZINDJgmpFjGileavzahJv5+Y0XmQIdFmiyDNJSB6YD0Udus1mh14/wFufdLZr6jPyKO8o3fedR9w2lgE57Hm6JFO8pvZRhCDCZqE6ri2jsA7tc0BQV55MUzDOwvfq2h8ow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780046454; c=relaxed/simple; bh=vklZS+F0UdfrHjMTBGchkgs5NC7WdZIykknOrYnrgD0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V9xpKq2YVqTrR9NikTti3cV9PESHIGu9ahFcYGqThdPYxDYi+zh059FTC5T2QAJ6Xk67u69LenZe6P/1zlzI+Y0DiHFKaywwKOmiGowAgsgZyoHdvEXOGHRQJoLULvgDd8vzBWKYijyqlTnCfS1WyPATJFHEEMOf58SgM/GuZGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=oXBNPcL9; arc=none smtp.client-ip=54.206.16.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="oXBNPcL9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1780046410; bh=pwZkHXqKqxkxLcfcppEkvJjtNsDiBPN5huDHZl9Eqqc=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=oXBNPcL9l43i+7hjlYwOT9Vzcu9sz183zszbRotKOezN1hoUFJa9r9YVXdtW5p+ai irhp5lFv/99r8V34HAdpw1qvEZBr0xNuofjaW7NVA0Dnpw6g1YXmZdxwFynCgKHTsR VlVcnwI2F+cSqfAKfITK+OmSwv7MyPvzGmUL5dk0= X-QQ-mid: esmtpsz16t1780046399tb2a1703a X-QQ-Originating-IP: CJUn/onq9sVAsdQEE4Dgz4kIeQDPJjAROSdjJs85g0k= Received: from PEN1097 ( [61.183.83.60]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 29 May 2026 17:19:57 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 8377059717619170860 EX-QQ-RecipientCnt: 8 From: Cheng Nie To: sj@kernel.org Cc: shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@uniontech.com, niecheng1@uniontech.com Subject: [PATCH v2 1/2] selftests/damon/_damon_sysfs.py: fix memcg_path assignment Date: Fri, 29 May 2026 17:19:48 +0800 Message-ID: <9EAB27169F5D0F3D+20260529091948.1702421-1-niecheng1@uniontech.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <4CDA28DC581FDCF8+20260529090845.1696845-1-niecheng1@uniontech.com> References: <4CDA28DC581FDCF8+20260529090845.1696845-1-niecheng1@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: esmtpsz:uniontech.com:qybglogicsvrsz:qybglogicsvrsz4b-0 X-QQ-XMAILINFO: OMCYmVIWJe6uos5vFmn6Hv3b1VLW0y7mvdHhjV+Aqw2safJnkJceOqCk 4I0tpRTv5bjYZBZ0J/7EfDLyU/doSnAM6fNBLs5lD+UvveN5+LV7dHP5kZ7sC0JaJMQbSR8 BcUezDcrK8W0KPMFImStnIAynQ/3XgD+Md3caTKZ69IfUoDSR2YqHXKhCM4a69MmUUH5LQh 4LVn/TSDjlBkvdJ1X6457D5Hg5WKDrFX9dumxehSZUffMpvfiIjJTKyGC/MY57Dl5wdxICA lI/pCX7AwPtCHSE0CjStDl+9Eo/0oS8UFPJbMxYUPElM1wAAt6+pXTleqEySweD3pXtPJyt +b9TgHC1QJRha4xdbTWn+GyU9QQsfuCTmuDxlxljnmfcLcFMm8/X34po+jYA7HX9Z7gLClE ZRaY82RsQvEgckplIQSMYCsOw1DvHa983i51pGfKTqH7Zu7OTz3L9bRvNHcTDH8DqS7JgX+ AK+i59hiR0/eSA8lNcWN3vCNSiSNCHHxfhAKJTUmRaqafeHEIGg1qKpdeXVLpOuorj2LVa8 PRg/gr1P9W0YaKYi/KOIWW9sLE4R6E6xhlYMkjWMMMsBP1rsaw6p89fN6i8HXUyeZHfcnRF wSiPMr8yCkJopIX5bGm9WpTwlF1fTJN+ILkQpqrVJdi2Upyf2Sh0eB3C+EG53raG8WApa0M 6BnL6IFAfxsTYmiIjE9zYw5ZPhRlA01lwnwqJK313E/XDEejCjvLQ52QW6062nM+dWKJN5M +iOvqrT3bHmiRbAkRbqb/OSZ9xmXsbZxZN+Hp3ECLDK4h92Ti3Aj68A+xQk9ybM7dQiwAas BBzCCXoPl6u2zzsW6VOYiy5hrZiHnK3hNfrbFmuh9mM1uHXwtMsPacDRwCj8LVFbXkUb3nx 8MlIZM9wWPP/+DGnT1+DXx5o8E0My+Sga6TE1R4HHpsFPKM+m6pV9lCTZSgJZuOOQ1tVOed 1Y8xMOntoVlnKbVlXVxZ32eCpwNzikHJg0JuQvclFfep9Tvf+Shg+2zoYC1s9+U6tmJSYge TBPrcqFwJmw5MJcd6yZ10tKS+nFO5MVhDG55HVg0as9cstELSGrcrr66GbHNk= X-QQ-XMRINFO: OD9hHCdaPRBwH5bRRRw8tsiH4UAatJqXfg== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" DamosFilter stores memcg_path for sysfs staging, but the constructor assigns it with a trailing comma and therefore turns it into a tuple. Fix the assignment so memcg_path is stored as the intended string. This makes memcg filter staging and follow-up validation use the written path correctly. Signed-off-by: Cheng Nie Reviewed-by: SeongJae Park --- tools/testing/selftests/damon/_damon_sysfs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/damon/_damon_sysfs.py b/tools/testing/= selftests/damon/_damon_sysfs.py index 8b12cc048440..43075892215e 100644 --- a/tools/testing/selftests/damon/_damon_sysfs.py +++ b/tools/testing/selftests/damon/_damon_sysfs.py @@ -271,7 +271,7 @@ class DamosFilter: self.type_ =3D type_ self.matching =3D matching self.allow =3D allow - self.memcg_path =3D memcg_path, + self.memcg_path =3D memcg_path self.addr_start =3D addr_start self.addr_end =3D addr_end self.target_idx =3D target_idx --=20 2.51.0 From nobody Mon Jun 8 12:14:20 2026 Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A77E132692C; Fri, 29 May 2026 09:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.194.254.142 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780046539; cv=none; b=ERoBQmk4wPCjEv2LlBM11AivJwj2X5d1HCJETFqvFjQ0LLoFqbkL54f1tAhoZYpkHBuyd/HFR8gE+aWUgwZ2MGlcyj1ZR8afOgnGHDZrjp0LliDCC2lZqixLv2JrretkwSe5Wb2duzy6NRtHGI7jAgUN0HZh9jN4vlNoTrygYn4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780046539; c=relaxed/simple; bh=CSKQ1mUJep3xo5dtlv6+IPIZTxEkOQs4c5ARJks54ZI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Eflk14NAPqvnarJNnWFo0x+UMxrukYr9ZxhvDZyESSrsOQHNAHPwy3YxZubs2j8mF47H/1xITDy8sXOGTQnsId55dHfnPi1CskwUSvAFHOHOi6qC8R3xaI9sZeSUR4gtSO+SX3FGmJCPXk9RZ7C201yMhB6HjUKGQtU1uOj6ogA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=ZLt3VEXe; arc=none smtp.client-ip=18.194.254.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="ZLt3VEXe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1780046507; bh=HylwJTKDEjdoNKKWZ6Eg8/02B5viIR23i6MNlY5fspM=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ZLt3VEXe9hzaPs8160QBczBg7KZjf8Ju/zdWS4Mf0LsT8wUAVZiPSJ9MkFhLUdcbA szQKyto/d+wtOM96/9K1E8fT1XvokuZHQNnFGRUl62EkH414gR/7/J8jnD8jc7FY8Z xAdLZdEw3SSvXSe7jLceOtX0oOcMocUr5w7xuMuA= X-QQ-mid: esmtpsz17t1780046496t9cd9bc45 X-QQ-Originating-IP: 5UBRpNotQxnNW9HKXjVMAySgKETLGGMgdHkYNKWLoeQ= Received: from PEN1097 ( [61.183.83.60]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 29 May 2026 17:21:34 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 8261288960962780039 EX-QQ-RecipientCnt: 8 From: Cheng Nie To: sj@kernel.org Cc: shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@uniontech.com, niecheng1@uniontech.com Subject: [PATCH v2 2/2] selftests/damon/sysfs.py: validate memcg_path staging readback Date: Fri, 29 May 2026 17:21:31 +0800 Message-ID: X-Mailer: git-send-email 2.51.0 In-Reply-To: <4CDA28DC581FDCF8+20260529090845.1696845-1-niecheng1@uniontech.com> References: <4CDA28DC581FDCF8+20260529090845.1696845-1-niecheng1@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: esmtpsz:uniontech.com:qybglogicsvrsz:qybglogicsvrsz4b-0 X-QQ-XMAILINFO: M3Y38+foqXFqd39Vo05m7qqe1YkKOZngwhy+l2ffA7pcW6jfMqGpJjzB 3KmYSq3A63PwrFSX+bWRH7E4IlAKxox0ib9LBwEdqzvyODozryMhPpk5MNjPfHeUuDZ6rHi KTB9h3s556hS+7ywgvL3Q+SUi2Z7TgzKtTHF3HZNfzhsVfjCzCskxvwkV/OQWFOsPcV/ybO d7NHAf8Ue2LGas9wxBKrf3iWfHbPorjwYF8gnGcgQRCBMIyGe3ap3G0sDlfsXDsZW0uI9Z8 C/xObQMV07FjhlS7BqWNG9bHYNPuCMGkWWM2yy45SXlfuaSgwoAXjFNkWPZfRvHhBIuLKXw R1NC0mpRp0ur4cvmHK2gqoWCFrhcWz/G6cBAXiPevB+ICiaT/c2QNsvMuQ1ryEoN5n7Y8Ll QlkghK694W0gnQgG+Fz5iwE1am3Ny8C9rc/4/nyMter/gTEClCi4NHtOJUa9ppyH0Jdnh+t l9VaACBXcEUZ8nAWfwmS3yQeJAiZsCVlc6bV6YusJNo/1igYs4XXUAi3nwR433/1+i28AwF AVnMtxME1o4RyFIW7hMZI2fOJdl9o7U9xdZCQkVNUcwjVElCcEm1hBz411hVqJd33flinXL TimRNiFfH2fqZndp8zSkMsZ9jIV5d3z5mDuWx03dGm52WRUafQVEi/E6TubQbDHUMBDPzxc IBAaVYHQmZckLghhRKt+en2+yo1FrCSRFnXVrs8S+21B9BObKQ9BqDKCsXkgeGPtswVNN5G cXzJspMyVZ8xIpNGBgJuDWrOsPWJFV/KNvOuWd6AWRjKM3hdSyS64frQMf52DL2kKjQMzV7 C3s4ehOn2C8ANakVyZ2qIthsibmMvePA7otnh4B0ITsdEizhWBb1eK7ifzDCcByW0oF88ga /Ohytup8Bv0eKcKJYPe/9wD98ktSguhgteUKUQ2Bc5myTP08PosLb3oyzIvLG7nbP1Hxfnc AqBFdqmbwONJwdBz0e/Sl0Eyzma9YyoLMTo2VUKlmDG5yx3ljS1ZY0tKT8PH9DwQfnE0F2G ITQTeZlAxfojIwPLaxq03D3J2551DlMj4PGrU3+wuMxVH//YaysUqEb60xn4oc9DSgMMLZQ g== X-QQ-XMRINFO: Mp0Kj//9VHAxzExpfF+O8yhSrljjwrznVg== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" Add a dedicated test at the end of main() that writes memcg_path to sysfs and checks the readback path. Validate the readback rather than a derived memcg_id so the test stays focused on DAMON sysfs behavior and avoids depending on the local userspace cgroup mount layout. Signed-off-by: Cheng Nie --- tools/testing/selftests/damon/sysfs.py | 39 ++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftes= ts/damon/sysfs.py index aa03a1187489..0f20bc9c46b7 100755 --- a/tools/testing/selftests/damon/sysfs.py +++ b/tools/testing/selftests/damon/sysfs.py @@ -250,6 +250,43 @@ def assert_ctxs_committed(kdamonds): if ctx in ctxs_paused_for_dump: ctx.pause =3D False =20 +def test_memcg_filter_memcg_path_staging(): + global kdamonds + memcg_filter =3D _damon_sysfs.DamosFilter( + type_=3D'memcg', matching=3DTrue, allow=3DTrue, memcg_path=3D'= /') + kdamonds =3D _damon_sysfs.Kdamonds( + [_damon_sysfs.Kdamond( + contexts=3D[_damon_sysfs.DamonCtx( + targets=3D[_damon_sysfs.DamonTarget(pid=3D-1)], + schemes=3D[_damon_sysfs.Damos()], + )])]) + err =3D kdamonds.start() + if err is not None: + fail('memcg_path staging: kdamond start', {'error': err}) + + context =3D _damon_sysfs.DamonCtx( + targets=3D[_damon_sysfs.DamonTarget(pid=3D-1)], + schemes=3D[_damon_sysfs.Damos(ops_filters=3D[memcg_filter])]) + context.idx =3D 0 + context.kdamond =3D kdamonds.kdamonds[0] + kdamonds.kdamonds[0].contexts =3D [context] + + err =3D kdamonds.kdamonds[0].commit() + if err is not None: + fail('memcg_path staging: kdamond commit', {'error': err}) + + shown, rd_err =3D _damon_sysfs.read_file( + os.path.join(memcg_filter.sysfs_dir(), 'memcg_path')) + if rd_err is not None: + fail('memcg_path staging: sysfs read', {'error': rd_err}) + assert_true(shown.rstrip('\n') =3D=3D memcg_filter.memcg_path, + 'memcg_path readback', {'shown': shown}) + + err =3D kdamonds.stop() + if err is not None: + fail('memcg_path staging: kdamond stop', {'error': err}) + kdamonds =3D None + def main(): global kdamonds kdamonds =3D _damon_sysfs.Kdamonds( @@ -356,5 +393,7 @@ def main(): assert_ctxs_committed(kdamonds) kdamonds.stop() =20 + test_memcg_filter_memcg_path_staging() + if __name__ =3D=3D '__main__': main() --=20 2.51.0