From nobody Mon Apr 6 16:47:58 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56BE9226D02 for ; Wed, 18 Mar 2026 19:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773863512; cv=none; b=Rib4jmhQx9oE+VcAmBw3yxVv5rXMV+DY1p2DtBrIFve71D4JckDteo8eAMytwNriDX8g+3mnlYDtvJ4CAyTzK5bfTlGLgqlIZR97xlC6Nkxp9QQSzUn4cO00sQ6sKcchBrzW621NC1GLn5nRNixz681roVY8ryqzzJfw9gTnq/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773863512; c=relaxed/simple; bh=tqPRzMtHOIZLjWEVwhds2hAjNGs4sUGuk1r2OLRtmBw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rFEZhxkeD/zcfVZxVqEV1ucKDu0BhWXiZj/Hs6J5RTONIlTv8DLo7XxDW8c3sA1PJIY+HRgo+PPam/QmIfIlu/az1UrjVQ0JWQ8MbGiabgfPXgDCxAlaRuG2HXQ+/u25R+WJMd4ch63aBahcit+YWjjRQ/nwCsNUVhGvYDw9tP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b=gP+aopfS; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b="gP+aopfS" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48628ce9ab5so2750615e9.2 for ; Wed, 18 Mar 2026 12:51:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20230601.gappssmtp.com; s=20230601; t=1773863508; x=1774468308; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9diUOv++hsh458hLzcUOWkiK9bUzXbhl4P/hLWU7Ycs=; b=gP+aopfSXKRgqHiewyipTkAY++67j2AbebWUQz+WNkR0EWQoylFASJBwiEyaIJWpJ1 GQ8+Ad8wQD2qPOc8S1d6Qi91V2AGFH+MfY63Z7e62mnVuX03m5Q/JZnd0yTTpePIxJsq UxpSO/tje30H9qFPEDqf2hbHYJ5AmtueoYi3xasH6AgNbhtI01i+mfUW22yezsOoRVXs lrrWhosPSgi4vC5vHe+tErVRrdHCAUj7h3e6cFfBbUmYymwRnYcWAndXdK+DAoaZjEhE lfSxJSnD9+zz/Oe/zDM8r5ejmgRd0x9nOcGPHeyKUHJyQYt3mRF6whd/20qEPHgZEBxT TlEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773863508; x=1774468308; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9diUOv++hsh458hLzcUOWkiK9bUzXbhl4P/hLWU7Ycs=; b=X5bgE8+w9TTOnu1QYsA57mdPd3FZfIgn0tCKxLSIMShGYR564SLGchwTG9s1h+wxx0 uIBAFUx6wCfpi1OaQBeGR99soLLjxocDQtCzcu58si4F96s465b1M3iT5UC0VMcR4DY4 UAHkJG7I5atWWqyy/O/0KHfjYI9yAVj8IyWf1e48SbkbXTWrPgnCsc2Q/UgjVTpe3958 4BYbpkXOaGfG+FMNUSU1KdcRQnXwWRhJ4+/313cZPuYB0o+3h76L9iBJeMTCo5GehGDI mXMljcz8eRxgFr78EVN7zWYseiC8yT696z0eKXdaZb5egj6pdHYqddehR2zlki/5lnK+ T0tg== X-Gm-Message-State: AOJu0YzBf3jgh9AeW7/6l8p10LFsuuzHJqx+jJILV5z0zhvxERYVAVHK JbaTXHLAlaHqgnQYOoT94UcFuvMT0dUmiQLfhwBOof4+vy4XbHrT2g2FJlV1VDbKlP7jM1tbXF3 TVtNv6g== X-Gm-Gg: ATEYQzxFo/H5Fzw0yzeNK2zyyV6HNICQXEoxOjyuwt/4s0mUYfFaNP8fBlBMdp7KozW i+05hyV9qk/VgZ35QH2MbLGTV9oEg7GxJcptoR/Kpkd5YEwiU5P1Hrf7h1eW7svvHIvxavyQqaZ LkQltdoBwwK9NjgmtbBOsIWnkY+89QdkIQHMXZ27Im3v81CyqlfRorOVzOxpXiyar/poh/+YV0B m76ZkH2lZbkLYlBehyokuTc4WbVdUtLGrbGtaM3KCBXTr9OZfwuwbhU/6+wFTEsSbW70h89TUXz WN9VAhMnmN/hFpWpaNzc0JE9WVGCn/yNEzxnfVhXiQJp2BSOokHH5yNnRVMVA0kmxFZKVjl/rnD 1pFSllyjWMOVGfdYDilB/qbZLSLSA/ceJepKrKAt5qEVZe7idl9oW+LLGJKNO9Tq4uGkaIGYKn0 bgPHp5FSR/PujdvRSTrySse7FfZIDAGDcNRFtNT3QHaYp/0u6S9gU= X-Received: by 2002:a05:600c:4710:b0:485:4526:ee06 with SMTP id 5b1f17b1804b1-486f44375aemr74930775e9.11.1773863507756; Wed, 18 Mar 2026 12:51:47 -0700 (PDT) Received: from starbook ([217.155.46.38]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f45d8e3dsm27252465e9.0.2026.03.18.12.51.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 12:51:47 -0700 (PDT) From: Sean Rhodes To: linux-kernel@vger.kernel.org Cc: Marcel Holtmann , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org Subject: [PATCH] Bluetooth: btusb: clear remote wake on idle Intel ACPI paths Date: Wed, 18 Mar 2026 19:51:45 +0000 Message-ID: <4863e9725130166fdfcea77298f70500dcc03b02.1773863497.git.sean@starlabs.systems> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 6953217d9f44 ("usb: core: allow ACPI-managed hard-wired ports to power off") allows internal USB devices on ACPI-managed hard-wired ports to use the existing runtime power-off path. For Intel combined USB Bluetooth controllers, btusb still keeps runtime remote wake enabled for as long as the adapter is open, which prevents the USB PM core from dropping the last child reference and powering the port off while idle. Only keep runtime remote wake enabled while the controller is expected to signal activity on its own: established links, discovery, LE scan, LE advertising, or BR/EDR page/inquiry scan. When those are idle, clear needs_remote_wakeup so autosuspend can power-manage the port and a later host-initiated command can resume the device again. Signed-off-by: Sean Rhodes --- drivers/bluetooth/btusb.c | 50 +++++++++++++++++++++++++++++++++++++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 5e9ebf0c5312..9df8a7c3254b 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -901,6 +901,7 @@ struct btusb_data { unsigned long flags; =20 bool poll_sync; + bool intel_combined; int intr_interval; struct work_struct work; struct work_struct waker; @@ -958,6 +959,9 @@ struct btusb_data { struct qca_dump_info qca_dump; }; =20 +static bool btusb_intel_idle_power_manageable(struct btusb_data *data); +static bool btusb_needs_runtime_remote_wakeup(struct btusb_data *data); + static void btusb_reset(struct hci_dev *hdev) { struct btusb_data *data; @@ -1151,12 +1155,19 @@ static inline void btusb_free_frags(struct btusb_da= ta *data) =20 static int btusb_recv_event(struct btusb_data *data, struct sk_buff *skb) { + int err; + if (data->intr_interval) { /* Trigger dequeue immediately if an event is received */ schedule_delayed_work(&data->rx_work, 0); } =20 - return data->recv_event(data->hdev, skb); + err =3D data->recv_event(data->hdev, skb); + if (!err) + data->intf->needs_remote_wakeup =3D + btusb_needs_runtime_remote_wakeup(data); + + return err; } =20 static int btusb_recv_intr(struct btusb_data *data, void *buffer, int coun= t) @@ -1924,7 +1935,8 @@ static int btusb_open(struct hci_dev *hdev) goto setup_fail; } =20 - data->intf->needs_remote_wakeup =3D 1; + data->intf->needs_remote_wakeup =3D + btusb_needs_runtime_remote_wakeup(data); =20 if (test_and_set_bit(BTUSB_INTR_RUNNING, &data->flags)) goto done; @@ -1967,6 +1979,38 @@ static void btusb_stop_traffic(struct btusb_data *da= ta) usb_kill_anchored_urbs(&data->ctrl_anchor); } =20 +static bool btusb_intel_idle_power_manageable(struct btusb_data *data) +{ + struct usb_device *udev =3D data->udev; + + return data->intel_combined && udev->parent && + usb_acpi_power_manageable(udev->parent, udev->portnum - 1); +} + +static bool btusb_needs_runtime_remote_wakeup(struct btusb_data *data) +{ + struct hci_dev *hdev =3D data->hdev; + + if (!btusb_intel_idle_power_manageable(data)) + return true; + + if (hci_conn_count(hdev)) + return true; + + if (hdev->discovery.state =3D=3D DISCOVERY_FINDING || + hdev->discovery.state =3D=3D DISCOVERY_RESOLVING) + return true; + + if (hci_dev_test_flag(hdev, HCI_LE_SCAN) || + hci_dev_test_flag(hdev, HCI_LE_ADV) || + hci_dev_test_flag(hdev, HCI_ADVERTISING) || + test_bit(HCI_PSCAN, &hdev->flags) || + test_bit(HCI_ISCAN, &hdev->flags)) + return true; + + return false; +} + static int btusb_close(struct hci_dev *hdev) { struct btusb_data *data =3D hci_get_drvdata(hdev); @@ -4041,6 +4085,8 @@ static int btusb_probe(struct usb_interface *intf, data->recv_bulk =3D btusb_recv_bulk; =20 if (id->driver_info & BTUSB_INTEL_COMBINED) { + data->intel_combined =3D true; + /* Allocate extra space for Intel device */ priv_size +=3D sizeof(struct btintel_data);