From nobody Tue Feb 10 08:03:29 2026 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5953A0B17 for ; Thu, 5 Feb 2026 09:05:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.183 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770282310; cv=none; b=oH0F0Qf3RE4/oqG0kkzVzv/tVLnl1t9pye7BPDGXmL/xyDx08ihg6ZrnoxYsY7BvqlFOS0qi89FYg9AV89itn183AEqDn6fflN5Cmo8IyiptraINqZXPOcwMgBR4voIfNlxX0QSXcx2XoVPbYYA3dGC+Zbt+OMsZLMB5mXLVOVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770282310; c=relaxed/simple; bh=7u4dqtlib1nvZ5RL3hxQfGBu7a9unS9dFfgzBNriI8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RGX4lAFnyq1O3NYykQPKzcX7bUD/Lu9fsgZ/PWCaCRRah8mx8eLi20SA9RThcTExAaGtCxgO5TgFyKciiMizgp/C8+Nyh/QH8/IAp9TuF3zd+UWRhCex+Vdu8o3kdKrSCq37xmDQ8aM5NuNpOwgVc7DbpxIborPLuxpOBWkx4gw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=L/Rz2kc9; arc=none smtp.client-ip=95.215.58.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="L/Rz2kc9" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770282308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7jFcIOUDkaubEwGoEkC6bdzZiVFewkjmb3X6C6JzsWU=; b=L/Rz2kc9fJKMY4HAeVxQjkQaw3Edh1c2yjznQCkbPgqqJnRZBwP3keW1+58eGGGtZbvO5F B5Y7rnRT9NHvPuQuGfA4fc4QY+yQBYjoQSod+yNB7WjMoYC4oheokru1its0J/CZ0rmVg1 yD37EFiDP+aRrOnZs3n3XUHncJmYgiQ= From: Qi Zheng To: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Qi Zheng Subject: [PATCH v4 27/31] mm: memcontrol: refactor memcg_reparent_objcgs() Date: Thu, 5 Feb 2026 17:01:46 +0800 Message-ID: <47f00dba3dfa2481a7397d7049b6e8b8744766e8.1770279888.git.zhengqi.arch@bytedance.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Qi Zheng Refactor the memcg_reparent_objcgs() to facilitate subsequent reparenting LRU folios here. Signed-off-by: Qi Zheng Acked-by: Johannes Weiner Acked-by: Shakeel Butt Reviewed-by: Harry Yoo Reviewed-by: Muchun Song --- mm/memcontrol.c | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 115a1f34bcef9..c9b5dfd822d0a 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -208,15 +208,12 @@ static struct obj_cgroup *obj_cgroup_alloc(void) return objcg; } =20 -static void memcg_reparent_objcgs(struct mem_cgroup *memcg) +static inline struct obj_cgroup *__memcg_reparent_objcgs(struct mem_cgroup= *memcg, + struct mem_cgroup *parent) { struct obj_cgroup *objcg, *iter; - struct mem_cgroup *parent =3D parent_mem_cgroup(memcg); =20 objcg =3D rcu_replace_pointer(memcg->objcg, NULL, true); - - spin_lock_irq(&objcg_lock); - /* 1) Ready to reparent active objcg. */ list_add(&objcg->list, &memcg->objcg_list); /* 2) Reparent active objcg and already reparented objcgs to parent. */ @@ -225,7 +222,29 @@ static void memcg_reparent_objcgs(struct mem_cgroup *m= emcg) /* 3) Move already reparented objcgs to the parent's list */ list_splice(&memcg->objcg_list, &parent->objcg_list); =20 + return objcg; +} + +static inline void reparent_locks(struct mem_cgroup *memcg, struct mem_cgr= oup *parent) +{ + spin_lock_irq(&objcg_lock); +} + +static inline void reparent_unlocks(struct mem_cgroup *memcg, struct mem_c= group *parent) +{ spin_unlock_irq(&objcg_lock); +} + +static void memcg_reparent_objcgs(struct mem_cgroup *memcg) +{ + struct obj_cgroup *objcg; + struct mem_cgroup *parent =3D parent_mem_cgroup(memcg); + + reparent_locks(memcg, parent); + + objcg =3D __memcg_reparent_objcgs(memcg, parent); + + reparent_unlocks(memcg, parent); =20 percpu_ref_kill(&objcg->refcnt); } --=20 2.20.1