From nobody Thu Nov 28 02:39:54 2024 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF7651E3781; Fri, 4 Oct 2024 15:46:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728056814; cv=none; b=ELAj1Kz4uekQjs3FjNSZ55au5umlVqqmnDJpirI45onwHjUgNCY8p+4bWj/hUJ/BG4WdlMAktC9B12h0nJnJExLeQhIGkY3nABt6o+yBdUvX23i/awddgSrzrJuqxwN39ndtKeF8dw77/g52PDtosqWBzw1xJ+tvuSst67zMLyE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728056814; c=relaxed/simple; bh=E9NV0+0MgQ0Q59cqhh7ZaoK0E/2u0Q0LWhMKN9IPmB4=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=tUzTnKduvABp4DGCzw/zAYsQo8Ao0imntmhFXb8d7tWQ93k/RgyTogLIc/HwBKM/wDsfKasp6U7gh4Qcp4qSx+wqYdMxfD/exFlLtIGG/eEZjlepqBnAyN8JUfzr3xuyMEZLil8EDZHz4mTGbXUT0jOnGUkZlLOBeop1pLGpOuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98) (envelope-from ) id 1swkVr-000000008HC-3hfl; Fri, 04 Oct 2024 15:46:40 +0000 Date: Fri, 4 Oct 2024 16:46:33 +0100 From: Daniel Golle To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RFC net-next] net: phy: always set polarity_modes if op is supported Message-ID: <473d62f268f2a317fd81d0f38f15d2f2f98e2451.1728056697.git.daniel@makrotopia.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some PHYs drive LEDs active-low by default and polarity needs to be configured in case the 'active-low' property is NOT set. One way to achieve this without introducing an additional 'active-high' property would be to always call the led_polarity_set operation if it is supported by the phy driver. Signed-off-by: Daniel Golle --- drivers/net/phy/phy_device.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 560e338b307a..d25c61223e83 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -3362,11 +3362,11 @@ static int of_phy_led(struct phy_device *phydev, if (of_property_read_bool(led, "inactive-high-impedance")) set_bit(PHY_LED_INACTIVE_HIGH_IMPEDANCE, &modes); =20 - if (modes) { - /* Return error if asked to set polarity modes but not supported */ - if (!phydev->drv->led_polarity_set) - return -EINVAL; + /* Return error if asked to set polarity modes but not supported */ + if (modes && !phydev->drv->led_polarity_set) + return -EINVAL; =20 + if (phydev->drv->led_polarity_set) { err =3D phydev->drv->led_polarity_set(phydev, index, modes); if (err) return err; --=20 2.46.2