From nobody Fri Nov 29 23:43:06 2024 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37AE011187 for ; Fri, 13 Sep 2024 14:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726238118; cv=none; b=HjZhWFA0bFa2UU35AgA3hPVJ/+kADfQs7WFf8gvBgy5zoNbmLvU95n0o5dHCxQx8n5GMSDL5Dg0foJ720DBn5ebXnbgUITsE3q0590p4iBeF2vCM2g4DMSZbW7BJgCQb9w8SJ17zz7NXeB9HQvdku3N8+zJ2v4FhPfUwi4Gtz8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726238118; c=relaxed/simple; bh=fA4AWaAbXnOOYk1783H913R2EXn6N6behOyf1uOVEVE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=FXr7lzHwr0+RCb2/NVR1QqbYVlgk/0AyTEyrlxOlHRi6A7yVc1zt8+nyGhMZGAU6YUre9Pt3EXY09zw94FUs5b0sSfg1A0Sh4bO+flV8FdIar6d24jzj7I3H94b1DgBqRqdLAxzYL/kr3xuJcbc2U+kJTv1Ngg9YWCqosxwUTRM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fvxhms9T; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fvxhms9T" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a8d60e23b33so275283766b.0 for ; Fri, 13 Sep 2024 07:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726238116; x=1726842916; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=QPpJqdDj9nMsP3j5hQglMwhS09myjVI2wZ8NOXrgLTQ=; b=fvxhms9TCHrIhpMaGXRfjvMxAwdEAgXaCcqOlka2DKTPH6DRj6PDbKj+y1VJsCUTv5 /duKxZQDo4iHGMCVBtVwT9oOXz8O5h+UqPEmCoBArVwjX/J/Yj4ciYh7fsXjZTQA1Xe/ vmmo0KE+Ikds1/C9Pk6gXzNPA2mSKciwH6siGIz62auvtngWB6rIZuXPuE/Ns6KCAzUh qsBTpgdDvRr1aAL7gZutUfLEOoQyV5Am0bHQMWXHNUk3X6RwDRg/m4kysm9vjWUksM/r M/kUq8JIMheUT316lW226UP7CuMTpYTn0rBGGmN5vHsidv51/qHDP5+95sVFD0xX3yDJ ghqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726238116; x=1726842916; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QPpJqdDj9nMsP3j5hQglMwhS09myjVI2wZ8NOXrgLTQ=; b=ZApi0DGbfXNl9nou6UIP1OYBrsbqm5IGSzdQNzkV/keEIf5kRUxiUZfefF0iQ+ht2s h57fRObou/6wCpHzoylPjo0gQgvyEn+S+Xaxl9fkWCfiYnYfDOgjCx2K3ojx00ESdhUl kBGZ72+QDOSHZSEwDEL86fQ+FlsJmFwhOf7Jgprs7BBFtMhYT8K+2AVqqLNdlaA04jeQ cbATjbldsdUORanpLPu5if/aQ9QUp4zFvTj0msXCjmkLsco8c9kxndKhB4Qs1IdsSDV8 CS2jLoOHMXtAhJ8RcqvWFuNlzetviU3FNM43LuCq/KxH/pmWBhSRz/hr836pH3KMFjDU ZQ8g== X-Forwarded-Encrypted: i=1; AJvYcCX6Sd7fvF+tMywraympViD+6n5bFyqmGvJUfuwSNSZLDJv3DWYKfd261XzoukCnM5G4+dQzV3azMc5CCFE=@vger.kernel.org X-Gm-Message-State: AOJu0YyrtE6sSo/acHZMmOXlC/7QIrKelGI9uCF8Uhtm6MVPpQ2Txjtx XfNZVrSk5adIhngfMzuIDwZIJC93chYU3qm4aDE4azsT22ISgVnd2eD4ph7WgRk= X-Google-Smtp-Source: AGHT+IE7zfPqYBpqVTOIdWqsFzLTQ9zGoS19bNShZp/HujGmJgWJRxZEfBbSVizhrSTnrvtHw8zm3A== X-Received: by 2002:a17:907:f75b:b0:a8d:4d76:a75e with SMTP id a640c23a62f3a-a90294d0958mr616258366b.30.1726238115474; Fri, 13 Sep 2024 07:35:15 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25ceed73sm882316566b.174.2024.09.13.07.35.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2024 07:35:15 -0700 (PDT) Date: Fri, 13 Sep 2024 17:35:11 +0300 From: Dan Carpenter To: Nikita Shubin Cc: Vinod Koul , Alexander Sverdlin , Arnd Bergmann , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] dmaengine: ep93xx: Fix a NULL vs IS_ERR() check in probe() Message-ID: <459a965f-f49c-45b1-8362-5ac27b56f5ff@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This was intended to be an IS_ERR() check, not a NULL check. The ep93xx_dma_of_probe() function doesn't return NULL pointers. Fixes: 4e8ad5ed845b ("dmaengine: cirrus: Convert to DT for Cirrus EP93xx") Signed-off-by: Dan Carpenter Reviewed-by: Alexander Sverdlin --- drivers/dma/ep93xx_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c index d084bd123c1c..ca86b2b5a913 100644 --- a/drivers/dma/ep93xx_dma.c +++ b/drivers/dma/ep93xx_dma.c @@ -1504,7 +1504,7 @@ static int ep93xx_dma_probe(struct platform_device *p= dev) int ret; =20 edma =3D ep93xx_dma_of_probe(pdev); - if (!edma) + if (IS_ERR(edma)) return PTR_ERR(edma); =20 dma_dev =3D &edma->dma_dev; --=20 2.45.2