From nobody Fri Apr 10 00:58:02 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 996243D75B1; Wed, 4 Mar 2026 18:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650549; cv=none; b=U++4MXsUCtozOcUBt8pIjY9CByio1pmb7uraIgVwVLoIOYNijWW4+eg5sUkeqTCz8yVmLnOfXdiVvMwgDDJJbxib/+3702DBeXtOsndOjeddjQRp38Dv8wM199jKu9NwK7Jb7WOeU8IFHOUa6neH8nCvU/HGqgKmntuR+LDTkfY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650549; c=relaxed/simple; bh=keQN4MQzfFmdymT+KQmMToZOdNzJU47UOF5Dz8Xbz8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IT+7WuS1XQkGGT+njWV7NxoEC7OFYUmhNUSbPaVjeQ6KKVLHMJGE48VFWj8BFGMIySWwcvcyLqGUZIFBFQKG9OWM/sb3RoMqrPFbxsJUbUC9pdxchMRlapK73nDUnNvhxlY/EYDzif3niwChtBkn331BQ/jmhlZEOtt5M2oTnzg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jBvC38mE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jBvC38mE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29BBAC19425; Wed, 4 Mar 2026 18:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772650549; bh=keQN4MQzfFmdymT+KQmMToZOdNzJU47UOF5Dz8Xbz8o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jBvC38mEZditdFLPm5MoXIg7fWrn2Ra1s9CBVcTzji29zHrhZLWPRJW8+kcXmCD2w cqfVIuoQhyXJltGBMrGf5IDEawGZHcNvS0vNKDC074IL7oqALoZqhuhUr1e1gj0n5n GSARVcydMxTu+J6ar2M9+sua8GuEoVP+CUI2dRFF997Sp0tdLsywzU50QiMgye9+Qt fGKU1OdynQChHGTv+2xe5Q73PwQoJE01/9Yzwdnl1rJLzxkYQ4XNROqeG0FWLKSNXR ADJ+0haNiXvCJJ8Vz+UqrdfUr9/YpYOSBcbQkYeB8U+gJYmTRGWxjylCJsmZhaYGid 5NaznL9X8Hajg== From: "Rafael J. Wysocki" To: Ilpo =?ISO-8859-1?Q?J=E4rvinen?= Cc: LKML , Linux ACPI , Hans de Goede , Maximilian Luz , platform-driver-x86@vger.kernel.org Subject: [PATCH v1 1/3] platform/surface: surfacepro3_button: Drop wakeup source on remove Date: Wed, 04 Mar 2026 19:54:08 +0100 Message-ID: <4368848.1IzOArtZ34@rafael.j.wysocki> Organization: Linux Kernel Development In-Reply-To: <2909929.BEx9A2HvPv@rafael.j.wysocki> References: <2909929.BEx9A2HvPv@rafael.j.wysocki> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Rafael J. Wysocki" The wakeup source added by device_init_wakeup() in surface_button_add() needs to be dropped during driver removal, so update the driver to do that. Fixes: 19351f340765 ("platform/x86: surfacepro3: Support for wakeup from su= spend-to-idle") Signed-off-by: Rafael J. Wysocki --- drivers/platform/surface/surfacepro3_button.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/surface/surfacepro3_button.c b/drivers/platfo= rm/surface/surfacepro3_button.c index 9bd39f09c7db..a6c9d4d370be 100644 --- a/drivers/platform/surface/surfacepro3_button.c +++ b/drivers/platform/surface/surfacepro3_button.c @@ -242,6 +242,7 @@ static void surface_button_remove(struct acpi_device *d= evice) { struct surface_button *button =3D acpi_driver_data(device); =20 + device_init_wakeup(&device->dev, false); input_unregister_device(button->input); kfree(button); } --=20 2.51.0