From nobody Sun Feb 8 22:20:45 2026 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466293904C7; Thu, 22 Jan 2026 16:39:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769099968; cv=none; b=qCSGLS5XTVgayUkrKx5sftBVXylnxO4iG1Cae+6NQTgScXywYeeJKvv6RHgPfwM9shR4e2tK+xEjUfz3os/wjgrToP/fNGXIL115ekTyDKvWj7eOWUIjwN5eOISmbjKrKL76VEAFV3OQ41yELqvfcFfpJgV68NzhKN9W2BoRYx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769099968; c=relaxed/simple; bh=Wwhplcf9tpzruHjL2huv7otfWsh1za017z9Cjw9WmXQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O7gwuKWPz0PQLGnwFXAChb15GZVTWdKVB7GaoD5fxPebBzbMdyNIZ41zMTfLSLWxqP6BCAnyDrYdCb7YE7LxfhxgquRZeGFfvU4Fw2AvXpXhya60BHbxMDMaCBncFtem+bWysipSL1bmrcI8Qlq3H9eLMcEwdnOTRx9c5xu5u/0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1vixiJ-000000001Rc-2mA4; Thu, 22 Jan 2026 16:39:19 +0000 Date: Thu, 22 Jan 2026 16:39:16 +0000 From: Daniel Golle To: Hauke Mehrtens , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Chen Minqiang , Xinfa Deng Subject: [PATCH net-next v6 4/6] net: dsa: lantiq: clean up phylink_get_caps switch statement Message-ID: <423daf99b3d60f510ff048a261c62d3de7d39321.1769099517.git.daniel@makrotopia.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use case ranges for phylink_get_caps and remove the redundant "port N:" from the comments. Suggested-by: Vladimir Oltean Signed-off-by: Daniel Golle --- v6: rebase on top of current net-next v5: no changes v4: no changes v3: no changes v2: new patch drivers/net/dsa/lantiq/lantiq_gswip.c | 12 +++--------- drivers/net/dsa/lantiq/mxl-gsw1xx.c | 11 +++++------ 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/net/dsa/lantiq/lantiq_gswip.c b/drivers/net/dsa/lantiq= /lantiq_gswip.c index 0377fc0079b54..4d699d8c16f91 100644 --- a/drivers/net/dsa/lantiq/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq/lantiq_gswip.c @@ -33,8 +33,7 @@ static void gswip_xrx200_phylink_get_caps(struct dsa_swit= ch *ds, int port, struct phylink_config *config) { switch (port) { - case 0: - case 1: + case 0 ... 1: phy_interface_set_rgmii(config->supported_interfaces); __set_bit(PHY_INTERFACE_MODE_MII, config->supported_interfaces); @@ -44,9 +43,7 @@ static void gswip_xrx200_phylink_get_caps(struct dsa_swit= ch *ds, int port, config->supported_interfaces); break; =20 - case 2: - case 3: - case 4: + case 2 ... 4: case 6: __set_bit(PHY_INTERFACE_MODE_INTERNAL, config->supported_interfaces); @@ -75,10 +72,7 @@ static void gswip_xrx300_phylink_get_caps(struct dsa_swi= tch *ds, int port, config->supported_interfaces); break; =20 - case 1: - case 2: - case 3: - case 4: + case 1 ... 4: case 6: __set_bit(PHY_INTERFACE_MODE_INTERNAL, config->supported_interfaces); diff --git a/drivers/net/dsa/lantiq/mxl-gsw1xx.c b/drivers/net/dsa/lantiq/m= xl-gsw1xx.c index c9cc277e382c2..ba72111a53ad0 100644 --- a/drivers/net/dsa/lantiq/mxl-gsw1xx.c +++ b/drivers/net/dsa/lantiq/mxl-gsw1xx.c @@ -511,14 +511,12 @@ static void gsw1xx_phylink_get_caps(struct dsa_switch= *ds, int port, MAC_10 | MAC_100 | MAC_1000; =20 switch (port) { - case 0: - case 1: - case 2: - case 3: + case 0 ... 3: /* built-in PHYs */ __set_bit(PHY_INTERFACE_MODE_INTERNAL, config->supported_interfaces); break; - case 4: /* port 4: SGMII */ + + case 4: /* SGMII */ __set_bit(PHY_INTERFACE_MODE_SGMII, config->supported_interfaces); __set_bit(PHY_INTERFACE_MODE_1000BASEX, @@ -529,7 +527,8 @@ static void gsw1xx_phylink_get_caps(struct dsa_switch *= ds, int port, config->mac_capabilities |=3D MAC_2500FD; } return; /* no support for EEE on SGMII port */ - case 5: /* port 5: RGMII or RMII */ + + case 5: /* RGMII or RMII */ __set_bit(PHY_INTERFACE_MODE_RMII, config->supported_interfaces); phy_interface_set_rgmii(config->supported_interfaces); --=20 2.52.0