From nobody Mon Feb 9 10:49:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC113EB64DD for ; Tue, 25 Jul 2023 22:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbjGYWUq (ORCPT ); Tue, 25 Jul 2023 18:20:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232394AbjGYWT0 (ORCPT ); Tue, 25 Jul 2023 18:19:26 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FC9944A1; Tue, 25 Jul 2023 15:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690323396; x=1721859396; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FnRel535juPIzcohaQT4gbTQVJFUznDwrWq/ooVWuIg=; b=D7AHKu1l3qfg6WWfHhI0Vpf5NjZhv1QItXmctsqwIyCLNegEAu1UIBKW scudz7saEzbup4HVVt0dC+3hLbsR/lmb/DC4XwurtB++CKu1XXPoBPhM9 dAIV8CmVeUEEXcQbEGc7P0pR/eMFYxZTHd2LCGn2t0k9B2+x6HDIljJoZ R2HVN8s1MRxe/usuh5jkw62nM7UXitF0k3Mp4Peong/hMci6G24bcMORm WoDdumsFBHFcBBEw9bVUaHcw2N1zANZnLh2PECXhAt2OwN/LSaRRpfK2B RXFwW5O7o3qF7S0hYbQ9HFVUAt11ReBi+f9shFcvJ6U7wFwgYAqTZj1j5 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="357863277" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="357863277" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 15:15:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="1056938934" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="1056938934" Received: from ls.sc.intel.com (HELO localhost) ([172.25.112.31]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 15:15:38 -0700 From: isaku.yamahata@intel.com To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: isaku.yamahata@intel.com, isaku.yamahata@gmail.com, Paolo Bonzini , erdemaktas@google.com, Sean Christopherson , Sagi Shahar , David Matlack , Kai Huang , Zhi Wang , chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com Subject: [PATCH v15 045/115] KVM: x86/tdp_mmu: Sprinkle __must_check Date: Tue, 25 Jul 2023 15:13:56 -0700 Message-Id: <4010ab10284b74d841d455d1b3e433376e8b6c4a.1690322424.git.isaku.yamahata@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Isaku Yamahata TDP MMU allows tdp_mmu_set_spte_atomic() and tdp_mmu_zap_spte_atomic() to return -EBUSY or -EAGAIN error. The caller must check the return value and retry. Sprinkle __must_check to guarantee it. Signed-off-by: Isaku Yamahata --- arch/x86/kvm/mmu/tdp_mmu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c index 643c7c65456c..d3788a414551 100644 --- a/arch/x86/kvm/mmu/tdp_mmu.c +++ b/arch/x86/kvm/mmu/tdp_mmu.c @@ -567,9 +567,9 @@ static void handle_changed_spte(struct kvm *kvm, int as= _id, gfn_t gfn, * no side-effects other than setting iter->old_spte to the last * known value of the spte. */ -static inline int tdp_mmu_set_spte_atomic(struct kvm *kvm, - struct tdp_iter *iter, - u64 new_spte) +static inline int __must_check tdp_mmu_set_spte_atomic(struct kvm *kvm, + struct tdp_iter *iter, + u64 new_spte) { u64 *sptep =3D rcu_dereference(iter->sptep); =20 @@ -599,8 +599,8 @@ static inline int tdp_mmu_set_spte_atomic(struct kvm *k= vm, return 0; } =20 -static inline int tdp_mmu_zap_spte_atomic(struct kvm *kvm, - struct tdp_iter *iter) +static inline int __must_check tdp_mmu_zap_spte_atomic(struct kvm *kvm, + struct tdp_iter *iter) { int ret; =20 --=20 2.25.1