From nobody Fri Apr 17 11:36:00 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E3981534EC for ; Mon, 23 Feb 2026 06:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771827565; cv=none; b=Filsk36S8PlZcoMQdTImBUbJhoxznETKxfPi6tdefGSZ8rlQOgXrRSqil63H8mU2Hdnt7omJOUEnvv3VJU46VXSllgJlDVbyAm7keuZtLuxDEMSDKZsdRvsxoqGMqQnqLPyN2jKYpezU8gBjb5rWnE/xYmT00giaIHe3M9WUTDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771827565; c=relaxed/simple; bh=sT7HTPtst/zg7EmgHN1S/xyGPVLYLKf0e36YnPluPv8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Et6f++MwEJ0iw1kZQ5PU35i6txEClsP0p6HkfDn5xWfLGmPwCAIB3kovV8soaZpUHuX0qjCBXwDpuzLIlncKFyIltCTeYpalyVUMQ3i/yZrlN28HUTz9dPkv2jCIwktqtr8CzVTlUhByh1256n5t5Z9ldgaU2FKD84qdVPIRiXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PVf5cQQM; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PVf5cQQM" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ab232cc803so18890805ad.3 for ; Sun, 22 Feb 2026 22:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771827564; x=1772432364; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Vli3G+0wOlwHpxuWTDOJRfn0EdF7sq1jdNlY7kDD5nI=; b=PVf5cQQMJVYWZOsE1RcHJQTxHhN/n5knKDmxAPxxBa+GUT4R6wSBgQh4k/17F4ES4y TQNlhOuIB9RFvMlMfe4WiwU2tPDpedcRH3t/4XxNWrRrasHMrifHOsQvkZx7n9CBQc3j BsHE/jDh3FtMy0aN4T5p97V83bVv6W/Nowy0vR7X+TkmUkuLYak98P78Ma6vY/Ti6OnC WMSJzgi3tQ+7yJ6VN3TMYYZlDGvowbgtaqWUKet6B7NQzEkOMr4fYyk6pcFWMEZ8/YsO Vdyv5KXBBW9O9qSdDq/BQHk+wRX3/2wxEjctTWizZP4og3xnKqpPSIQmbqHm2rFUMEGi OTww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771827564; x=1772432364; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vli3G+0wOlwHpxuWTDOJRfn0EdF7sq1jdNlY7kDD5nI=; b=W1lUG/Wr0MMkACAwpkqFjT2Xg0sC+dT83/uEzFO2JXQc6gmrt490E4J/819sjCeWs6 UXTvvfNTAOZW+w0qlVWez1ZqfS7yXDCjmrhD3tiBelp018O3NRssMrsCE0r8HcfeoMM2 31uNW7w1GKq1HLZMFHzX5graAXGeI+AM4OVhwNvb9v+bCAF00YZDeKBNPIzi5mpoIlJS RbwAmRbC95Tut5K5XJjKTape9wqFpkgDQINlRFF7uANRIKVOmUHZh2RbxFdR7PD+0gBe 38Y+4eBbLIVEMVL/1B8RMBwjXr1hJqo5JiYs+hXUlwHucXoDQC7Hlv+NcDubDRxlpi/r WfCA== X-Forwarded-Encrypted: i=1; AJvYcCVXlsEIyKJcDc9ksziXxF4uyWhztFkXPOjrRNsRbVbXiHcbww5lsWZU24HBoRw/3/UyaoO/x7oYAeQkTZI=@vger.kernel.org X-Gm-Message-State: AOJu0YynIMJumhuU6APCSndkHeQyFYlXneEnYW77/DniFV4uTu40AMl3 HcyBomWg3VEcuD6AXfmyo9nZGh2e0HhZaYR61ZwKjh5gWGuLZXvfUOpvM8R4ANe+M9c= X-Gm-Gg: ATEYQzztyMA3L9lMqQEdRoueOEEQKQ4f5Q8Sj46TzRI41lFNuGHzjRxTAjWwIs1oYjN E+8A+jepncSMyYdDExuDJ0wRlpeIQYqL6z8bVcAUwpjAI4AIWOkSZjvnk3b0DYuTzTRtNnrfx0F Yr6aSQKfjlZHv6w7quVD7QI3menTAFdGkvPgqr8hjSypbkDeiswqKmVpfjXVA9x1YuECb2cdk9q fM2zTeHnM7/RL3j7KuGb9KabcvblbYQA2NMX06qX6LjbLlyiOwB7AonE0SZqit20kIyGv3UOuV+ dXGwthgPSl6JBYEG1zmIlJ9TzZ3WI0jZDJXgWkgm+ofFDWfl0qSqPnwHombj+S08vMCoX+sdQYj fp2GIT3c1JeScN/WC0rUmdeNz5OgbVCAMAgCfbJnSVrq+MJqggDRhGXx3Z2JLZOF+VVgYZU6XVI IJcCI2UfjndjdztgUFnCvQuNJW X-Received: by 2002:a17:902:ef01:b0:2aa:e6fa:2f6d with SMTP id d9443c01a7336-2ad74419e58mr67592045ad.1.1771827563498; Sun, 22 Feb 2026 22:19:23 -0800 (PST) Received: from localhost ([122.172.81.207]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad7500e2b2sm60689155ad.52.2026.02.22.22.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 22:19:22 -0800 (PST) From: Viresh Kumar To: Viresh Kumar , Nishanth Menon , Stephen Boyd Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , "Rafael J. Wysocki" , David Lechner , linux-kernel@vger.kernel.org Subject: [PATCH] OPP: Move break out of scoped_guard in dev_pm_opp_xlate_required_opp() Date: Mon, 23 Feb 2026 11:24:41 +0530 Message-Id: <3d2398f44a2d48fb1c575a6e0bc6b38f3e689e22.1771826075.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The commit ff9c512041f2 ("OPP: Use mutex locking guards") unintentionally made the for loop run longer than required. scoped_guard() is implemented as a for loop. The break statement now breaks out out the scoped_guard() and not out of the outer for loop. The outer loop always iterates to completion. Fix it. Fixes: ff9c512041f2 ("OPP: Use mutex locking guards") Reported-by: David Lechner Signed-off-by: Viresh Kumar --- drivers/opp/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index 866641666e41..da3f5eba4341 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -2742,8 +2742,8 @@ struct dev_pm_opp *dev_pm_opp_xlate_required_opp(stru= ct opp_table *src_table, break; } } - break; } + break; } =20 if (IS_ERR(dest_opp)) { --=20 2.31.1.272.g89b43f80a514