From nobody Thu Apr 2 17:18:53 2026 Received: from mail-244122.protonmail.ch (mail-244122.protonmail.ch [109.224.244.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA83630DEB8 for ; Fri, 27 Mar 2026 15:36:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774625805; cv=none; b=J6zqy5s7Mym0lhAPEAYwiO9C1xrownfCmSTD/L5+5VSOrvEE2k1ld4QtVtCaAtH3dbtGvGYPQ4wl/7H6aolQOGf4iL57q4Zu/ewPgeoJyO/H6AYbt+YUq1cJLvDfe/mf7bg2W0SLV661dUzcvw+dWAxxW2rZIDva2LBdrz4QlZ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774625805; c=relaxed/simple; bh=Fiz2Y+9j/J8MubymvxlEdwjLc+ogkzIUb6zWwFqJidk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rkrYVOo4fRcNWht/xK32f7OnebcA2KbAXGUxUShqb7YDGZP6WYTwJU+Qed9AT9v/I+XtYce9R0CTWpWu/NOigUhihffQstHx6Bs0Dy7I98c12uQmgUYVfjjp2CMJ9BqhvoogBDs+daNUnRvEbpOcJP2hU9VUZo8VQbhVehoS6Bg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pm.me; spf=pass smtp.mailfrom=pm.me; dkim=pass (2048-bit key) header.d=pm.me header.i=@pm.me header.b=ZCheKsfL; arc=none smtp.client-ip=109.224.244.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pm.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pm.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pm.me header.i=@pm.me header.b="ZCheKsfL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1774625801; x=1774885001; bh=d3HJVwdifOyBtPcjlWIlUHMIwXGohNhMNh/3j3nqeO0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ZCheKsfLUffWzB9gJwWFYanr+2cR3EhOLSEbgtY3hfidjaPeX2ET12lID3v/ooyg8 LDZfgM7MuZNJpt6hTzWuoi5fYbYiA3220vJAreOGv2AHiWsoe24og22zl0+3Dw+62O XzO/5///bjT1hDsX0IzRca2ZAMiRN8XMmOixg2ii9fUNbOrfMee5dVTWVV12DndWC8 wdOqgJ0QdNcc0N1PLA137Zt5f73lJWoXxoFU+qJnEc1b0xRGch8IMhctYMWExAtdnj kkh0SFN+UksPmxBKdK/7sGecvu6vWYzudDCc81gqcn/KR1wosGkg8c/BXh/Fj6k6/O GC846mX4nBabA== Date: Fri, 27 Mar 2026 15:36:36 +0000 To: hansg@kernel.org, srinivas.pandruvada@linux.intel.com, ilpo.jarvinen@linux.intel.com From: Maciej Wieczor-Retman Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, dedekind1@gmail.com, artem.bityutskiy@linux.intel.com, m.wieczorretman@pm.me, Maciej Wieczor-Retman Subject: [PATCH v1 1/2] platform/x86/intel-uncore-freq: Rename instance_id Message-ID: <3c02a8e3c1d4f07fa7f37740c33050c4e1d3f6ee.1774625521.git.m.wieczorretman@pm.me> In-Reply-To: References: Feedback-ID: 164464600:user:proton X-Pm-Message-ID: 7e566e30aadb5d9c769895aa0c0737cb7cbbc02b Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Maciej Wieczor-Retman The "instance" word has a specific meaning in the TPMI uncore frequency scaling ecosystem. One TPMI device can have multiple copies of a feature and each copy is called an instance. The currently used "instance_id" uncore_data struct field is a sequentially generated value that's used for appending to uncore directories inside the /sys/devices/system/cpu/intel_uncore_frequency directory. It has no relation to the TPMI device feature copy. Signed-off-by: Maciej Wieczor-Retman --- .../x86/intel/uncore-frequency/uncore-frequency-common.c | 6 +++--- .../x86/intel/uncore-frequency/uncore-frequency-common.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-c= ommon.c b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-comm= on.c index 7070c94324e0..71c47aa77d3c 100644 --- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c +++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c @@ -268,7 +268,7 @@ int uncore_freq_add_entry(struct uncore_data *data, int= cpu) if (ret < 0) goto uncore_unlock; =20 - data->instance_id =3D ret; + data->seqname_id =3D ret; scnprintf(data->name, sizeof(data->name), "uncore%02d", ret); } else { scnprintf(data->name, sizeof(data->name), "package_%02d_die_%02d", @@ -281,7 +281,7 @@ int uncore_freq_add_entry(struct uncore_data *data, int= cpu) ret =3D create_attr_group(data, data->name); if (ret) { if (data->domain_id !=3D UNCORE_DOMAIN_ID_INVALID) - ida_free(&intel_uncore_ida, data->instance_id); + ida_free(&intel_uncore_ida, data->seqname_id); } else { data->control_cpu =3D cpu; data->valid =3D true; @@ -301,7 +301,7 @@ void uncore_freq_remove_die_entry(struct uncore_data *d= ata) data->control_cpu =3D -1; data->valid =3D false; if (data->domain_id !=3D UNCORE_DOMAIN_ID_INVALID) - ida_free(&intel_uncore_ida, data->instance_id); + ida_free(&intel_uncore_ida, data->seqname_id); =20 mutex_unlock(&uncore_lock); } diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-c= ommon.h b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-comm= on.h index 0abe850ef54e..915506de4ebf 100644 --- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.h +++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.h @@ -35,7 +35,7 @@ * @die_id: Die id for this instance * @domain_id: Power domain id for this instance * @cluster_id: cluster id in a domain - * @instance_id: Unique instance id to append to directory name + * @seqname_id: Unique id to append to directory name * @name: Sysfs entry name for this instance * @agent_type_mask: Bit mask of all hardware agents for this domain * @uncore_attr_group: Attribute group storage @@ -71,7 +71,7 @@ struct uncore_data { int die_id; int domain_id; int cluster_id; - int instance_id; + int seqname_id; char name[32]; u16 agent_type_mask; =20 --=20 2.53.0