From nobody Fri Dec 19 12:33:16 2025 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.196]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C0D84524C9 for ; Mon, 25 Dec 2023 14:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="mq7Vgsxv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=3Edaz bBuWn+zR00jVC2IdNv8Gvt/eD6wDHkffcQ4WIU=; b=mq7VgsxvzC25fxBq8Bs4X EzQG6tcDcREDQJG6Y7Mna7g12xzFIn0TsvWpMpi6Kh85tFnYn2Kl5md1mOVUup6E mEC+O/8PrKlEr68W1fM/6mluL28XGGGH1MFLYRo2OEY8sk9M73QsLy5l3qmDjN8C IHbw04CeO0ZKbzlq559iOM= Received: from ubuntu22.localdomain (unknown [117.176.219.50]) by zwqz-smtp-mta-g4-0 (Coremail) with SMTP id _____wDHF0wJkYllJEGXGg--.64396S2; Mon, 25 Dec 2023 22:26:18 +0800 (CST) From: chenguanxi11234@163.com To: hanxu5@huaqin.corp-partner.google.com Cc: cgel.zte@gmail.com, neil.armstrong@linaro.org, quic_jesszhan@quicinc.com, sam@ravnborg.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, yang.guang5@zte.com.cn, jiang.xuexin@zte.com.cn, Chen Haonan Subject: [PATCH linux-next v2] drm/panel: Simplify with dev_err_probe() Date: Mon, 25 Dec 2023 22:26:15 +0800 Message-Id: <3ac20d355b0b3ad3cedb87c8f4efa819a055624b.1702967834.git.chen.haonan2@zte.com.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDHF0wJkYllJEGXGg--.64396S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7WF1DZFW8CFy3Cr4ftr1DZFb_yoW8Cr1kpF 4UJF9FvF98AFWS939xAF97AF1jya1xKF4YkFs2g397Aw17tr4xWr17GFy0vFW5tFyrXFW5 JF1xXFy3ua4UZr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jM89_UUUUU= X-CM-SenderInfo: xfkh0wxxdq5xirrsjki6rwjhhfrp/xtbBzwVR+mV4G-HRcAABs2 Content-Type: text/plain; charset="utf-8" From: Chen Haonan dev_err_probe() can check if the error code is -EPROBE_DEFER=20 and can return the error code, replacing dev_err() with it=20 simplifies the code. Signed-off-by: Chen Haonan Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-boe-himax8279d.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm= /panel/panel-boe-himax8279d.c index 11b64acbe8a9..e225840b0d67 100644 --- a/drivers/gpu/drm/panel/panel-boe-himax8279d.c +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c @@ -854,26 +854,20 @@ static int panel_add(struct panel_info *pinfo) =20 pinfo->pp18_gpio =3D devm_gpiod_get(dev, "pp18", GPIOD_OUT_HIGH); if (IS_ERR(pinfo->pp18_gpio)) { - ret =3D PTR_ERR(pinfo->pp18_gpio); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to get pp18 gpio: %d\n", ret); - return ret; + return dev_err_probe(dev, PTR_ERR(pinfo->pp18_gpio), + "failed to get pp18 gpio\n"); } =20 pinfo->pp33_gpio =3D devm_gpiod_get(dev, "pp33", GPIOD_OUT_HIGH); if (IS_ERR(pinfo->pp33_gpio)) { - ret =3D PTR_ERR(pinfo->pp33_gpio); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to get pp33 gpio: %d\n", ret); - return ret; + return dev_err_probe(dev, PTR_ERR(pinfo->pp33_gpio), + "failed to get pp33 gpio\n"); } =20 pinfo->enable_gpio =3D devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); if (IS_ERR(pinfo->enable_gpio)) { - ret =3D PTR_ERR(pinfo->enable_gpio); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to get enable gpio: %d\n", ret); - return ret; + return dev_err_probe(dev, PTR_ERR(pinfo->enable_gpio), + "failed to get enable gpio\n"); } =20 drm_panel_init(&pinfo->base, dev, &panel_funcs, --=20 2.25.1