From nobody Sat Apr 11 22:27:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F123C00140 for ; Fri, 5 Aug 2022 16:28:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241050AbiHEQ2i (ORCPT ); Fri, 5 Aug 2022 12:28:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241224AbiHEQ2b (ORCPT ); Fri, 5 Aug 2022 12:28:31 -0400 Received: from mx01.ayax.eu (mx01.ayax.eu [188.137.98.110]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 665BED100 for ; Fri, 5 Aug 2022 09:28:29 -0700 (PDT) Received: from [192.168.192.146] (port=59782 helo=nx64de-df6d00) by mx01.ayax.eu with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oK0BK-0007qK-0i; Fri, 05 Aug 2022 18:28:17 +0200 Date: Fri, 5 Aug 2022 18:28:12 +0200 From: Grzegorz Szymaszek To: Larry Finger , Greg KH , Phillip Potter Cc: Philipp Hortmann , Grzegorz Szymaszek , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v2 4/4] staging: r8188eu: drop the DRIVERVERSION macro Message-ID: <39e6b702918b7bcc59dec381022c1d1b97c2046e.1659715931.git.gszymaszek@short.pl> Mail-Followup-To: Grzegorz Szymaszek , Larry Finger , Greg KH , Phillip Potter , Philipp Hortmann , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since the driver is currently in the kernel, the module version macro is not necessary. Link: https://lore.kernel.org/lkml/Yuy7Lc%2FTJMinuupA@kroah.com/ Suggested-by: Greg Kroah-Hartman Signed-off-by: Grzegorz Szymaszek --- V1 -> V2: Split v1-0003 into v2-0003 and v2-0004. Remove the DRIVERVERSION macro instead of changing its name drivers/staging/r8188eu/include/drv_types.h | 1 - drivers/staging/r8188eu/os_dep/os_intfs.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/r8188eu/include/drv_types.h b/drivers/staging/= r8188eu/include/drv_types.h index f659eac70b32..05888acc6bb1 100644 --- a/drivers/staging/r8188eu/include/drv_types.h +++ b/drivers/staging/r8188eu/include/drv_types.h @@ -34,7 +34,6 @@ #include "rtl8188e_hal.h" #include "rtw_fw.h" =20 -#define DRIVERVERSION "v4.1.4_6773.20130222" #define FW_RTL8188EU "rtlwifi/rtl8188eufw.bin" =20 struct registry_priv { diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8= 188eu/os_dep/os_intfs.c index 5985054da935..e90af754ef93 100644 --- a/drivers/staging/r8188eu/os_dep/os_intfs.c +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c @@ -17,7 +17,6 @@ MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Realtek Wireless Lan Driver"); MODULE_AUTHOR("Realtek Semiconductor Corp."); -MODULE_VERSION(DRIVERVERSION); MODULE_FIRMWARE(FW_RTL8188EU); =20 #define CONFIG_BR_EXT_BRNAME "br0" --=20 2.35.1