From nobody Mon Dec 1 22:37:32 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD9272FF65A for ; Sun, 30 Nov 2025 23:35:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764545739; cv=none; b=MfxIRZukzDs5tovJUDdmEmgXzdDw/yyno9nAcY4PjkezqeEYBFNXmh0jAhguPU8V1lr2YoAFxr9/1jwJSExIam8FkOqN8OzzIuBw5JQn7NRWeBdqt8t0H8WHy4kBhTc8DmcbziJwcUGpoYItEfk3ZyhUjcp4oK5wIEikZWCxVxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764545739; c=relaxed/simple; bh=LSh5hLuiJCxDRwJ+BQ+Xc7tCZE16QA/b770rYhc+vp8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LkIQhqJh43x4G4a5lhDQvxXW7vn6miXRCIFdgs8K4zQ3Ikhn033epdw7tB9ycPIsFjdk/lj05d2Fi+WRPy74Mc33atMCDAnIKjB+kOaS7xXnTBLNnxenKvFQuiEXxUUeg4LPydeS03K5kRXjg/ZWOCcnbedAkVLtSboD/YM+EEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D7UypCOO; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D7UypCOO" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47778b23f64so19530275e9.0 for ; Sun, 30 Nov 2025 15:35:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764545736; x=1765150536; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BopLoWIhKj7xpDJExutQghL/d96/x+rVfP3p1ohtywE=; b=D7UypCOOix839eTbKC/dmhlH6EbPRl2Q9K5FTyuaos0ra5SfgnRH67yxhdXonRzNE1 JLm/05xwKtxykCoPmzkttHKzOmVki1Jk1KIITlrwiebCDzkATqj3aa0lBfnszDQIwT8i ct5CkJNOqMBUydrm89AS2BFiomYcBjCX2G3YsZ3MSuE3aq/ps+ZtYJQxcjULM/Z81xPm hqjkAzibMOr0aVfM9a0KkPmay+GuLD7jQddO38eBauV6wOpy2qkK/5B9RIqXSr/PB6RZ W0IjlPfXngCtYQbDJzdtD1CA18rqtwJrrgmy1LKiYd9iwF0gqqaZhlRZv5MoKAlOlV0a F4SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764545736; x=1765150536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BopLoWIhKj7xpDJExutQghL/d96/x+rVfP3p1ohtywE=; b=Agjy/hLMGnsu431MFYFaA6056eabKwo1Nc3rF+Yh1zqh2Kq4W9jWSPkLwdqpktdctA 82QHWFyie1caPpW4of8FC+JiW62gxEkmwgqAq0b+UssF3kypn6wWyqF6tSOIkxRSIg0s sajEOA8q/G8SVN+CM/mJ1NnHDvkrX2kcouJfKF8wa2IUcvqJ934DquUNzxegOqHIUqTv 13HnioMhbDkwuANXhaLN56lPmO/NTVS37YeqgS2Xa93OnH7maV2O31a0pktOtIY8x5uC b7WnSuWy56L607kgWWQcPf2EM3PSqNi3Jqb/5A1hghS8sjO6GKhWM9mF3xxOjMzeOaae e/Lg== X-Forwarded-Encrypted: i=1; AJvYcCWo9OGPHu1I/Sb/lYEQPgaSnm7SjS8PGjFJOt4gh4pk5fP84+82br55ZHtJ0dKEc7yR8NOz+rLB1rpuPa4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1mIGq3PGZMiuSXP3I+4yZZUHdsltUQLf/FnkjGrkLgBLng/G3 L1i3Hfq9SpukZ+isRlMg4tShfa1KjQg1g8qywUz8lySCeNL3CHJwuD6i X-Gm-Gg: ASbGncsLSvRDbQS16AvLYi7s/AC1kctPzEg2d5SXtm9nYkFCRbJTqZ04UEzdYiqjB3T GKPQgMjATvUnlkcVf3ZPqkUDL1wVaHOGhM1BcFg4IH97Q2+6HRSJx1YQA4tSMVO37To+FULMeCp Qv6NtulTe+2MnBcHtus2j5uQnyBQtazfwj+TvrnJSVde8ZtFVLne1yhq5eK3B/dMvz7g8IvubZ8 iERxeqv7nBOGhOeUiAOaPKN8ml6UJ1ppqbAfoZ2DA86QFzaGF+saMCBDQOPuQQv6PHABhXW4gfv 1JXrTdZGXdS4K7GIqSpmgLMNh3Ny49SEwHtesbi8h4JtXXD/nrydkLW/1HuGIfflZyalfW8YrjI 95pB3nDcUwc9ACjUA0im1dzudMI7i5FWi37hh6ohF3HIj7FEZTlZJ4A8yUY4GaXj0r7y1Bor6l3 MfHay8ZuhZ1LR5gXJ8OT24wGaHzUbGT7mV5KZVtqj3dbmpFy/Uyqm8+LvOg5UFSghcg++P3ZGof 8dpm9v65REGdtfPZYg3uAEb0jY= X-Google-Smtp-Source: AGHT+IHISYLGMcAbCVZNiKeY1dtZPkbvCAz/q8vqp6c82/yUdHZQKIhPMrYnHbV51FKqG4IwK4u77g== X-Received: by 2002:a05:600c:5252:b0:477:582e:7a81 with SMTP id 5b1f17b1804b1-477c110328amr358728235e9.4.1764545736071; Sun, 30 Nov 2025 15:35:36 -0800 (PST) Received: from 127.mynet ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479040b3092sm142722075e9.1.2025.11.30.15.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 15:35:35 -0800 (PST) From: Pavel Begunkov To: netdev@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Michael Chan , Pavan Chebbi , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Ilias Apalodimas , Shuah Khan , Mina Almasry , Stanislav Fomichev , Pavel Begunkov , Yue Haibing , David Wei , Haiyue Wang , Jens Axboe , Joe Damato , Simon Horman , Vishwanath Seshagiri , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, io-uring@vger.kernel.org, dtatulea@nvidia.com Subject: [PATCH net-next v7 3/9] net: memzero mp params when closing a queue Date: Sun, 30 Nov 2025 23:35:18 +0000 Message-ID: <374b055a2119076d43336008817248854774668e.1764542851.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of resetting memory provider parameters one by one in __net_mp_{open,close}_rxq, memzero the entire structure. It'll be used to extend the structure. Signed-off-by: Pavel Begunkov --- net/core/netdev_rx_queue.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/net/core/netdev_rx_queue.c b/net/core/netdev_rx_queue.c index c7d9341b7630..a0083f176a9c 100644 --- a/net/core/netdev_rx_queue.c +++ b/net/core/netdev_rx_queue.c @@ -139,10 +139,9 @@ int __net_mp_open_rxq(struct net_device *dev, unsigned= int rxq_idx, =20 rxq->mp_params =3D *p; ret =3D netdev_rx_queue_restart(dev, rxq_idx); - if (ret) { - rxq->mp_params.mp_ops =3D NULL; - rxq->mp_params.mp_priv =3D NULL; - } + if (ret) + memset(&rxq->mp_params, 0, sizeof(rxq->mp_params)); + return ret; } =20 @@ -179,8 +178,7 @@ void __net_mp_close_rxq(struct net_device *dev, unsigne= d int ifq_idx, rxq->mp_params.mp_priv !=3D old_p->mp_priv)) return; =20 - rxq->mp_params.mp_ops =3D NULL; - rxq->mp_params.mp_priv =3D NULL; + memset(&rxq->mp_params, 0, sizeof(rxq->mp_params)); err =3D netdev_rx_queue_restart(dev, ifq_idx); WARN_ON(err && err !=3D -ENETDOWN); } --=20 2.52.0