From nobody Mon Apr 6 20:14:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAAEFC001B5 for ; Fri, 2 Sep 2022 16:27:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234070AbiIBQ1T (ORCPT ); Fri, 2 Sep 2022 12:27:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235980AbiIBQ1I (ORCPT ); Fri, 2 Sep 2022 12:27:08 -0400 Received: from smtp.smtpout.orange.fr (smtp-26.smtpout.orange.fr [80.12.242.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 313E8C9270 for ; Fri, 2 Sep 2022 09:27:07 -0700 (PDT) Received: from pop-os.home ([90.11.190.129]) by smtp.orange.fr with ESMTPA id U9VRobqH1kifIU9VSoXLOn; Fri, 02 Sep 2022 18:27:03 +0200 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Fri, 02 Sep 2022 18:27:03 +0200 X-ME-IP: 90.11.190.129 From: Christophe JAILLET To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , Andy Shevchenko , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3] stmmac: intel: Simplify intel_eth_pci_remove() Date: Fri, 2 Sep 2022 18:26:56 +0200 Message-Id: <35ab3ac5b67716acb3f7073229b02a38fce71fb7.1662135995.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There is no point to call pcim_iounmap_regions() in the remove function, this frees a managed resource that would be release by the framework anyway. Signed-off-by: Christophe JAILLET Reviewed-by: Andy Shevchenko --- Change in v3: * (no code change) * what was patch 1/2 in the serie has been applied * synch with net-next Change in v2: * (no code change) * Remove the text added below the --- in v1 (see link below if needed) * Add Reviewed-by: https://lore.kernel.org/all/2aeb1a03d07c686efd8b3e6fc8ff2d45cd7da1e8.1660= 659689.git.christophe.jaillet@wanadoo.fr/ v1: https://lore.kernel.org/all/9f82d58aa4a6c34ec3c734399a4792d3aa23297f.1659= 204745.git.christophe.jaillet@wanadoo.fr/ --- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/ne= t/ethernet/stmicro/stmmac/dwmac-intel.c index 7d3c7ca7caf4..0a2afc1a3124 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c @@ -1135,8 +1135,6 @@ static void intel_eth_pci_remove(struct pci_dev *pdev) =20 clk_disable_unprepare(priv->plat->stmmac_clk); clk_unregister_fixed_rate(priv->plat->stmmac_clk); - - pcim_iounmap_regions(pdev, BIT(0)); } =20 static int __maybe_unused intel_eth_pci_suspend(struct device *dev) --=20 2.34.1