From nobody Mon Feb 9 09:28:56 2026 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F365134A797 for ; Wed, 14 Jan 2026 11:35:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768390540; cv=none; b=Nnxf3WE7xUXGVAnnfNbztCDom0mISh2Bpcbuv8uVXI9aylQKQKLIivU4GosKVfrkvIiLIWYsA+BF2852SRB7FwTKRglP8DmzvNgoZm3BY2MeW/FJjHXJ+yn0g8/b4MRlQHvuISUNCrou9yAccxwE3+0jCCDKMU54ZtSdjdxbRmY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768390540; c=relaxed/simple; bh=mKCR9H5XpMftKla9CnNc3QX6Tbf0h/CU2M6eQ0Ryfic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SexekRCWnUVsCKapnBBgLPL4MjLotnYadCVFwPpYWpP8hrWLMU978UYiPWKCKMfH+SMWBNEBSpeYj7TKtvhWMltW5qOQaUHYl691VTAMhviM7+uRsSB5U3yUpw9lruYlyCv5GZYXbXyok2p1DWLYRyofuoLbM2x2jpKoH4cFlnA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=lHtmZUQd; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="lHtmZUQd" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1768390537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=egA9OCpvJUUfZlVg68Gp5bUnsvQAjKiqm/PvYeVMrFQ=; b=lHtmZUQdxzcSHug7u6aLnbAP2ZssjbFwLCca9btr5YQ4kWE//QnuhiDJXybsJtvIgKJ28a 0MFrVPqOxTxCcrqVJKy2o1MmXRRB+XWy/GgAFZyMjvVUpsUdzJtOEKVoi/QsQm/eKiB41M nVMyUjNd8e72GBYUHikZEDz7JbD8boc= From: Qi Zheng To: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Qi Zheng Subject: [PATCH v3 23/30] mm: do not open-code lruvec lock Date: Wed, 14 Jan 2026 19:32:50 +0800 Message-ID: <33fef62fd821f669fcdc999e54c4035a4e91b47d.1768389889.git.zhengqi.arch@bytedance.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Qi Zheng Now we have lruvec_unlock(), lruvec_unlock_irq() and lruvec_unlock_irqrestore(), but not the paired lruvec_lock(), lruvec_lock_irq() and lruvec_lock_irqsave(). There is currently no use case for lruvec_lock_irqsave(), so only introduce lruvec_lock() and lruvec_lock_irq(), and change all open-code places to use these helper function. This looks cleaner and prepares for reparenting LRU pages, preventing user from missing RCU lock calls due to open-code lruvec lock. Signed-off-by: Qi Zheng Acked-by: Muchun Song Acked-by: Shakeel Butt Reviewed-by: Harry Yoo --- include/linux/memcontrol.h | 5 +++++ mm/vmscan.c | 38 +++++++++++++++++++------------------- 2 files changed, 24 insertions(+), 19 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index f1556759d0d3f..4b6f20dc694ba 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -1499,6 +1499,11 @@ static inline struct lruvec *parent_lruvec(struct lr= uvec *lruvec) return mem_cgroup_lruvec(memcg, lruvec_pgdat(lruvec)); } =20 +static inline void lruvec_lock_irq(struct lruvec *lruvec) +{ + spin_lock_irq(&lruvec->lru_lock); +} + static inline void lruvec_unlock(struct lruvec *lruvec) { spin_unlock(&lruvec->lru_lock); diff --git a/mm/vmscan.c b/mm/vmscan.c index f206d4dac9e77..c48ff6e05e004 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2020,7 +2020,7 @@ static unsigned long shrink_inactive_list(unsigned lo= ng nr_to_scan, =20 lru_add_drain(); =20 - spin_lock_irq(&lruvec->lru_lock); + lruvec_lock_irq(lruvec); =20 nr_taken =3D isolate_lru_folios(nr_to_scan, lruvec, &folio_list, &nr_scanned, sc, lru); @@ -2032,7 +2032,7 @@ static unsigned long shrink_inactive_list(unsigned lo= ng nr_to_scan, count_memcg_events(lruvec_memcg(lruvec), item, nr_scanned); __count_vm_events(PGSCAN_ANON + file, nr_scanned); =20 - spin_unlock_irq(&lruvec->lru_lock); + lruvec_unlock_irq(lruvec); =20 if (nr_taken =3D=3D 0) return 0; @@ -2051,7 +2051,7 @@ static unsigned long shrink_inactive_list(unsigned lo= ng nr_to_scan, count_memcg_events(lruvec_memcg(lruvec), item, nr_reclaimed); count_vm_events(PGSTEAL_ANON + file, nr_reclaimed); =20 - spin_lock_irq(&lruvec->lru_lock); + lruvec_lock_irq(lruvec); lru_note_cost_unlock_irq(lruvec, file, stat.nr_pageout, nr_scanned - nr_reclaimed); =20 @@ -2130,7 +2130,7 @@ static void shrink_active_list(unsigned long nr_to_sc= an, =20 lru_add_drain(); =20 - spin_lock_irq(&lruvec->lru_lock); + lruvec_lock_irq(lruvec); =20 nr_taken =3D isolate_lru_folios(nr_to_scan, lruvec, &l_hold, &nr_scanned, sc, lru); @@ -2141,7 +2141,7 @@ static void shrink_active_list(unsigned long nr_to_sc= an, __count_vm_events(PGREFILL, nr_scanned); count_memcg_events(lruvec_memcg(lruvec), PGREFILL, nr_scanned); =20 - spin_unlock_irq(&lruvec->lru_lock); + lruvec_unlock_irq(lruvec); =20 while (!list_empty(&l_hold)) { struct folio *folio; @@ -2197,7 +2197,7 @@ static void shrink_active_list(unsigned long nr_to_sc= an, count_memcg_events(lruvec_memcg(lruvec), PGDEACTIVATE, nr_deactivate); mod_node_page_state(pgdat, NR_ISOLATED_ANON + file, -nr_taken); =20 - spin_lock_irq(&lruvec->lru_lock); + lruvec_lock_irq(lruvec); lru_note_cost_unlock_irq(lruvec, file, 0, nr_rotated); trace_mm_vmscan_lru_shrink_active(pgdat->node_id, nr_taken, nr_activate, nr_deactivate, nr_rotated, sc->priority, file); @@ -3832,9 +3832,9 @@ static void walk_mm(struct mm_struct *mm, struct lru_= gen_mm_walk *walk) } =20 if (walk->batched) { - spin_lock_irq(&lruvec->lru_lock); + lruvec_lock_irq(lruvec); reset_batch_size(walk); - spin_unlock_irq(&lruvec->lru_lock); + lruvec_unlock_irq(lruvec); } =20 cond_resched(); @@ -3993,7 +3993,7 @@ static bool inc_max_seq(struct lruvec *lruvec, unsign= ed long seq, int swappiness if (seq < READ_ONCE(lrugen->max_seq)) return false; =20 - spin_lock_irq(&lruvec->lru_lock); + lruvec_lock_irq(lruvec); =20 VM_WARN_ON_ONCE(!seq_is_valid(lruvec)); =20 @@ -4008,7 +4008,7 @@ static bool inc_max_seq(struct lruvec *lruvec, unsign= ed long seq, int swappiness if (inc_min_seq(lruvec, type, swappiness)) continue; =20 - spin_unlock_irq(&lruvec->lru_lock); + lruvec_unlock_irq(lruvec); cond_resched(); goto restart; } @@ -4043,7 +4043,7 @@ static bool inc_max_seq(struct lruvec *lruvec, unsign= ed long seq, int swappiness /* make sure preceding modifications appear */ smp_store_release(&lrugen->max_seq, lrugen->max_seq + 1); unlock: - spin_unlock_irq(&lruvec->lru_lock); + lruvec_unlock_irq(lruvec); =20 return success; } @@ -4739,7 +4739,7 @@ static int evict_folios(unsigned long nr_to_scan, str= uct lruvec *lruvec, struct mem_cgroup *memcg =3D lruvec_memcg(lruvec); struct pglist_data *pgdat =3D lruvec_pgdat(lruvec); =20 - spin_lock_irq(&lruvec->lru_lock); + lruvec_lock_irq(lruvec); =20 scanned =3D isolate_folios(nr_to_scan, lruvec, sc, swappiness, &type, &li= st); =20 @@ -4748,7 +4748,7 @@ static int evict_folios(unsigned long nr_to_scan, str= uct lruvec *lruvec, if (evictable_min_seq(lrugen->min_seq, swappiness) + MIN_NR_GENS > lrugen= ->max_seq) scanned =3D 0; =20 - spin_unlock_irq(&lruvec->lru_lock); + lruvec_unlock_irq(lruvec); =20 if (list_empty(&list)) return scanned; @@ -4786,9 +4786,9 @@ static int evict_folios(unsigned long nr_to_scan, str= uct lruvec *lruvec, walk =3D current->reclaim_state->mm_walk; if (walk && walk->batched) { walk->lruvec =3D lruvec; - spin_lock_irq(&lruvec->lru_lock); + lruvec_lock_irq(lruvec); reset_batch_size(walk); - spin_unlock_irq(&lruvec->lru_lock); + lruvec_unlock_irq(lruvec); } =20 mod_lruvec_state(lruvec, PGDEMOTE_KSWAPD + reclaimer_offset(sc), @@ -5226,7 +5226,7 @@ static void lru_gen_change_state(bool enabled) for_each_node(nid) { struct lruvec *lruvec =3D get_lruvec(memcg, nid); =20 - spin_lock_irq(&lruvec->lru_lock); + lruvec_lock_irq(lruvec); =20 VM_WARN_ON_ONCE(!seq_is_valid(lruvec)); VM_WARN_ON_ONCE(!state_is_valid(lruvec)); @@ -5234,12 +5234,12 @@ static void lru_gen_change_state(bool enabled) lruvec->lrugen.enabled =3D enabled; =20 while (!(enabled ? fill_evictable(lruvec) : drain_evictable(lruvec))) { - spin_unlock_irq(&lruvec->lru_lock); + lruvec_unlock_irq(lruvec); cond_resched(); - spin_lock_irq(&lruvec->lru_lock); + lruvec_lock_irq(lruvec); } =20 - spin_unlock_irq(&lruvec->lru_lock); + lruvec_unlock_irq(lruvec); } =20 cond_resched(); --=20 2.20.1