From nobody Tue Apr 7 18:46:54 2026 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B8BF23ABBD for ; Sat, 28 Feb 2026 00:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772240112; cv=none; b=lf4qkIW4T4ax6nObrSPlnJOruh69ClXzPmZyhHqx7VxUKH/ziGUvbjC7MN2XXjhklPWb9Xu2rnVlXL4ySMiOVWMcOhWadi3gotp6f3PQ2piEG2q8eTyn7i3zE/521Z+JNGnzBSYck0n2FKmUdY50uW3ga3Mz4RX+TMesSgO/Kr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772240112; c=relaxed/simple; bh=dEE6VGsTSOYeekVC/927JnJzPCZGdsA6+ByrSiQA0sQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eZ+edfb4mE4lTsNMxYsLARXAkODuXVHgK88eQnpa+3oUIfQc8Hs0mMM+rRHSnfySNAV4ZDyNG6GewUxeBpodT9lu9m6M18b7DUfNsvRr348w5OlyZWVfL8Ne8Qp/X6R5er3jmSgjhTIRaOGdi/C3h1WyHLyLCwUZ1vl3NYI4zJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S07OIAxk; arc=none smtp.client-ip=209.85.221.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S07OIAxk" Received: by mail-vk1-f170.google.com with SMTP id 71dfb90a1353d-56a8a20e6e6so1194223e0c.0 for ; Fri, 27 Feb 2026 16:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772240110; x=1772844910; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tR8qs9++9EnY6kiO3ZkloT5P8dh9BxfptB2pOEQ7BLA=; b=S07OIAxkMHNDqywrWCgshv+EXJ38goGfzcBwtTCam5CFFaTXCYQ4Dj4YpMJnVtuIRR GpCfX1qqssXXlxZXxoVjdzTk9anhHJcZ8Xd6bFSTbi8B3cv95KInjjOnoJg1Q3da1G19 jsgU/Z6w66tGR22844MIGL4qlZqZQDuueKGzUnMJgOoXDUBniUIEIxd3AePp5GH949aI 1wMwTuwY+HqBxTOx9ITRaikET7PNKisMrXemCN3+SfkHRVjsev/kP/gRHVjZdi9i7zYR tVH3heC5jXK7GZOV/9gI6+esx2rnnL6ikGFtoHOuEyZiWPweH8QDsth7B1RtDTjU0Eug /V0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772240110; x=1772844910; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tR8qs9++9EnY6kiO3ZkloT5P8dh9BxfptB2pOEQ7BLA=; b=wdex7SM6X/aApm4VhygMBBGh7YMOMyasW00OgWyMndMEdknCjMIkjdzDBP0IJ4c7nl KzrMTL4riamLRZYXUDm62TxzPuKJL8p3lTHHoUmYmBOp9Z5aNPfsvaMl5NkxW1xmL4vU 0NlrmEOd2djoCPZquX+uflXvLE7whCl3BRlgICYfvvaQKpUM14f5McuLz14s4EZgz+UF YTZFkZBj8RtO3bO7Mzr6tOyAlzdctbqQo/3FlOk0F82oTC7EFc9pYwfTRAvsgnIIjZ0G NO1D0reB0ua5LEdMPH7d8Z4XJmbmmemSj4Ot3McXj/UkgNhwz09JPhhQw0mGeg58S+tl 1QAA== X-Forwarded-Encrypted: i=1; AJvYcCUXXQp/H+dx3Bgk/Km9+QXaJ0r27W/mbTMWXmN2Tgy7tOCP7p1jQrY9kNJz71SHiW+tdf/SUMDnQkpu9uE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywbg0iiah9WiT0R+RplJYunEY7VVIjeCbIv6GpmiWRJnrGjUJKY PYVnm0MDJfdxrIMLOWchtDlrYtt14AWY/I8OqV4qLBfh3VO+0uVTsKII X-Gm-Gg: ATEYQzxxP6nAu9IiW8eh9pjSx3ywrefZBwsa+kg9+TyKCpshBvY4abfHFpZmqlt8MSk hytc41/HtGxf0KHj9YyPwHkxpMxtail1yOCNiAvEnxa9koXPLnOCTWCE9kJt1d18PUC5Jjk/t1v EAfgKqLgMvWansLMwqabnME2aTmlnjaXmlPP+FaGMKw5+vREo9taaNLT+rxSq6tqQIceoeEkE7j cFJcQoT3lxvMaUOm3g/Iq+SfZBSDAT4zsd0YNpa64dPCy6ZgZJniO2aBwAj50yYJSuDbU9cg3s2 fobu2GcWOp40m09f+BfD4jYwTHMApxJm3AI+Ad808172wyKMZH1Z0eXlVoF9yw7Txgc2mzDTSFf rGdLu+3OH2zPFJ9cHMB84MkTROqRMleyb7LEiX8sXdRKzXtGTF0vKN+BwP+0UtUwTjxIVzZvAZV YdbAEOsQRJgw== X-Received: by 2002:a05:6122:319c:b0:56a:995d:8a55 with SMTP id 71dfb90a1353d-56aa0aafaa0mr2391700e0c.12.1772240110383; Fri, 27 Feb 2026 16:55:10 -0800 (PST) Received: from geday ([2804:7f2:800b:feb1::dead:c001]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56a91bb4fbesm8366399e0c.5.2026.02.27.16.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 16:55:09 -0800 (PST) Date: Fri, 27 Feb 2026 21:55:03 -0300 From: Geraldo Nascimento To: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Geraldo Nascimento , Dragan Simic Cc: linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/4] PCI: rockchip-ep: do not attempt 5.0 GT/s retraining Message-ID: <3391ff1386aafbee1754ca114d77961f23e2c09c.1772239598.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop the 5.0 GT/s Link Speed retraining code block from Rockchip PCIe EP driver. The reason is that Shawn Lin from Rockchip has reiterated that there may be danger of "catastrophic failure" in using their PCIe with 5.0 GT/s speeds. While Rockchip has done so informally without issuing a proper errata, and the particulars are thus unknown, this may cause data loss or worse. This change is corroborated by RK3399 official datasheet [1], which states maximum link speed for this platform is 2.5 GT/s. [1] https://opensource.rock-chips.com/images/d/d7/Rockchip_RK3399_Datasheet= _V2.1-20200323.pdf Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@rock= -chips.com/ Cc: stable@vger.kernel.org Reported-by: Dragan Simic Reported-by: Shawn Lin Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip-ep.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/contro= ller/pcie-rockchip-ep.c index 799461335762..9ebc227a1ef8 100644 --- a/drivers/pci/controller/pcie-rockchip-ep.c +++ b/drivers/pci/controller/pcie-rockchip-ep.c @@ -553,19 +553,6 @@ static void rockchip_pcie_ep_link_training(struct work= _struct *work) if (ret) goto again; =20 - /* - * Check the current speed: if gen2 speed was requested and we are not - * at gen2 speed yet, retrain again for gen2. - */ - val =3D rockchip_pcie_read(rockchip, PCIE_CORE_CTRL); - if (!PCIE_LINK_IS_GEN2(val) && rockchip->link_gen =3D=3D 2) { - /* Enable retrain for gen2 */ - rockchip_pcie_ep_retrain_link(rockchip); - readl_poll_timeout(rockchip->apb_base + PCIE_CORE_CTRL, - val, PCIE_LINK_IS_GEN2(val), 50, - LINK_TRAIN_TIMEOUT); - } - /* Check again that the link is up */ if (!rockchip_pcie_ep_link_up(rockchip)) goto again; --=20 2.52.0