From nobody Sun Feb 8 20:23:24 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64849392B64 for ; Tue, 13 Jan 2026 14:13:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768313620; cv=none; b=YEQyI0R9Syv5n+asRxRkQ0jc7PGonXASjFEJ8TPLqvkeAbvSuQfbwdjiRCT80Qq3B8bNMu3mBDGbcGDVx85oGsilLEopX7skXPejjc/zhXow0ouYoFCmQ93olHsnnaTj2kVOdlX87aiylpuL+tihgIOW9e5XQcu+/Sp4S+L+W40= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768313620; c=relaxed/simple; bh=aFzpFhk4WB8ER8iXc03ENFWqRvSrvcCN7LPdyY+0lyk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ibOdhfBujPcLD/LijMBein5/mwk3U2W2xDFiN8VuinBw8FBuJmrk45qYtOack5TOKL72J3Hm1vOyO5xFMPKOTu6ChyDBnlUVzEebja3xXhsbk1xYurelMaH63UaMNMEjpMvBeBc+3qPxV91CxD5Pf4fkDYXzEfADlyE/Kn9553E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RACydkqG; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RACydkqG" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4779aa4f928so76618625e9.1 for ; Tue, 13 Jan 2026 06:13:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768313617; x=1768918417; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TyN9CjZVHq/sRLIyiaBUmdg0t2143/50j9chMJQ/vMY=; b=RACydkqGmghNkeVTNjbbYrR7NdCRfVsICyPuW16Jyo/ax5eFZaO+IbTt2XsFB3uvC3 rdVcjBwUg+vVcZKoTXUn0jVeRa2tpgx1bmHAudZsD3b4nc+Dx1nbpbYdb2i5PCOmRRQn L64Ct6wWfOFpG3yI22pBx6fSPghxe0bNiuWCibc/Cp53IP15zGls2RGn2/vJWhf9BI48 mBm9UEJwx++6GkgJdXwnaiDF13QqTbD3aWwZL0KXIPv7lLUXrWh0/oklmY6j+9HgJ6Bc TGxhV0mxdpLFQsv9PJmEb/0CbM20dz1naN75NiimNK1EQaOlvgcTEPtPhVvGhdCKb9Xo D7PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768313617; x=1768918417; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TyN9CjZVHq/sRLIyiaBUmdg0t2143/50j9chMJQ/vMY=; b=gWdSaFbf0W8Q7e16IHIJAuTAP5cADvCEv1YgL3EJNCKp5/DRlZaoNPcRK38q3hgZOf dUUF5pOFzE+ckCiZTdbjrVCxUB1Ycxe9z4cLJdUVNyTTUbT6+wXOWKhcRqtfPJ/GKZjt gH3FODT2vI2zV6LnX6J8L00jt2H96LeCx8adwZLoEicLi1QJo+2Rdj+wYNXcCrQteMCP kdcTEXDtnNrx1FaGhrCFRn8XOXUBU4lZbk4ZnYg3+XVYdcuxAvlRLiKxLizuUGgGJBCN c/vemfAP+uPozdgHmU3Pe+gp0UqBHbS7ggajML7aCjMVO7QsMylEBvdDRVBarz/wagS8 5PzA== X-Forwarded-Encrypted: i=1; AJvYcCXd4Ou71Iy/1qhJLZIDqQ/sAPrCkD1SHpkawem3utDv+JVjbJ+LUC3veMtdgtyeQFNrAxGu/0gt+8yE0yc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/v/zqhGF9OwD015/EzGlMthI6KsP/DK+y7EGvy7pPYPrEIfk9 sIahfVbwNgWy4NXM+axmUuFaNdXraoVMXLjJVQXoHnRQZhnpNOsfYwsbmuhHUj6P3GXNKooIHhM HbTdy X-Gm-Gg: AY/fxX4vs/VfFXrbSNRgQwWodPXfpm9Fuox8rokgtElPJ9Zy4FjvSgK9Sl+hiGrT3uy 4v1MPZLRuTYQjmHuTFM3MeOZH4wBQRx+pZIlOcqKFGHQ9PdgVSV691CiRbdv69bMKliQrQ/2Iu9 5mEk66nJoQndu1Kgnh0kGZHnimP9Y2GnvA7nkrQFCIdO/uhPJvMTbVNlUP4jWnNkDq+QXbtfjZv vNYwFwK5yZMwiryyp05e21k+/0DxX7OpDorDZ+CP4dS+SrbIMdekJxKfsQ1VPx2zYR/qkRx3Cua ML+8ihHb379LbsXc6KBIwes6CkTCECgfNCHLCs/tGwUDAkCYyiN8RiBXUJJENOds10wMiX2OHE6 ek75Y1cMza5/dFOEQsRbTh+nzD51z9SVyZ6bKn7Du6rUVd2FxaGTUo1iUKo0g0Jc1OyaxdShvr7 9dy0eH0xxFlE68df6w X-Google-Smtp-Source: AGHT+IEV6roObAcijlx4iVb9hdZfVlmXIQUK0U2XACejoOBJ5fxJJv4g1ZBGNz5KDAWxxOTyVwwC4Q== X-Received: by 2002:a05:600c:45ce:b0:47d:264e:b371 with SMTP id 5b1f17b1804b1-47d84b30d79mr233877785e9.18.1768313616542; Tue, 13 Jan 2026 06:13:36 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47edb26792fsm33518525e9.14.2026.01.13.06.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 06:13:36 -0800 (PST) Date: Tue, 13 Jan 2026 17:13:28 +0300 From: Dan Carpenter To: Jan Petrous , Frank Li Cc: s32@nxp.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-s32@linaro.org, imx@lists.linux.dev Subject: [PATCH v3 1/3] net: stmmac: s32: use a syscon for S32_PHY_INTF_SEL_RGMII Message-ID: <30e6a67514e97e798905872e2907b5b005ff2292.1768311583.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On the s32 chipsets the GMAC_0_CTRL_STS register is in GPR region. Originally, accessing this register was done in a sort of ad-hoc way, but we want to use the syscon interface to do it. This is a little bit ugly because we have to maintain backwards compatibility to the old device trees so we have to support both ways to access this register. Signed-off-by: Dan Carpenter --- v3: Unchanged v2: Fix forward porting bug. s/PHY_INTF_SEL_RGMII/S32_PHY_INTF_SEL_RGMII/ .../net/ethernet/stmicro/stmmac/dwmac-s32.c | 23 +++++++++++++++---- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c b/drivers/net/= ethernet/stmicro/stmmac/dwmac-s32.c index 5a485ee98fa7..2e6bb41f49e1 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c @@ -11,12 +11,14 @@ #include #include #include +#include #include #include #include #include #include #include +#include #include =20 #include "stmmac_platform.h" @@ -32,6 +34,8 @@ struct s32_priv_data { void __iomem *ioaddr; void __iomem *ctrl_sts; + struct regmap *sts_regmap; + unsigned int sts_offset; struct device *dev; phy_interface_t *intf_mode; struct clk *tx_clk; @@ -40,7 +44,10 @@ struct s32_priv_data { =20 static int s32_gmac_write_phy_intf_select(struct s32_priv_data *gmac) { - writel(S32_PHY_INTF_SEL_RGMII, gmac->ctrl_sts); + if (gmac->ctrl_sts) + writel(S32_PHY_INTF_SEL_RGMII, gmac->ctrl_sts); + else + regmap_write(gmac->sts_regmap, gmac->sts_offset, S32_PHY_INTF_SEL_RGMII); =20 dev_dbg(gmac->dev, "PHY mode set to %s\n", phy_modes(*gmac->intf_mode)); =20 @@ -125,10 +132,16 @@ static int s32_dwmac_probe(struct platform_device *pd= ev) "dt configuration failed\n"); =20 /* PHY interface mode control reg */ - gmac->ctrl_sts =3D devm_platform_get_and_ioremap_resource(pdev, 1, NULL); - if (IS_ERR(gmac->ctrl_sts)) - return dev_err_probe(dev, PTR_ERR(gmac->ctrl_sts), - "S32CC config region is missing\n"); + gmac->sts_regmap =3D syscon_regmap_lookup_by_phandle_args(dev->of_node, + "nxp,phy-sel", 1, &gmac->sts_offset); + if (gmac->sts_regmap =3D=3D ERR_PTR(-EPROBE_DEFER)) + return PTR_ERR(gmac->sts_regmap); + if (IS_ERR(gmac->sts_regmap)) { + gmac->ctrl_sts =3D devm_platform_get_and_ioremap_resource(pdev, 1, NULL); + if (IS_ERR(gmac->ctrl_sts)) + return dev_err_probe(dev, PTR_ERR(gmac->ctrl_sts), + "S32CC config region is missing\n"); + } =20 /* tx clock */ gmac->tx_clk =3D devm_clk_get(&pdev->dev, "tx"); --=20 2.51.0