From nobody Wed Sep 10 05:43:41 2025 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2060.outbound.protection.outlook.com [40.107.92.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931A72FC024 for ; Mon, 8 Sep 2025 23:29:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757374143; cv=fail; b=QMsYCXrhvzc2jVEewz0OW268OufpSvQzZ1QNy8oARNws4BrRDcbLzHcFYWudAQTBtAh5ipXB4W+cfAaZb87MVGL6tkKGIx+gNKprP0xhpIV36lMKp1qfIPXNNj21OURH8GkVotzEUZ1d4tdGf8mTflEWJVwLJpMjqXIXpZBDxDQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757374143; c=relaxed/simple; bh=QZ004VmpZNyzOWbgnqCxP5lOn52yWfZV7IildWIE4Zg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qN/AgMLNg1eca+j58SV+8M4zbdFRH71I5b2KycSbrErB/PHEi8qu9XtK2wsS5inDpkwPRZdAaKAHUDmBWBpmI3V65Y+1BLgD4DDtzUabbQgil3+7rYZmLXRRYdSuPErfccBZXFnSzQZSPiXnHr1INu6hYxiHlSr3AGs9XRXBIr8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Xfr8/mW0; arc=fail smtp.client-ip=40.107.92.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Xfr8/mW0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=goitxitve+a8L8uVIoTUUnQUvGmWjSGX/pNKuUrtS3/SRYUDg7Qgnw9Zm4ejgBTcYfNlJqhoXl64EecOsba4q1rx/AsNzz6CXvD6gZtJim3y4gWsnfeyzeFVdPYMMBlw9T3x5g3u3b1nGNvJYvvypDAqpz56nh/xbtGRAhO0mjeKRQq3+CKcX8nvG2FmUPZZCOFqgocuKe0Q0TG9xN4qmMxVwsiNY0AQR4piQg7aPz7NyvS90U/IvRqAWzY5sxLSin1y4bUucRHwreXx3wHwm4wpQinkhlmUf6Uaw1CDItmJgO8bHQVCkcqnmC7Su5+eO3s500//+p2mDeaKeh1NYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZhBlCSYddy1zon/1n0cEy4y7xTwnRamgpee904VDseA=; b=kcGDR417ETnWjavjcTiuJGc3gRhI1iBagJ2XGBSkVUsQjWzCOQmOgpjikIMm5ZYwuJHBDilYqLleoFkQeQxQlOOH94EJdy/IBz404ncdTOyiVXKw6LgPzH/cAinN9q19WReo6X8Uk/FgkOqTawjmr03ReVZNxEmay085OS+llK0F9EU47AAsd7OShUSt7GFWAl6PtUsuZ5dsrPCHMN8irF60SHXSEfjvOZ950u5A+6R8G1g1NwNVpFE12pN2RgqoV+M8eswfsL+tmRQTbhYlyMHY1Te6ofY8YE8/x4691CdYt1n0iKG3YjGyXztNs2yOhk9NLhFY7MWl2EQP6BUk7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZhBlCSYddy1zon/1n0cEy4y7xTwnRamgpee904VDseA=; b=Xfr8/mW07AyYCjdgs3Ebfzmiqo84rhpgPn5duZQKpOG9xIwBpNDEYw5v3zTwuxV3Ib9YnEYTtA3bIPfpX2s4YwoQeTVsFkEgxg4E0VkVRwzgg4C0pwb83g+E9C+dA57yVVLwUnaGYRwN3joQUyKtbKpq2qkQBaCa4TiK2foRle53kgIM0YXvVW+QWKp+5HEkMKrxI0U4b1b5IZ0SvqkLZ7c4GAFuAwh9rxZImn44pRC8hlUoDtW7u8lt2hbPcEj0QmZBf9JIvcGWq6m/zM/jQMMkMk1BcjsYu+bCJv2V/x5SufFBVD5PEFSGgiJaKMrQTWE7464KaOLTzIMfI5Cmjg== Received: from BYAPR06CA0017.namprd06.prod.outlook.com (2603:10b6:a03:d4::30) by IA0PR12MB8326.namprd12.prod.outlook.com (2603:10b6:208:40d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.22; Mon, 8 Sep 2025 23:28:54 +0000 Received: from SJ5PEPF000001F0.namprd05.prod.outlook.com (2603:10b6:a03:d4:cafe::52) by BYAPR06CA0017.outlook.office365.com (2603:10b6:a03:d4::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9094.22 via Frontend Transport; Mon, 8 Sep 2025 23:28:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SJ5PEPF000001F0.mail.protection.outlook.com (10.167.242.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.13 via Frontend Transport; Mon, 8 Sep 2025 23:28:54 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 8 Sep 2025 16:28:39 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 8 Sep 2025 16:28:39 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Mon, 8 Sep 2025 16:28:38 -0700 From: Nicolin Chen To: , , CC: , , , , , , , , , , , Subject: [PATCH rfcv2 1/8] iommu/arm-smmu-v3: Clear cmds->num after arm_smmu_cmdq_batch_submit Date: Mon, 8 Sep 2025 16:26:55 -0700 Message-ID: <2f7f5fff38d43221fd60139323d23b258e34cf8d.1757373449.git.nicolinc@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F0:EE_|IA0PR12MB8326:EE_ X-MS-Office365-Filtering-Correlation-Id: d895f002-254a-4f7f-56cc-08ddef2f79f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xuD3n/T+8YjoMawAHqV71YvmFrWvG+hGNpZZqVfNsZQ2dZKLkAjKKmLzzl/8?= =?us-ascii?Q?CQMc3wQZKjvhPBJvC8vFg0uHgbjcFquMWpIVNROVrykM1VSHEhtUTgYBD96K?= =?us-ascii?Q?ICPl7QERMb5Zv6CIjeuRNPeKmC2Ox7P5XzsuL3Oj99gfm+f/v2PtmRcD0nm9?= =?us-ascii?Q?gAVTaWD7qe8HUl33pdJd3d/PrqB05C1YXcMTSrgKIsUnTrfSNBOFJQSWpoxs?= =?us-ascii?Q?ps+aWMx6Pg/FN19CVqn6PubBl3GN1oOKKQdstzIHHbLgi0w16wY80zJ9sGKN?= =?us-ascii?Q?BR4CtNt6IVNU0mLlnVSCCEi3dnJNize7rBIgDhj4ID1D4y6dPDFGiXxejkTe?= =?us-ascii?Q?g8x+j+74bT6gfefh51jxurS3eQH9XG1k0UkwpBctzBX4WUe/Lbgurdwxt3eZ?= =?us-ascii?Q?er2G2+Bjr6sRqLmRHPgukNreVrKzQgPHG00LYv0UcxIM5QFe1vMU3Tjh5AcG?= =?us-ascii?Q?OC/BnDypZlwtlwm2EamhvB0EIbsb80BwIY5ezcnv/2aW8oOt1+Ybe1bjkWDk?= =?us-ascii?Q?Z2Wfpwrvd+K9vw9k8/bTUgx/lq+eP3dxE5T28VRKEdawQEu2HlC4Q/JFComC?= =?us-ascii?Q?Dd9reUZBNeW6oNNsA5TGrtK295VtkVKJMADkmteaEkagODBJ9QEs1hPoGZwL?= =?us-ascii?Q?aVoCp/5A09OLX57iuBnlxME0vzxxztgZ4KqzRXPB9QCB0meyNLpaPrO5iQCX?= =?us-ascii?Q?jPa25zL6ayvuaKtjlrgNVbOlzrsM0PsrYs3JMg46ogJoPUAxjpzwuJCgVabY?= =?us-ascii?Q?vPeKMMM9WEequSaKTYrG1ILn2r5neBjs5ZyDXQI4ENcDrK+S349bmlqfkWdU?= =?us-ascii?Q?9IpSpg6RXbmglLjo5iCYV7P5q5brsG1Y8qWjNbh9BRP1Q4w4+iS6ryA6weFm?= =?us-ascii?Q?u0eyuxa62wMZsHUyNCkaAQt3K2ER0WvzetyTMs2sLojQQNoc5m4fzZnFiGBv?= =?us-ascii?Q?QUNz0MRdW8/yIg3GSHx4JrKs5rfcqQzvfMIFQVBOZAy79anVFZ+sx3ynWPV8?= =?us-ascii?Q?7PbU6nB+p1q+AYu22NtV9EsZReSUsz/tEzBvjEuq7J0sP+pyN9Eu5T8BTr6U?= =?us-ascii?Q?xZl34P8GYOG+NgxjYJljaz1PArw686PBXucOWwwJmvSaI9N1W5gZQ7nYRp0o?= =?us-ascii?Q?3jfd2f1ACVLSZDyO1C+RHrDtQ2vzU+I3BW/PkK2JUF1r094F1EEA5ZRFFf+W?= =?us-ascii?Q?l21AmJa5qPY9kbwbIMy6o6GgfmpB9AVzzI69VMqYytIPzLKESjE2XkHEBvkK?= =?us-ascii?Q?rq5EsvjnFV2/cfxWdcJnvRneGiPHopfBwF04aZMV2fftUqlzPCwtMmQF7E0O?= =?us-ascii?Q?BSO8mk+Ap38lckMVMKHQWbW6Sx28av4vJ/K5ZUqyh7/YMdlxUi6/z+0TXMRc?= =?us-ascii?Q?XPCllBZO2B3oa0ogaBsSs4e4hIyX2gzXQCkN3rXMkxJfB+G1dRi+11knP7gA?= =?us-ascii?Q?Ig0XMAofPX/5ODT+6TfOpymXHUzFz7j6s818gl8OMfI1dWy3RV1erxfskm15?= =?us-ascii?Q?ng0624jvvvTXuolShOZDjcwUNzKFOv08OVj4?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2025 23:28:54.4695 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d895f002-254a-4f7f-56cc-08ddef2f79f3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8326 Content-Type: text/plain; charset="utf-8" None of the callers of arm_smmu_cmdq_batch_submit() cares about the batch after a submission. So, it'll be certainly safe to nuke the cmds->num, at least upon a successful one. This will ease a bit a wrapper function, for the new arm_smmu_invs structure. Signed-off-by: Nicolin Chen Acked-by: Balbir Singh --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/ar= m/arm-smmu-v3/arm-smmu-v3.c index 2a8b46b948f05..cccf8f52ee0d5 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -974,11 +974,17 @@ static void arm_smmu_cmdq_batch_add(struct arm_smmu_d= evice *smmu, cmds->num++; } =20 +/* Clears cmds->num after a successful submission */ static int arm_smmu_cmdq_batch_submit(struct arm_smmu_device *smmu, struct arm_smmu_cmdq_batch *cmds) { - return arm_smmu_cmdq_issue_cmdlist(smmu, cmds->cmdq, cmds->cmds, - cmds->num, true); + int ret; + + ret =3D arm_smmu_cmdq_issue_cmdlist(smmu, cmds->cmdq, cmds->cmds, + cmds->num, true); + if (!ret) + cmds->num =3D 0; + return ret; } =20 static void arm_smmu_page_response(struct device *dev, struct iopf_fault *= unused, --=20 2.43.0