From nobody Fri Oct 3 15:37:46 2025 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 915891D61BB; Fri, 29 Aug 2025 13:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756472532; cv=none; b=rQvRXRifwC/muByov//NCWOOIkgMKXDH3HAyaA28LClS6mSL5WgEeupZZB+eLGpmvVViUG70W8W66GeO3jO2iMj97tFs1VEBAIwL4oPpXs48lAMMv3JwSl7jK7P59gpAYvBywIuEHkCjT3Ka/cBb4RtbCvDB7nJAr5mei6Z+67k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756472532; c=relaxed/simple; bh=3exr+R0hiXsx+XjCb6ENdO5HQJKlO9q31XLHKtJ7S2A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J7m1CTyxsEDCJgo2vFN9KeY9reH9dtAI3AjzQalncpNNqQYIYRE/BVSIO/uXS0NzcqHvpRgC3Iv5pUg3u3ICSp6hvOV7XDGQOx87gq/hLBCMBfGtHgqAwZya4jDRngU0uQeY6Hcc0vGQGaztBVjqp5iAbumn1J/9af/maK4jLOc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98.2) (envelope-from ) id 1uryk1-000000002AD-3JeU; Fri, 29 Aug 2025 13:02:05 +0000 Date: Fri, 29 Aug 2025 14:02:02 +0100 From: Daniel Golle To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hauke Mehrtens , Russell King , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Andreas Schirm , Lukas Stockmann , Alexander Sverdlin , Peter Christen , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin Subject: [PATCH v3 3/6] net: dsa: lantiq_gswip: ignore SerDes modes in phylink_mac_config() Message-ID: <294ece00d008a97af17d9019d158d314d13c0695.1756472076.git.daniel@makrotopia.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We can safely ignore SerDes interface modes 1000Base-X, 2500Base-X and SGMII in phylink_mac_config() as they are being taken care of by the PCS and the SGMII port anyway doesn't have MII_CFG and MII_PCDU registers and hence gswip_phylink_mac_config() is already a no-op apart from outputing a misleading error message. Return early in case of SerDes interface modes to avoid printing that error message. Signed-off-by: Daniel Golle Reviewed-by: Hauke Mehrtens --- v3: improve commit message v2: no changes drivers/net/dsa/lantiq/lantiq_gswip.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/lantiq/lantiq_gswip.c b/drivers/net/dsa/lantiq= /lantiq_gswip.c index acb6996356e9..3e2a54569828 100644 --- a/drivers/net/dsa/lantiq/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq/lantiq_gswip.c @@ -1444,6 +1444,10 @@ static void gswip_phylink_mac_config(struct phylink_= config *config, miicfg |=3D GSWIP_MII_CFG_LDCLKDIS; =20 switch (state->interface) { + case PHY_INTERFACE_MODE_SGMII: + case PHY_INTERFACE_MODE_1000BASEX: + case PHY_INTERFACE_MODE_2500BASEX: + return; case PHY_INTERFACE_MODE_MII: case PHY_INTERFACE_MODE_INTERNAL: miicfg |=3D GSWIP_MII_CFG_MODE_MIIM; --=20 2.51.0