From nobody Thu Apr 9 17:58:06 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65B053BED40; Tue, 3 Mar 2026 14:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772547997; cv=none; b=fzbuL3dwT/i/6tOXBx6wLINrRRgDZ0pT19vy518XArVsQYJWZHFOvuZh3lXIu5QHaPdtHOUv6svvjeaQesac/rCocjV5Ht27bQKx4y5mQ35DDJa8gv2RRmaRbZqX0rYxwqd6vJca5bW/lSVCaNzYtN/bafHiVZ0ucjskUvhNybI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772547997; c=relaxed/simple; bh=V77Vef1lGeU7KNrGbwZQq9wh14fSJAB9UhZf/XRGgvQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=p7MUG0kPePEb7qJE9sHHqNlTNQulprg/7owVj4wSqOaOoUgqLjYmmaPyemtvmOsQwzl/LSuyghHziS78kc1TniZbyuYapKRKy1+nvHpgzMADopmrC1bh6dO53B3JZbsjb2B3U/L0EVNHS8kEdbLrDHRRaAsYGjh44hDFtIE/q8k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c0N5X7ME; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c0N5X7ME" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B0CDC116C6; Tue, 3 Mar 2026 14:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772547997; bh=V77Vef1lGeU7KNrGbwZQq9wh14fSJAB9UhZf/XRGgvQ=; h=From:To:Cc:Subject:Date:From; b=c0N5X7MErl84IR+YSi1jyCLgkC+jmxUyzqeZWnOgy/FRdXNCl6dqLxlEyeHKjWne7 SC1BliHACWjsKIE3RW39L3jEgg87Nald2IA1f8u1b0lkgBj2m9OLV+9dXKhIPwu91y jNnzPuQR8tn6QaukaoVPqYNLK6t6Cc4o0SsXQ1sal2jJCknci6URSiG9oPSxXBAO3V Org+eDob8h7Nd8VqMC0MxJY1NcncKQ+S+B4ObbDTQsBt6HHyHB4lG5Y+/6FxQshftW MQ15TBWlsmRbE+f/xWqnDmsOP15rMDKIzvONFzY0UHHluwmxwt3AsXmiH0yR17PcYJ PXsSnv/PJipew== From: "Rafael J. Wysocki" To: Linux ACPI Cc: =?ISO-8859-1?Q?P=E9ter?= Ujfalusi , LKML , Linux PM Subject: [PATCH v1] Revert "ACPI: PM: Let acpi_dev_pm_attach() skip devices without ACPI PM" Date: Tue, 03 Mar 2026 15:26:31 +0100 Message-ID: <2829615.mvXUDI8C0e@rafael.j.wysocki> Organization: Linux Kernel Development Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Rafael J. Wysocki" Revert commit 88fad6ce090b ("ACPI: PM: Let acpi_dev_pm_attach() skip devices without ACPI PM") that introduced SoundWire suspend regression [1]. It is actually not true that the commit above doesn't make a functional difference because acpi_subsys_suspend(), for example, may resume devices in runtime-suspend which affects the subsequent handling of those devices during the suspend transition. For this reason, the devices that were handled by the ACPI PM domain before that commit may be handled differently now which may lead to suspend-resume issues. Fixes: 88fad6ce090b ("ACPI: PM: Let acpi_dev_pm_attach() skip devices witho= ut ACPI PM") Reported-by: P=C3=A9ter Ujfalusi Closes: https://github.com/thesofproject/linux/pull/5677#issuecomment-39843= 75077 [1] Signed-off-by: Rafael J. Wysocki --- drivers/acpi/device_pm.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c index f2579611e0a5..aa55ecfc2923 100644 --- a/drivers/acpi/device_pm.c +++ b/drivers/acpi/device_pm.c @@ -1456,15 +1456,6 @@ int acpi_dev_pm_attach(struct device *dev, bool powe= r_on) if (!adev || !acpi_match_device_ids(adev, special_pm_ids)) return 0; =20 - /* - * Skip devices whose ACPI companions don't support power management and - * don't have a wakeup GPE. - */ - if (!acpi_device_power_manageable(adev) && !acpi_device_can_wakeup(adev))= { - dev_dbg(dev, "No ACPI power management or wakeup GPE\n"); - return 0; - } - /* * Only attach the power domain to the first device if the * companion is shared by multiple. This is to prevent doing power --=20 2.51.0